- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Expand VTY option which controls use of TCH for signalling
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: iedemam, neels, pespin, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 ) Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Patch Set 4: (2 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/9dd0757c_0859f3fe PS4, Line 524: chan_alloc_allow_tch_for_signalling cosmetic: I'd rename it to "tch_for_signalling_policy" or something like that which makes it more clear that it's no longer some boolean value. Changing from bool to an enum but keeping the name identical might also hide bugs, as existing code using "if (chan_alloc_allow_tch_for_signalling)" will still compile but probably no longer do what we expect it to do. File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/a036c560_c466fe52 PS4, Line 568: DEFUN_ATTR it might be nice to add a backwards-compatibility alias for the (0|1) so old config files still parse. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 4 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28289 ) Change subject: BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e38142d29d0fa2946a858eac13319aa05b42aa3 Gerrit-Change-Number: 28289 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:17:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: remove redundant f_init()/f_sleep() calls
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 ) Change subject: BSC_Tests: remove redundant f_init()/f_sleep() calls ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I625763b03c78835f6c4a80edd40cb3572411f7a2 Gerrit-Change-Number: 28288 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:17:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts
by fixeria 14 Jun '22

14 Jun '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28289 ) Change subject: BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts ...................................................................... BSC_Tests: fix race conditions in TC_imm_ass_pre_{ts,chan}_ack_dyn_ts The TC_imm_ass_pre_chan_ack_dyn_ts sporadically fails on Jenkins. Similar to [1], this is happening because the VTY command setting the 'immediate-assignment' strategy back to 'post-chan-ack' is being sent/processed earlier than the CHANnel REQ message. TC_imm_ass_pre_ts_ack_dyn_ts is likely affected too, also fix it. Change-Id: I1e38142d29d0fa2946a858eac13319aa05b42aa3 Related: [1] I38cd31041741b69eb15098a089b4d4b6b918ffd4 --- M bsc/BSC_Tests.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/28289/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 8de3dcb..200fd5b 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -11081,9 +11081,6 @@ var uint8_t ra := 2; f_ipa_tx(ts_RSL_CHAN_RQD(int2oct(ra, 1), fn)); - /* (set bts 0 cfg back to default) */ - f_vty_set_imm_ass(BSCVTY); - /* Expect the dyn TS to deactivate PDCH first */ f_exp_ipa_rx(tr_RSL_RF_CHAN_REL(chan_nr)); f_ipa_tx(ts_RSL_RF_CHAN_REL_ACK(chan_nr)); @@ -11116,6 +11113,9 @@ dt.sccp_conn_id := rx_c_ind.connectionId; BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); + /* (set bts 0 cfg back to default) */ + f_vty_set_imm_ass(BSCVTY); + f_sleep(1.0); f_perform_clear_test_ct(dt); f_shutdown_helper(); @@ -11153,9 +11153,6 @@ var uint8_t ra := 2; f_ipa_tx(ts_RSL_CHAN_RQD(int2oct(ra, 1), fn)); - /* (set bts 0 cfg back to default) */ - f_vty_set_imm_ass(BSCVTY); - /* Expect the dyn TS to deactivate PDCH first */ f_exp_ipa_rx(tr_RSL_RF_CHAN_REL(chan_nr)); @@ -11189,6 +11186,9 @@ dt.sccp_conn_id := rx_c_ind.connectionId; BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); + /* (set bts 0 cfg back to default) */ + f_vty_set_imm_ass(BSCVTY); + f_sleep(1.0); f_perform_clear_test_ct(dt); f_shutdown_helper(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e38142d29d0fa2946a858eac13319aa05b42aa3 Gerrit-Change-Number: 28289 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: remove redundant f_init()/f_sleep() calls
by fixeria 14 Jun '22

14 Jun '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 ) Change subject: BSC_Tests: remove redundant f_init()/f_sleep() calls ...................................................................... BSC_Tests: remove redundant f_init()/f_sleep() calls Calling f_init() more than once does not make sense. Change-Id: I625763b03c78835f6c4a80edd40cb3572411f7a2 --- M bsc/BSC_Tests.ttcn 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/88/28288/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 8a7d465..8de3dcb 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -11074,9 +11074,6 @@ var RSL_Message chan_act; var RSL_Message imm_ass; - f_init(1, false); - f_sleep(1.0); - f_vty_set_imm_ass(BSCVTY, 0, "pre-chan-ack"); /* RA containing reason=LU */ @@ -11149,9 +11146,6 @@ var RSL_Message chan_act; var RSL_Message imm_ass; - f_init(1, false); - f_sleep(1.0); - f_vty_set_imm_ass(BSCVTY, 0, "pre-ts-ack"); /* RA containing reason=LU */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I625763b03c78835f6c4a80edd40cb3572411f7a2 Gerrit-Change-Number: 28288 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: Expand VTY option which controls use of TCH for signalling
by iedemam 14 Jun '22

14 Jun '22

Attention is currently required from: iedemam, neels, laforge, pespin, fixeria, dexter. Hello Jenkins Builder, neels, laforge, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 to look at the new patch set (#4). Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Expand VTY option which controls use of TCH for signalling For statistical clarity and site tuning, it is sometimes desirable to completely disable the use of TCH for signaling. In the existing version of this VTY command, there is no way to accomplish this. We can only restrict TCH for signaling non-voice related actions. This patch adds the ability to completely disable signaling on TCH. Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M tests/osmo-bsc.vty 5 files changed, 42 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/28276/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 4 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-bsc[master]: Expand VTY option which controls use of TCH for signalling
by iedemam 14 Jun '22

14 Jun '22

Attention is currently required from: iedemam, neels, laforge, pespin, fixeria, dexter. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 ) Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: Hi all, I took a second pass at this to iron out the strange (0|1|call-only) settings and convert to an enum. I've changed it to be (never|voice|always) and allowed it to accept (0|1) with their previous meaning. Cleaner...but I'm not sure how you typically handle changing settings values gracefully. File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/ed9923ac_1975f4d4 PS2, Line 517: /* If SDCCHs are exhausted: > Sounds like we want an enum here ;) 100% -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 18:32:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Expand VTY option which controls use of TCH for signalling
by iedemam 14 Jun '22

14 Jun '22

Attention is currently required from: neels, laforge, pespin, fixeria, dexter. Hello Jenkins Builder, neels, laforge, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 to look at the new patch set (#3). Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Expand VTY option which controls use of TCH for signalling For statistical clarity and site tuning, it is sometimes desirable to completely disable the use of TCH for signaling. In the existing version of this VTY command, there is no way to accomplish this. We can only restrict TCH for signaling non-voice related actions. This patch adds the ability to completely disable signaling on TCH. Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M tests/osmo-bsc.vty 5 files changed, 42 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/28276/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-upf[master]: move libosmo-gtlv to libosmocore.git
by neels 14 Jun '22

14 Jun '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28287 ) Change subject: move libosmo-gtlv to libosmocore.git ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: build failure obviously because libosmo-gtlv first needs to be added to libosmocore.git -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Id72cdf94da60d4b6d09d0044c74e672c4412c15d Gerrit-Change-Number: 28287 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 14 Jun 2022 17:51:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: install libosmo-gtlv, libosmo-pfcp
by neels 14 Jun '22

14 Jun '22

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28245 ) Change subject: install libosmo-gtlv, libosmo-pfcp ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6 Gerrit-Change-Number: 28245 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 0

2026

2025

2024

2023

2022

gerrit-log