- gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: mgw_fsm: Mark structs as static const
by laforge 14 Jun '22

14 Jun '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28279 ) Change subject: mgw_fsm: Mark structs as static const ...................................................................... mgw_fsm: Mark structs as static const Change-Id: Ie62f28587c08296429c0dabda7b6add67ffa010c --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index b84d87e..e71624b 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -122,12 +122,12 @@ uint16_t msc_rtp_port; }; -struct osmo_tdef mgw_tdefs[] = { +static const struct osmo_tdef mgw_tdefs[] = { {.T = -2427, .default_val = 5, .desc = "timeout for MGCP response from MGW" }, { } }; -struct osmo_tdef_state_timeout mgw_fsm_timeouts[32] = { +static const struct osmo_tdef_state_timeout mgw_fsm_timeouts[32] = { [MGW_ST_CRCX_HNB] = {.T = -1001 }, [MGW_ST_ASSIGN] = {.T = -1002 }, [MGW_ST_MDCX_HNB] = {.T = -1003 }, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie62f28587c08296429c0dabda7b6add67ffa010c Gerrit-Change-Number: 28279 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: mgw_fsm: Improve logging
by laforge 14 Jun '22

14 Jun '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28280 ) Change subject: mgw_fsm: Improve logging ...................................................................... mgw_fsm: Improve logging Change-Id: I14785b6bc798c3bae8c552bccb55ca4fa9f2f416 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index e71624b..1974e33 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -176,7 +176,7 @@ case MGW_EV_MGCP_OK: mgw_info = osmo_mgcpc_ep_ci_get_rtp_info(mgw_fsm_priv->mgcpc_ep_ci_hnb); if (!mgw_info) { - LOGPFSML(fi, LOGL_ERROR, "Got no response from MGW\n"); + LOGPFSML(fi, LOGL_ERROR, "Got no RTP info response from MGW\n"); osmo_fsm_inst_state_chg(fi, MGW_ST_FAILURE, 0, 0); return; } @@ -321,7 +321,7 @@ case MGW_EV_MGCP_OK: mgw_info = osmo_mgcpc_ep_ci_get_rtp_info(mgw_fsm_priv->mgcpc_ep_ci_hnb); if (!mgw_info) { - LOGPFSML(fi, LOGL_ERROR, "Got no response from MGW\n"); + LOGPFSML(fi, LOGL_ERROR, "Got no RTP info response from MGW\n"); osmo_fsm_inst_state_chg(fi, MGW_ST_FAILURE, 0, 0); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I14785b6bc798c3bae8c552bccb55ca4fa9f2f416 Gerrit-Change-Number: 28280 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: cosmetic: mgw_fsm: Fix typo in log
by laforge 14 Jun '22

14 Jun '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28281 ) Change subject: cosmetic: mgw_fsm: Fix typo in log ...................................................................... cosmetic: mgw_fsm: Fix typo in log Change-Id: I80aa61a288ab37c51510af67c784498f5949fc50 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 1974e33..5dd613f 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -672,7 +672,7 @@ initialized = true; } - /* The RTP stream negortiation usually begins with a RAB-AssignmentRequest and ends with an IU-Release, however + /* The RTP stream negotiation usually begins with a RAB-AssignmentRequest and ends with an IU-Release, however * it may also be thet the MSC decides to release the RAB with a dedicated RAB-AssignmentRequest that contains * a ReleaseList. In this case an FSM will already be present. */ if (map->mgw_fi) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I80aa61a288ab37c51510af67c784498f5949fc50 Gerrit-Change-Number: 28281 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: mgw_fsm: Change macro to not use local variables implicitly
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28282 ) Change subject: mgw_fsm: Change macro to not use local variables implicitly ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id694f51bb2918fd27da87b3f4a905727cd7f5de6 Gerrit-Change-Number: 28282 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:55:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: cosmetic: mgw_fsm: Fix typo in log
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28281 ) Change subject: cosmetic: mgw_fsm: Fix typo in log ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I80aa61a288ab37c51510af67c784498f5949fc50 Gerrit-Change-Number: 28281 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:29:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: mgw_fsm: Improve logging
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28280 ) Change subject: mgw_fsm: Improve logging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I14785b6bc798c3bae8c552bccb55ca4fa9f2f416 Gerrit-Change-Number: 28280 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:29:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: mgw_fsm: Mark structs as static const
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28279 ) Change subject: mgw_fsm: Mark structs as static const ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie62f28587c08296429c0dabda7b6add67ffa010c Gerrit-Change-Number: 28279 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:28:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: add libosmo-gtlv, moved from osmo-upf.git
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28286 ) Change subject: add libosmo-gtlv, moved from osmo-upf.git ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I don't like mixing conventions in a single project (here: libosmocore), sorry :/ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71 Gerrit-Change-Number: 28286 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:28:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: cosmetic tweak in Makefile.am
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28285 ) Change subject: cosmetic tweak in Makefile.am ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I141e502ffbb1a45f9751943d47766bdfbf77484a Gerrit-Change-Number: 28285 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:27:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: add pfcp_endpoint
by laforge 14 Jun '22

14 Jun '22

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 ) Change subject: add pfcp_endpoint ...................................................................... Patch Set 4: (7 comments) File include/osmocom/pfcp/pfcp_endpoint.h: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/50144b27_ee15e654 PS3, Line 51: struct osmo_pfcp_endpoint { > Given this probably ends up as a public API in a shared library I think this is precisely the time t […] not sure why endp is supposed to be better than endpoint? Does it matter? https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/7b29a519_7ebdaa09 PS3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx; > can we call all these callbacks with _cb at the end? agreed https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/47d23ff1_8137b681 PS3, Line 99: int osmo_pfcp_endpoint_tx(struct osmo_pfcp_endpoint *ep, struct osmo_pfcp_msg *m); > something more meaningful like "pfcp_msg" instead of "m" may be worth a change. does it matter in a prototype? https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/b80ff51f_d736cfff PS3, Line 104: > You call it API bloat, I call it do not break ABI next time you add something new in eg. […] In general, the question is whether 'struct osmo_pfcp_endpoint' is supposed to be publicly exposed to every application. At this point you will have a very tight ABI coupling. The clean and safe approach is to go for what pespin is asking. In Osmocom we don't have a clear policy on what should be done. If we expect the struct will still be in flux a bit in the forseeable future, it might be an extra reason to go for the setter/getter functions. File src/libosmo-pfcp/pfcp_endpoint.c: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/8e4d1cab_55463bd5 PS3, Line 44: struct osmo_timer_list t1; > that's the point of the osmo_timer API: it keeps a list and waits for the first entry, later timers […] Done https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/95eec113_07e449b8 PS3, Line 177: static void pfcp_queue_timer_cb(void *data) > "timer_cb" is consistent: for example in osmo_fsm, the name is timer_cb, and it means that a timer h […] Done File src/libosmo-pfcp/pfcp_endpoint.c: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/d83091a9_ea992973 PS4, Line 268: /* Slight optimization: Add sent requests to the start of the list: we will usually receive a response shortly > You say to the start of the queue, but you do add_tail in both. […] I haven't done a deep review, but if there is no reason to have a shared path/queue for requests and responses, I would also think it's more logical to keep them separate. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jun 2022 19:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log