- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: add libosmo-gtlv, moved from osmo-upf.git
by pespin 15 Jun '22

15 Jun '22

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28286 ) Change subject: add libosmo-gtlv, moved from osmo-upf.git ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: I agree with @laforge, let's keep same structure for all libs: > I can rename tests/libosmo-gtlv to tests/gtlv. Yes > Do I have to remove the dash from "libosmo-gtlv"? Yes > I'd have to also remove the dash in the places that use libosmo-gtlv. The dash was fine in osmo-upf.git, I'd like to keep it. You still need to do modifications there to drop libosmo-gtlv from the repo, so that can be done at the same time. I think it's fine keeping it here in libosmocore, changing the above should be pretty quick. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28286 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I25ab400f0c5707fdc0d8e480aca19871c2e26e71 Gerrit-Change-Number: 28286 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Jun 2022 10:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: mgw_fsm: Simplify cleanup paths
by fixeria 15 Jun '22

15 Jun '22

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 ) Change subject: mgw_fsm: Simplify cleanup paths ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284/comment/80c697c1_7cfa4f1a PS1, Line 158: mgw_fsm_alloc_and_handle_rab_ass_req > This is not valid anymore and should be removed. […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284/comment/477ca6e2_684dea34 PS1, Line 167: mgw_fsm_alloc_and_handle_rab_ass_req > Same here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8883e737fa112cff57834abae7ef272388a54edb Gerrit-Change-Number: 28284 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:58:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: cosmetic tweak in Makefile.am
by pespin 15 Jun '22

15 Jun '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28285 ) Change subject: cosmetic tweak in Makefile.am ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/28285/comment/b7f86d82_de91786f PS1, Line 7: src/vty \ I wonder why we do have 2 level subdirs here instead of putting those inside src/Makefile.am. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I141e502ffbb1a45f9751943d47766bdfbf77484a Gerrit-Change-Number: 28285 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:58:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: mgw_fsm: Simplify cleanup paths
by pespin 15 Jun '22

15 Jun '22

Attention is currently required from: pespin, dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 to look at the new patch set (#2). Change subject: mgw_fsm: Simplify cleanup paths ...................................................................... mgw_fsm: Simplify cleanup paths Let's have a unified way of freeing the FSM instance once it was allocated, otherwise it's far more difficult to understand and maintain. Change-Id: I8883e737fa112cff57834abae7ef272388a54edb --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 34 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/84/28284/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8883e737fa112cff57834abae7ef272388a54edb Gerrit-Change-Number: 28284 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-hnbgw[master]: mgw_fsm: Fix error path accessing uninitialized fsm ptr
by pespin 15 Jun '22

15 Jun '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 ) Change subject: mgw_fsm: Fix error path accessing uninitialized fsm ptr ...................................................................... mgw_fsm: Fix error path accessing uninitialized fsm ptr The error handling of the error path was wrong. Let's remove the "fi" variable to avoid more of such errors. Furthermore, add an assert to clarify for the reader that the map->mgw_fi will be freed before allocating a new FSM instance below. Change-Id: I9d3bca552bfa77f5e18f75bedad8d422f74df1f8 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 2b7484f..1360849 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -658,7 +658,6 @@ int handle_rab_ass_req(struct hnbgw_context_map *map, struct osmo_prim_hdr *oph, ranap_message *message) { static bool initialized = false; - struct osmo_fsm_inst *fi; struct mgw_fsm_priv *mgw_fsm_priv; struct osmo_sockaddr addr; struct osmo_sockaddr_str addr_str; @@ -683,7 +682,8 @@ LOGPFSML(map->mgw_fi, LOGL_ERROR, "mgw_fsm_alloc_and_handle_rab_ass_req() unable to handle RAB-AssignmentRequest!\n"); - osmo_fsm_inst_state_chg(fi, MGW_ST_FAILURE, 0, 0); + osmo_fsm_inst_state_chg(map->mgw_fi, MGW_ST_FAILURE, 0, 0); + OSMO_ASSERT(map->mgw_fi == NULL); } mgw_fsm_priv = talloc_zero(map, struct mgw_fsm_priv); @@ -723,9 +723,8 @@ /* Allocate the FSM and start it. */ mgw_fsm_priv->map = map; snprintf(fsm_name, sizeof(fsm_name), "mgw-fsm-%u-%u", map->rua_ctx_id, mgw_fsm_priv->rab_id); - fi = osmo_fsm_inst_alloc(&mgw_fsm, map, mgw_fsm_priv, LOGL_DEBUG, fsm_name); - map->mgw_fi = fi; - mgw_fsm_state_chg(fi, MGW_ST_CRCX_HNB); + map->mgw_fi = osmo_fsm_inst_alloc(&mgw_fsm, map, mgw_fsm_priv, LOGL_DEBUG, fsm_name); + mgw_fsm_state_chg(map->mgw_fi, MGW_ST_CRCX_HNB); return 0; error: -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9d3bca552bfa77f5e18f75bedad8d422f74df1f8 Gerrit-Change-Number: 28283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-upf[master]: move libosmo-gtlv to libosmocore.git
by pespin 15 Jun '22

15 Jun '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28287 ) Change subject: move libosmo-gtlv to libosmocore.git ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Id72cdf94da60d4b6d09d0044c74e672c4412c15d Gerrit-Change-Number: 28287 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:48:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: mgw_fsm: Simplify cleanup paths
by fixeria 15 Jun '22

15 Jun '22

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 ) Change subject: mgw_fsm: Simplify cleanup paths ...................................................................... Patch Set 1: (2 comments) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284/comment/fde0a44a_742c4232 PS1, Line 158: mgw_fsm_alloc_and_handle_rab_ass_req This is not valid anymore and should be removed. LOGPFSML() will provide enough context for logging messages. https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284/comment/0ed3223a_643f9541 PS1, Line 167: mgw_fsm_alloc_and_handle_rab_ass_req Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8883e737fa112cff57834abae7ef272388a54edb Gerrit-Change-Number: 28284 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:36:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: cosmetic tweak in Makefile.am
by fixeria 15 Jun '22

15 Jun '22

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28285 ) Change subject: cosmetic tweak in Makefile.am ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I141e502ffbb1a45f9751943d47766bdfbf77484a Gerrit-Change-Number: 28285 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:21:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: mgw_fsm: Fix error path accessing uninitialized fsm ptr
by fixeria 15 Jun '22

15 Jun '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 ) Change subject: mgw_fsm: Fix error path accessing uninitialized fsm ptr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9d3bca552bfa77f5e18f75bedad8d422f74df1f8 Gerrit-Change-Number: 28283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:18:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: cards: populate ADM1 key reference member
by fixeria 15 Jun '22

15 Jun '22

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28278 ) Change subject: cards: populate ADM1 key reference member ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/28278/comment/2ecf7bc9_1f32ac36 PS1, Line 9: speficy specify? https://gerrit.osmocom.org/c/pysim/+/28278/comment/ef6424be_a56e3edd PS1, Line 10: inherets inherits File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/28278/comment/16360fd8_1e3bf294 PS1, Line 350: print("NOW") This looks like a debugging leftover that should have been removed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96af395b1832f4462a6043cca3bb3812fddac612 Gerrit-Change-Number: 28278 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 09:17:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log