- gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: implement GTP tunnel mapping via netfilter
by neels 19 Jun '22

19 Jun '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28309 ) Change subject: implement GTP tunnel mapping via netfilter ...................................................................... Patch Set 5: (1 comment) This change is ready for review. Patchset: PS5: the build error comes from the VTY-test, from the nftables command "add table inet osmo-upf" happening at osmo-upf startup. I think the reason for failure is that it requires cap_net_admin? Could also be that the kernel is too old? Ways to resolve: - change osmo-upf: only dispatch "add table" the first time nftables is used. But i think it is a good idea for production admin to verify at startup that nftables is usable. This change would be a dumb workaround for our CI only. - change build job: I guess add cap_net_admin to the binary, but i thought the build job is already running as root in a docker container. Maybe need a newer kernel??? i'll try to find out... -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic0d319eb4f98cd51a5999c804c4203ab0bdda650 Gerrit-Change-Number: 28309 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Jun 2022 12:31:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: add pfcp_endpoint
by neels 19 Jun '22

19 Jun '22

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 ) Change subject: add pfcp_endpoint ...................................................................... Patch Set 4: (2 comments) File include/osmocom/pfcp/pfcp_endpoint.h: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/b6d5e571_7b47d9c4 PS3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx; > General comment: Pointing to historical mistakes is never a good reason not to improve new code. […] the difficulty is to distinguish between historical mistakes and established conventions, there is no clear discussion and agreement on these things AFAICT... https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/c1ad6694_34bc9d42 PS3, Line 104: > We used a lot of public structs in the beginning, and my experience is that this _usually_ haunts us […] i'll see if i can apply the extra mile without too much effort. (this will have to happen in libosmo-pfcp.git now, where this patch accidentally already slipped into the master branch during migration) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Jun 2022 12:23:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: add osmo-upf
by neels 19 Jun '22

19 Jun '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28308 ) Change subject: add osmo-upf ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: combine previous votes after linter fixes -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I745bcbde6859004c41ddbfd2558036bf9a2d1de2 Gerrit-Change-Number: 28308 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Jun 2022 12:16:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-upf[master]: add osmo-upf
by neels 19 Jun '22

19 Jun '22

Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/28308 to look at the new patch set (#4). Change subject: add osmo-upf ...................................................................... add osmo-upf Related: SYS#5599 Change-Id: I745bcbde6859004c41ddbfd2558036bf9a2d1de2 --- A doc/examples/osmo-upf/osmo-upf-create-dev.cfg M doc/examples/osmo-upf/osmo-upf.cfg M include/osmocom/upf/Makefile.am A include/osmocom/upf/up_endpoint.h A include/osmocom/upf/up_gtp_action.h A include/osmocom/upf/up_peer.h A include/osmocom/upf/up_session.h A include/osmocom/upf/up_session_to_gtp.c M include/osmocom/upf/upf.h A include/osmocom/upf/upf_gtp.h A include/osmocom/upf/upf_nft.h M src/osmo-upf/Makefile.am M src/osmo-upf/osmo_upf_main.c A src/osmo-upf/up_endpoint.c A src/osmo-upf/up_gtp_action.c A src/osmo-upf/up_peer.c A src/osmo-upf/up_peer_fsm.c A src/osmo-upf/up_session.c M src/osmo-upf/upf.c A src/osmo-upf/upf_gtp.c A src/osmo-upf/upf_vty.c M tests/upf.vty 22 files changed, 4,054 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/08/28308/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I745bcbde6859004c41ddbfd2558036bf9a2d1de2 Gerrit-Change-Number: 28308 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-upf[master]: add libgtpnl dependency
by neels 19 Jun '22

19 Jun '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28307 ) Change subject: add libgtpnl dependency ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: re-add previous vote after trivial fix -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9928be6f62f5a89d98bdac63428f7a046c95c855 Gerrit-Change-Number: 28307 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 19 Jun 2022 12:03:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:nightly/osmo-trx in Raspbian_11/armv7l
by OBS Notification 19 Jun '22

19 Jun '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-trx failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 177s] [483/641] installing texlive-lang-greek-2020.20210202-2 [ 186s] [484/641] installing texlive-luatex-2020.20210202-3 [ 188s] [485/641] installing libpangocairo-1.0-0-1.46.2-3 [ 188s] [486/641] installing passwd-1:4.8.1-1 [ 189s] Shadow passwords are now on. [ 189s] [487/641] installing adduser-3.118 [ 190s] [488/641] installing libexpat1-dev-2.2.10-2+deb11u3 [ 190s] [489/641] installing libnuma-dev-2.0.12-1 [ 190s] [490/641] installing libsctp-dev-1.0.18+dfsg-1 [ 190s] [491/641] installing zlib1g-dev-1:1.2.11.dfsg-2+deb11u1 [ 190s] [492/641] installing libicu-dev-67.1-7 [ 193s] [493/641] installing python3-3.9.2-3 [ 193s] [494/641] installing tipa-2:1.3-20.1 [ 194s] [495/641] installing libstdc++-10-dev-10.2.1-6+rpi1 [ 195s] [496/641] installing texlive-bibtex-extra-2020.20210202-3 [ 200s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/texlive-bibtex-extra.deb' (size=67193052) member 'data.tar': lzma error: compressed data is corrupt [ 200s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 200s] dpkg: error processing archive .init_b_cache/texlive-bibtex-extra.deb (--install): [ 200s] cannot copy extracted data for './usr/share/doc/texlive-doc/latex/biblatex-morenames/documentation/biblatex-morenames.pdf' to '/usr/share/doc/texlive-doc/latex/biblatex-morenames/documentation/biblatex-morenames.pdf.dpkg-new': unexpected end of file or stream [ 200s] Errors were encountered while processing: [ 200s] .init_b_cache/texlive-bibtex-extra.deb [ 200s] exit ... [ 200s] ### VM INTERACTION START ### [ 200s] [ 173.249477] sysrq: SysRq : Power Off [ 200s] [ 173.250869] reboot: Power down [ 200s] ### VM INTERACTION END ### [ 200s] [ 200s] armbuild01 failed "build osmo-trx_1.4.0.2.1a19.202206190026.dsc" at Sun Jun 19 02:42:45 UTC 2022. [ 200s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in osmo-msc[master]: After RX of an SMPP Submit, send the SMS we just received.
by keith 18 Jun '22

18 Jun '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28342 to look at the new patch set (#2). Change subject: After RX of an SMPP Submit, send the SMS we just received. ...................................................................... After RX of an SMPP Submit, send the SMS we just received. Previously, after we have stored the new SMS in the db, we then signalled the queue to run, but this is not good enough. The queue may not pick up this new SMS on the next run, if there are sufficient older messages in the queue. So let's specifically send the message that was just submitted. Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c --- M include/osmocom/msc/signal.h M src/libmsc/gsm_04_11.c M src/libmsc/smpp_openbsc.c M src/libmsc/sms_queue.c 4 files changed, 43 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/42/28342/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c Gerrit-Change-Number: 28342 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-msc[master]: Add VTY command for SMS queue trigger holdoff
by keith 18 Jun '22

18 Jun '22

Attention is currently required from: keith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28345 to look at the new patch set (#3). Change subject: Add VTY command for SMS queue trigger holdoff ...................................................................... Add VTY command for SMS queue trigger holdoff There are various places in the code that retrigger the SMS -> In Memory pending queue mechanism. The default was to trigger the queue in one second, which could result in running the queue every second. This parameter can ease the queue run interval in case one second is causing too much load. Sms _SHOULD_ be delivered anyway without these queue runs, due to for example, MS becoming available or due to being notified by the call back of a new SMS. Change-Id: I43d88342436d654afd6d955e304e7f85fbc4840f --- M include/osmocom/msc/sms_queue.h M src/libmsc/sms_queue.c M src/libmsc/smsc_vty.c M tests/test_nodes.vty 4 files changed, 30 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/28345/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I43d88342436d654afd6d955e304e7f85fbc4840f Gerrit-Change-Number: 28345 Gerrit-PatchSet: 3 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newpatchset

1 0

Change in osmo-upf[master]: add osmo-upf
by neels 18 Jun '22

18 Jun '22

Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/28308 to look at the new patch set (#3). Change subject: add osmo-upf ...................................................................... add osmo-upf Related: SYS#5599 Change-Id: I745bcbde6859004c41ddbfd2558036bf9a2d1de2 --- A doc/examples/osmo-upf/osmo-upf-create-dev.cfg M doc/examples/osmo-upf/osmo-upf.cfg M include/osmocom/upf/Makefile.am A include/osmocom/upf/up_endpoint.h A include/osmocom/upf/up_gtp_action.h A include/osmocom/upf/up_peer.h A include/osmocom/upf/up_session.h A include/osmocom/upf/up_session_to_gtp.c M include/osmocom/upf/upf.h A include/osmocom/upf/upf_gtp.h A include/osmocom/upf/upf_nft.h M src/osmo-upf/Makefile.am M src/osmo-upf/osmo_upf_main.c A src/osmo-upf/up_endpoint.c A src/osmo-upf/up_gtp_action.c A src/osmo-upf/up_peer.c A src/osmo-upf/up_peer_fsm.c A src/osmo-upf/up_session.c M src/osmo-upf/upf.c A src/osmo-upf/upf_gtp.c A src/osmo-upf/upf_vty.c M tests/upf.vty 22 files changed, 4,053 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/08/28308/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I745bcbde6859004c41ddbfd2558036bf9a2d1de2 Gerrit-Change-Number: 28308 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-upf[master]: add netfilter deps: libnftnl, libnftables
by neels 18 Jun '22

18 Jun '22

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/28387 to look at the new patch set (#2). Change subject: add netfilter deps: libnftnl, libnftables ...................................................................... add netfilter deps: libnftnl, libnftables Will be used by subsequent patch to implement GTP tunnel mapping via netfilter. Related: SYS#5599 Change-Id: Ia8be861fe1303e82e57fe83a50cfa4ff0280db02 --- M configure.ac M contrib/jenkins.sh M src/osmo-upf/Makefile.am 3 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/87/28387/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ia8be861fe1303e82e57fe83a50cfa4ff0280db02 Gerrit-Change-Number: 28387 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log