- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: lchan_select: allow different alloc order for assignment and handover
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28327 ) Change subject: lchan_select: allow different alloc order for assignment and handover ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28327/comment/49642fe8_60ccf49c PS1, Line 541: DEFUN_ATTR(cfg_bts_challoc_mode_all, iiuc this should be marked as DEPRECATED in favor of "mode set-all" File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28327/comment/caa02afd_45e33dd8 PS1, Line 254: chan_alloc_reverse = bts->chan_alloc_chan_req_reverse; you could put these in an array chan_alloc_mode[] since you already have an enum. Not important though. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3ae73b36ee9433cc768376b56f0765e5f416162f Gerrit-Change-Number: 28327 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jun 2022 09:39:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: lchan_select: prepare a list of timeslots once, iterate over it
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28326 ) Change subject: lchan_select: prepare a list of timeslots once, iterate over it ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not really liking this new approach/path, looks like unnecessarily dropping performance here generating a full array each time, then iterating it. I think this can be probably still be done without having to generate a full list of TS every time a new lchan needs to be selected. Let's merge if everyone else is happy with this, just sharing my thoughts here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7ccc56856bfd40fd7c63b7437736de60c2b516ff Gerrit-Change-Number: 28326 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jun 2022 09:28:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: bts_chan_load(): also calculate per-TRX channel load
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28325 ) Change subject: bts_chan_load(): also calculate per-TRX channel load ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/chan_alloc.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28325/comment/33aeb96b_80de2535 PS1, Line 47: struct load_counter *ll = &trx->lchan_load; I wonder what ll means here. https://gerrit.osmocom.org/c/osmo-bsc/+/28325/comment/47af5698_b0b46c82 PS1, Line 85: ll->total++; You can simply do: ll->total += pl->total; ll->used += pl->used; after the loop, instead of doing +1 N times. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I220145238c23135f7e68ca2d474764312ffb66c5 Gerrit-Change-Number: 28325 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jun 2022 09:13:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: VTY: cosmetic: define and use CHAN_ALLOC_{CMD,DESC}
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28324 ) Change subject: VTY: cosmetic: define and use CHAN_ALLOC_{CMD,DESC} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8e906a9c16247788eec8cd8d99f019b08dc5a8f1 Gerrit-Change-Number: 28324 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jun 2022 09:10:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: Try to send all pending SMS for subscriber in sub_ready_for_sms()
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28343 ) Change subject: Try to send all pending SMS for subscriber in sub_ready_for_sms() ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/28343/comment/98af8ea0_2fb14a90 PS2, Line 7: Try to send all pending SMS for subscriber in sub_ready_for_sms() Please explain why this was not applied before, why is this needed and what is the change of behavior with this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5a1360a7a18312836b96b6be761a53b7d0b17d02 Gerrit-Change-Number: 28343 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 20 Jun 2022 09:07:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: Avoid UPDATE immediately followed by DELETE
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340 ) Change subject: Avoid UPDATE immediately followed by DELETE ...................................................................... Patch Set 1: (5 comments) File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/5d3c17ad_215e7893 PS1, Line 314: [DB_STMT_SMS_DEL_SENT_BY_ID] = what's the point in having the 2 of them? File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/f72118ab_2728313a PS1, Line 871: /* msc_vlr tests will not pass any sms_queue, hence need to check smq != NULL */ Rather better fix the tests to pass a valid smq pointer. https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/aa4a01d4_460e3574 PS1, Line 873: db_sms_mark_delivered(sms); Sounds like all this should be placed wherever S_SMS_DELIVERED signal is handled imho. File src/libmsc/sms_queue.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/64058604_497df46f PS1, Line 123: struct gsm_sms_queue { If you move the code block to be handled in signal callback, this probably can stay here. https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/09c1478b_1a1ee10e PS1, Line 607: /* Remember the subscriber and clear the pending entry */ The cod eblock should be mover over here? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 20 Jun 2022 09:05:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: Use unix timestamps in the SMS db
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28339 ) Change subject: Use unix timestamps in the SMS db ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: You are probably breaking backward compatibility with older existing databases here? This may need a new db version and code to migrate to it? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I599a57666da22adf806b01ff095c8672d523a737 Gerrit-Change-Number: 28339 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 20 Jun 2022 08:59:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: Turn off secure_delete in sqlite
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28341 ) Change subject: Turn off secure_delete in sqlite ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 20 Jun 2022 08:57:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-pfcp[master]: separate pfcp_queue_timer_cb() in req and resp
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337 ) Change subject: separate pfcp_queue_timer_cb() in req and resp ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libosmo-pfcp/pfcp_endpoint.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337/comment/97bfe9b0_d58c08a9 PS1, Line 285: } else { You'll probably want to name the 2 timers differently (put them in a union), since anyway you'll want to have different timer configurations for each of the two. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ic8ab71f5efd4cf669689a0b075f9a52ce66bdd5d Gerrit-Change-Number: 28337 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jun 2022 08:57:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_chan_alloc_algo_ass_dynamic
by pespin 20 Jun '22

20 Jun '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28322 ) Change subject: BSC_Tests: add TC_chan_alloc_algo_ass_dynamic ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia522f37c1c001b3a36f5145b8875fbb88311c2e5 Gerrit-Change-Number: 28322 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jun 2022 08:54:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log