Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28386 )
Change subject: cgit: Fix Atom feed scheme from http to https
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28386
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I4000f32ee8e7c55a711f928a19379b3a80a8446f
Gerrit-Change-Number: 28386
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 20 Jun 2022 08:50:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28385 )
Change subject: cgit: fix Atom feed hostname from localhost to cgit.osmocom.org
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28385
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Iaab14e254acc0356f0d3639924e3b6b528d57973
Gerrit-Change-Number: 28385
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 20 Jun 2022 08:49:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28309 )
Change subject: implement GTP tunnel mapping via netfilter
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Testing around with the gerrit verification job for osmo-upf, I found out: […]
i was able to login on the build slave via ssh and fixed the workspace.
Only adding '--cap-add NET_ADMIN' is not sufficient,
I also have to run as root in the docker container.
An alternative would be to install /sbin/setcap in the docker image
and add cap_net_admin to the osmo-upf binary. But then we face the dilemma
that the user 'build' is not allowed to setcap.
All of these problems with adding system crucial permissions to a gerrit job
makes me consider other ways out:
- do not run the vty tests in the gerrit job: no. The vty tests must be run.
- add a cmdline option that switches off / mocks the kernel features solely for the purpose of running the VTY tests.
OTOH, we will likely face the exact same problems in ttcn3 tests.
We could switch off GTP kernel features there, too, but then we cannot verify that GTP handling is working as expected using actual GTP. At the moment the ttcn3-hacks/upf/ tests do not test actual GTP, but we most likely want to add that in the near future.
Yet again it may not be desirable to actually employ the GTP kernel features (GTP module and nftables) on our build jobs, because i'm not sure that these features are actually being contained properly by docker. We would likely enable GTP capsulation and forwarding on the *host* system instead of inside the testing container ... ?
I'd appreciate knowledge, opinions and input on this, if anyone has any.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d319eb4f98cd51a5999c804c4203ab0bdda650
Gerrit-Change-Number: 28309
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 19 Jun 2022 15:44:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/28388
to look at the new patch set (#7).
Change subject: NOT FOR MERGE: testing gerrit job, vty tests
......................................................................
NOT FOR MERGE: testing gerrit job, vty tests
Change-Id: Ie3e38cedf0fe49330ede1fb9882a322a64d603a9
---
M contrib/jenkins.sh
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/88/28388/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28388
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ie3e38cedf0fe49330ede1fb9882a322a64d603a9
Gerrit-Change-Number: 28388
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28309 )
Change subject: implement GTP tunnel mapping via netfilter
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Testing around with the gerrit verification job for osmo-upf, I found out:
The job succeeded with these modifications to the 'docker run' cmdline
in gerrit-verifications.yml:
- remove '-u build' = run as root in the docker container
- add '--cap-add NET_ADMIN'
I am sure that the cap-add is necessary,
I am not sure whether running as root in the docker container is necessary.
currently i am having trouble bringing the gerrit-osmo-upf job back to running as user 'build',
because apparently the root-ness inside the docker container has leaked into the jenkins workspace,
leaving files owned by root that the jenkins user is not permitted to wipe out. Trying to fix...
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d319eb4f98cd51a5999c804c4203ab0bdda650
Gerrit-Change-Number: 28309
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 19 Jun 2022 15:15:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment