- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: coverity/prepare_source: clean existing git dirs
by fixeria 30 Jun '22

30 Jun '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28491 ) Change subject: coverity/prepare_source: clean existing git dirs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca Gerrit-Change-Number: 28491 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 10:41:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/prepare_source: fix running twice
by fixeria 30 Jun '22

30 Jun '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28490 ) Change subject: coverity/prepare_source: fix running twice ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I17bd76a5ff6abafd4bd0189073930f45de20afe8 Gerrit-Change-Number: 28490 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 10:39:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/build_Osmocom.sh: don't do check for all
by fixeria 30 Jun '22

30 Jun '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28489 ) Change subject: coverity/build_Osmocom.sh: don't do check for all ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6b9eb8e73c51d925897579fb51bc0a1e86e77270 Gerrit-Change-Number: 28489 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 10:39:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/prepare_source_Osmocom.sh: fix typo
by fixeria 30 Jun '22

30 Jun '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28488 ) Change subject: coverity/prepare_source_Osmocom.sh: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib5a8f35eb9ef3bb8488b29ed9a9b7f43e6b6f088 Gerrit-Change-Number: 28488 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 10:35:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/prepare_source: clean existing git dirs
by osmith 30 Jun '22

30 Jun '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28491 ) Change subject: coverity/prepare_source: clean existing git dirs ...................................................................... coverity/prepare_source: clean existing git dirs Clean git dirs if they exist already instead of fetching and reset to master. It is faster and more useful during development. Jenkins doesn't run this code path, it deletes all source directories before running this script. Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca --- M coverity/prepare_source_Osmocom.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/28491/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 09608eb..d017989 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -38,7 +38,7 @@ ; do if [ -d $proj ]; then - (cd $proj && git fetch && git checkout -f -B master origin/master) + git -C "$proj" clean -ffxd else git clone git://git.osmocom.org/$proj fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca Gerrit-Change-Number: 28491 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: coverity/local_test.sh: new file
by osmith 30 Jun '22

30 Jun '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28492 ) Change subject: coverity/local_test.sh: new file ...................................................................... coverity/local_test.sh: new file Add the script I've used to locally reproduce the build failure and fix it. Change-Id: I12241499a0669559bc40eb3e76f967a7c6a2dc70 --- M coverity/jenkins.sh A coverity/local_test.sh 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/28492/1 diff --git a/coverity/jenkins.sh b/coverity/jenkins.sh index 0ae7fd7..b02b82e 100755 --- a/coverity/jenkins.sh +++ b/coverity/jenkins.sh @@ -1,4 +1,5 @@ #!/usr/bin/env bash +# Use 'local_test.sh' during development set -e -x diff --git a/coverity/local_test.sh b/coverity/local_test.sh new file mode 100755 index 0000000..10b4583 --- /dev/null +++ b/coverity/local_test.sh @@ -0,0 +1,11 @@ +#!/bin/sh -ex +# Use this script for local testing of the prepare source and build scripts +SCRIPT_DIR="$(dirname "$(realpath "$0")")" + +mkdir -p /tmp/coverity +cp "$SCRIPT_DIR"/* /tmp/coverity + +cd /tmp/coverity + +./prepare_source_Osmocom.sh +./build_Osmocom.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I12241499a0669559bc40eb3e76f967a7c6a2dc70 Gerrit-Change-Number: 28492 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: coverity/prepare_source_Osmocom.sh: fix typo
by osmith 30 Jun '22

30 Jun '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28488 ) Change subject: coverity/prepare_source_Osmocom.sh: fix typo ...................................................................... coverity/prepare_source_Osmocom.sh: fix typo Osm_c_ocom -> Osmocom Change-Id: Ib5a8f35eb9ef3bb8488b29ed9a9b7f43e6b6f088 --- M coverity/jenkins.sh R coverity/prepare_source_Osmocom.sh 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/88/28488/1 diff --git a/coverity/jenkins.sh b/coverity/jenkins.sh index 33d4fa5..0ae7fd7 100755 --- a/coverity/jenkins.sh +++ b/coverity/jenkins.sh @@ -7,7 +7,7 @@ cov_dir="$src_dir/cov-int" rm -rf "$src_dir" -./prepare_source_Osmcocom.sh +./prepare_source_Osmocom.sh export PATH="$base_dir/cov-analysis-linux64-8.5.0/bin/:$PATH" diff --git a/coverity/prepare_source_Osmcocom.sh b/coverity/prepare_source_Osmocom.sh similarity index 100% rename from coverity/prepare_source_Osmcocom.sh rename to coverity/prepare_source_Osmocom.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib5a8f35eb9ef3bb8488b29ed9a9b7f43e6b6f088 Gerrit-Change-Number: 28488 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: coverity/build_Osmocom.sh: don't do check for all
by osmith 30 Jun '22

30 Jun '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28489 ) Change subject: coverity/build_Osmocom.sh: don't do check for all ...................................................................... coverity/build_Osmocom.sh: don't do check for all 'make check' does not pass for asn1c, it fails with the following. I looked into it and the cause is not obvious to me, so in order to make the jenkins job pass again I've changed it back to just run 'make' instead. Fix for: ... fatal: making test-suite.log: failed to create ../tests/98-attribute-class-OK.asn1.log fatal: making test-suite.log: failed to create ../tests/99-class-sample-OK.asn1.trs fatal: making test-suite.log: failed to create ../tests/99-class-sample-OK.asn1.log Makefile:735: recipe for target 'test-suite.log' failed make[3]: *** [test-suite.log] Error 1 make[3]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/asn1c/libasn1fix' Makefile:841: recipe for target 'check-TESTS' failed Disable 'make check' for libusrp too as it also didn't pass: Making check in usrp2 make[4]: Entering directory '/tmp/coverity/source-Osmocom/libusrp/firmware/src/usrp2' test -f `basename 'eeprom_boot.a51'` || ln -s 'eeprom_boot.a51' . test -f ../common/`basename 'eeprom_boot.a51'` -o \ \! -f `dirname 'eeprom_boot.a51'`/../common/`basename 'eeprom_boot.a51'` \ || ln -s `dirname 'eeprom_boot.a51'`/../common/`basename 'eeprom_boot.a51'` ../common/`basename 'eeprom_boot.a51'` sdas8051 -plosgff `basename 'eeprom_boot.a51'` sdcc -mmcs51 --no-xinit-opt -I../../../firmware/include -I../../../firmware/src/usrp2 -I../../../firmware/src/common -I../../../firmware/src/common -DHAVE_USRP2 \ -c -o eeprom_init.rel `test -f 'eeprom_init.c' || echo './'`eeprom_init.c test -f `basename '_startup.a51'` || ln -s '_startup.a51' . test -f ../common/`basename '_startup.a51'` -o \ \! -f `dirname '_startup.a51'`/../common/`basename '_startup.a51'` \ || ln -s `dirname '_startup.a51'`/../common/`basename '_startup.a51'` ../common/`basename '_startup.a51'` sdas8051 -plosgff `basename '_startup.a51'` make[4]: *** No rule to make target '../../lib/libfx2.lib', needed by 'eeprom_boot.ihx'. Stop. All other 'make check' calls do work as expected, the build script runs through again with this patch. Fixes: bf84ba9f ("coverity/build_Osmocom.sh: run 'make check' in do_build()") Change-Id: I6b9eb8e73c51d925897579fb51bc0a1e86e77270 --- M coverity/build_Osmocom.sh 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/28489/1 diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index fe9806c..ec764be 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -5,6 +5,7 @@ base_dir="$PWD" src_dir="$base_dir/source-Osmocom" prefix="$base_dir/install-Osmocom" +check="check" install -d "$prefix" @@ -18,10 +19,16 @@ --disable-doxygen \ $* - make $PARALLEL_MAKE check + make $PARALLEL_MAKE $check make install } +do_build_no_check() { + check="" + do_build "$@" + check="check" +} + build_default() { pushd $1 shift @@ -29,6 +36,13 @@ popd } +build_no_check() { + pushd $1 + shift + do_build_no_check $* + popd +} + build_layer1api() { pushd layer1-api install -d "$prefix/include/sysmocom/femtobts/" @@ -69,10 +83,10 @@ rm -rf "$prefix" build_layer1api -build_default asn1c +build_no_check asn1c build_default libosmocore build_libasn1c -build_libusrp +build_no_check libusrp build_default libosmo-abis build_default libosmo-netif build_default libosmo-sccp -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6b9eb8e73c51d925897579fb51bc0a1e86e77270 Gerrit-Change-Number: 28489 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: coverity/prepare_source: fix running twice
by osmith 30 Jun '22

30 Jun '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28490 ) Change subject: coverity/prepare_source: fix running twice ...................................................................... coverity/prepare_source: fix running twice Don't attempt to clone layer1-api if it exists already. Jenkins deletes the sources for every run, but for development it is useful to be able to run this script multiple times without getting errors. Change-Id: I17bd76a5ff6abafd4bd0189073930f45de20afe8 --- M coverity/prepare_source_Osmocom.sh 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/28490/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index ab8b2bd..09608eb 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -44,4 +44,6 @@ fi done -git clone https://git.sysmocom.de/sysmo-bts/layer1-api +if ! [ -d layer1-api ]; then + git clone https://git.sysmocom.de/sysmo-bts/layer1-api +fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I17bd76a5ff6abafd4bd0189073930f45de20afe8 Gerrit-Change-Number: 28490 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' aft...
by pespin 30 Jun '22

30 Jun '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28487 to look at the new patch set (#2). Change subject: jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' after new project releases ...................................................................... jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' after new project releases These two projects have been released recently as part of Osmocom CNI 202206. Let's enable testing them since version in latest is good enough for testing. Change-Id: I1587e8400eff2d8b1ec26ab2fff1fbfa772fe8f8 --- M jobs/ttcn3-testsuites.yml 1 file changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/87/28487/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1587e8400eff2d8b1ec26ab2fff1fbfa772fe8f8 Gerrit-Change-Number: 28487 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log