Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28489 )
Change subject: coverity/build_Osmocom.sh: don't do check for all
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28489
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I6b9eb8e73c51d925897579fb51bc0a1e86e77270
Gerrit-Change-Number: 28489
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jun 2022 12:45:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28486 )
Change subject: tlv_parser: initialize output values
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
I don't think that's the problem coverity is notifying, since it tracks conditional paths based on return values.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28486
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I87570ece10fbf64f3a57b34d84f8c843871f0db1
Gerrit-Change-Number: 28486
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jun 2022 12:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28489 )
Change subject: coverity/build_Osmocom.sh: don't do check for all
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28489
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I6b9eb8e73c51d925897579fb51bc0a1e86e77270
Gerrit-Change-Number: 28489
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jun 2022 10:39:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28491 )
Change subject: coverity/prepare_source: clean existing git dirs
......................................................................
coverity/prepare_source: clean existing git dirs
Clean git dirs if they exist already instead of fetching and reset to
master. It is faster and more useful during development. Jenkins doesn't
run this code path, it deletes all source directories before running
this script.
Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca
---
M coverity/prepare_source_Osmocom.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/28491/1
diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh
index 09608eb..d017989 100755
--- a/coverity/prepare_source_Osmocom.sh
+++ b/coverity/prepare_source_Osmocom.sh
@@ -38,7 +38,7 @@
; do
if [ -d $proj ]; then
- (cd $proj && git fetch && git checkout -f -B master origin/master)
+ git -C "$proj" clean -ffxd
else
git clone git://git.osmocom.org/$proj
fi
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28491
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca
Gerrit-Change-Number: 28491
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange