- gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: MGCP_Test: add testcase TC_e1_dlcx_wildcarded
by dexter 30 Jun '22

30 Jun '22

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495 ) Change subject: MGCP_Test: add testcase TC_e1_dlcx_wildcarded ...................................................................... MGCP_Test: add testcase TC_e1_dlcx_wildcarded We are currently testing the behaviour of wildcarded DLCX on the virtual trunk. Lets run a similar test on the E1 trunk as well. Change-Id: Icaa3815f40f8d94778d75a33c6b2a9e979256c51 Related OS#5572 Change-Id: I6cfbd24982d1e72206f8237b2eaea52cdaebf9dc --- M mgw/MGCP_Test.ttcn 1 file changed, 64 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/28495/1 diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 0242db9..6d23c10 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -2404,6 +2404,69 @@ setverdict(pass); } + /* test valid wildcarded DLCX on an E1 trunk */ + testcase TC_e1_dlcx_wildcarded() runs on dummy_CT { + var template MgcpCommand cmd; + var MgcpEndpoint ep; + var MgcpCallId call_id := '8376F297'H; + var integer n_e1_ts := 4; + var StatsDExpects expect; + + f_init(); + + /* Open a few E1 timeslots */ + for (var integer i := 0; i < n_e1_ts; i := i+1) { + ep := "ds/e1-1/s-" & int2str(i+1) & "/su16-0@" & c_mgw_domain; + cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id); + mgcp_transceive_mgw(cmd, tr_CRCX_ACK); + ep := "ds/e1-1/s-" & int2str(i+1) & "/su16-2@" & c_mgw_domain; + cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id); + mgcp_transceive_mgw(cmd, tr_CRCX_ACK); + ep := "ds/e1-1/s-" & int2str(i+1) & "/su16-4@" & c_mgw_domain; + cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id); + mgcp_transceive_mgw(cmd, tr_CRCX_ACK); + ep := "ds/e1-1/s-" & int2str(i+1) & "/su16-6@" & c_mgw_domain; + cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id); + mgcp_transceive_mgw(cmd, tr_CRCX_ACK); + } + + /* Wait until the stats items have seteled and then check if we get the expected number (all) of + * occupied endpoints */ + f_sleep(1.0) + expect := { + { name := "TTCN3.trunk.e1-1.common.endpoints.used", mtype := "g", min := n_e1_ts * 4, max := n_e1_ts * 4} + }; + f_statsd_expect(expect); + + /* Send wildcarded DLCX */ + var template MgcpResponse rtmpl := { + line := { + code := "200", + string := ? + }, + params:= { }, + sdp := omit + }; + ep := "ds/e1-1/*@" & c_mgw_domain; + cmd := ts_DLCX(get_next_trans_id(), ep); + mgcp_transceive_mgw(cmd, rtmpl); + + /* Query a the statsd once to ensure that intermediate results are pulled from the + * pipeline. The second query (below) will return the actual result. */ + expect := { + { name := "TTCN3.trunk.e1-1.common.endpoints.used", mtype := "g", min := 0, max := n_e1_ts * 4} + }; + f_statsd_expect(expect); + + /* The second query must resturn a result with 0 endpoints in use. */ + expect := { + { name := "TTCN3.trunk.e1-1.common.endpoints.used", mtype := "g", min := 0, max := 0} + }; + f_statsd_expect(expect); + + setverdict(pass); + } + /* test valid CRCX then MDCX with IPv4 address, MGW provides a local IPv4 too */ testcase TC_crcx_mdcx_ip4() runs on dummy_CT { var MgcpEndpoint ep := c_mgw_ep_rtpbridge & "2@" & c_mgw_domain; @@ -2803,6 +2866,7 @@ execute(TC_e1_crcx_and_dlcx_ep()); execute(TC_e1_crcx_with_overlap()); execute(TC_e1_crcx_loopback()); + execute(TC_e1_dlcx_wildcarded()); execute(TC_crcx_mdcx_ip4()); execute(TC_crcx_mdcx_ip6()); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cfbd24982d1e72206f8237b2eaea52cdaebf9dc Gerrit-Change-Number: 28495 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: lchan_select: implement dynamic selection mode for assignment
by osmith 30 Jun '22

30 Jun '22

Attention is currently required from: laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28328 ) Change subject: lchan_select: implement dynamic selection mode for assignment ...................................................................... Patch Set 5: (3 comments) File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/916edc0c_874940a3 PS5, Line 2010: if (lchan_avail_by_type(rqd->bts, GSM_LCHAN_TCH_F, SELECT_FOR_MS_CHAN_REQ, NULL, true)) { why pass NULL as ctx, isn't there any other talloc context available to hang this on that makes more sense? (same below a lot of times) File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/382e7745_128d00e4 PS2, Line 231: qsort(&trx_list[0], bts->num_trx, sizeof(trx), &qsort_func); > I can find arguments in favor of both ways, I don't see a clear advantage of either over the other. […] I guess it could be refactored to pass qsort_func to populate_ts_list, instead of passing sort_by_trx_power. But I don't have a strong opinion here, I'd be fine with merging this part as-is. File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/8a3ed6c5_ed1a8d27 PS5, Line 271: } while (0) why add this instead of using a separate log category where one could enable/disable logging with the usual vty commands? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b7a0d706976b73cc5c30a8714b830811addfe8d Gerrit-Change-Number: 28328 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 14:39:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-cbc[master]: Configure libosmocore logging system as multithread
by pespin 30 Jun '22

30 Jun '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28493 ) Change subject: Configure libosmocore logging system as multithread ...................................................................... Configure libosmocore logging system as multithread OsmoCBC uses libulfius, which creates its own thread(s). Hence, we must set up osmocom logging system appropiately so that relevant stuff is protected by locks. Related: OS#5598 Change-Id: Ic06edc19d22b90e2b6b7de3a25d62cda5001f46e --- M src/cbc_main.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/93/28493/1 diff --git a/src/cbc_main.c b/src/cbc_main.c index 140d047..4b64c91 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -212,6 +212,7 @@ tall_rest_ctx = talloc_named_const(tall_cbc_ctx, 0, "REST"); msgb_talloc_ctx_init(tall_cbc_ctx, 0); osmo_init_logging2(tall_cbc_ctx, &log_info); + log_enable_multithread(); osmo_stats_init(tall_cbc_ctx); vty_init(&vty_info); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ic06edc19d22b90e2b6b7de3a25d62cda5001f46e Gerrit-Change-Number: 28493 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: lchan_select: allow different alloc order for assignment and handover
by osmith 30 Jun '22

30 Jun '22

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28327 ) Change subject: lchan_select: allow different alloc order for assignment and handover ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28327/comment/23e3a416_fb8cdfea PS2, Line 4246: vty_out(vty, " channel allocator mode chan-req %s%s", possibly output one set-all line instead if it is the same for all three? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3ae73b36ee9433cc768376b56f0765e5f416162f Gerrit-Change-Number: 28327 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 14:02:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/local_test.sh: new file
by pespin 30 Jun '22

30 Jun '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28492 ) Change subject: coverity/local_test.sh: new file ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I12241499a0669559bc40eb3e76f967a7c6a2dc70 Gerrit-Change-Number: 28492 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 13:57:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/prepare_source: add SRC_SKIP_FETCH/CLEAN
by pespin 30 Jun '22

30 Jun '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28491 ) Change subject: coverity/prepare_source: add SRC_SKIP_FETCH/CLEAN ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca Gerrit-Change-Number: 28491 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 13:57:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/prepare_source: add SRC_SKIP_FETCH/CLEAN
by osmith 30 Jun '22

30 Jun '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28491 ) Change subject: coverity/prepare_source: add SRC_SKIP_FETCH/CLEAN ...................................................................... Patch Set 1: (1 comment) File coverity/prepare_source_Osmocom.sh: https://gerrit.osmocom.org/c/osmo-ci/+/28491/comment/650a3323_e56d6021 PS1, Line 41: git -C "$proj" clean -ffxd > I don't really like the idea of doing 2 different things based on some external "use case". […] Okay I see your point, changed it to only behave differently if environment variables are set, and set them in the local test script. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca Gerrit-Change-Number: 28491 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 13:33:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/local_test.sh: new file
by osmith 30 Jun '22

30 Jun '22

Attention is currently required from: osmith. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28492 to look at the new patch set (#2). Change subject: coverity/local_test.sh: new file ...................................................................... coverity/local_test.sh: new file Add the script I've used to locally reproduce the build failure and fix it. Change-Id: I12241499a0669559bc40eb3e76f967a7c6a2dc70 --- M coverity/jenkins.sh A coverity/local_test.sh 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/28492/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I12241499a0669559bc40eb3e76f967a7c6a2dc70 Gerrit-Change-Number: 28492 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: coverity/prepare_source: add SRC_SKIP_FETCH/CLEAN
by osmith 30 Jun '22

30 Jun '22

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28491 to look at the new patch set (#2). Change subject: coverity/prepare_source: add SRC_SKIP_FETCH/CLEAN ...................................................................... coverity/prepare_source: add SRC_SKIP_FETCH/CLEAN When running these scripts locally while developing, it's more useful to not fetch the sources and clean the git repository instead. Add environment variables that allow doing this. Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca --- M coverity/prepare_source_Osmocom.sh 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/28491/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca Gerrit-Change-Number: 28491 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: coverity/prepare_source: clean existing git dirs
by pespin 30 Jun '22

30 Jun '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28491 ) Change subject: coverity/prepare_source: clean existing git dirs ...................................................................... Patch Set 1: (1 comment) File coverity/prepare_source_Osmocom.sh: https://gerrit.osmocom.org/c/osmo-ci/+/28491/comment/01ca120c_bcc2337e PS1, Line 41: git -C "$proj" clean -ffxd > I think there are two use cases: […] I don't really like the idea of doing 2 different things based on some external "use case". If you want fast iterations at a specific time, then better disable it manually for the time you do it. I don't think it makes sense to have one path updating the content while the other doesn't, this will end up in strange behaviors which are difficult to follow. If other people disagree with me, then go on, +2 and merge. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca Gerrit-Change-Number: 28491 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 12:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log