- gerrit-log - lists.osmocom.org

Change in pysim[master]: add missing bit definition for NG-RAN in xAcT

by Bjoern Riemer

Bjoern Riemer has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26956 ) Change subject: add missing bit definition for NG-RAN in xAcT ...................................................................... add missing bit definition for NG-RAN in xAcT when encoding the AcT value bit 11 is correctly set when NG-RAN is present in the string representation, however the decoding of bit 11 was missing. Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 --- M pySim/utils.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/56/26956/1 diff --git a/pySim/utils.py b/pySim/utils.py index e30c970..1806d0d 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -464,6 +464,7 @@ act_list = [ {'bit': 15, 'name': "UTRAN"}, {'bit': 14, 'name': "E-UTRAN"}, + {'bit': 11, 'name': "NG-RAN"}, {'bit': 7, 'name': "GSM"}, {'bit': 6, 'name': "GSM COMPACT"}, {'bit': 5, 'name': "cdma2000 HRPD"}, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 Gerrit-Change-Number: 26956 Gerrit-PatchSet: 1 Gerrit-Owner: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-MessageType: newchange

3 years, 6 months

1
0
0 0

Change in pysim[master]: update testdata with the new NG-RAN AcT values

by Bjoern Riemer

Bjoern Riemer has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26957 ) Change subject: update testdata with the new NG-RAN AcT values ...................................................................... update testdata with the new NG-RAN AcT values Change-Id: I881eadc7ae4b2c4aaaa0a37898f32be9e127f11a --- M pysim-testdata/Fairwaves-SIM.ok M pysim-testdata/Wavemobile-SIM.ok M pysim-testdata/sysmoISIM-SJA2.ok M pysim-testdata/sysmoUSIM-SJS1.ok 4 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/57/26957/1 diff --git a/pysim-testdata/Fairwaves-SIM.ok b/pysim-testdata/Fairwaves-SIM.ok index 2a912e2..f07c033 100644 --- a/pysim-testdata/Fairwaves-SIM.ok +++ b/pysim-testdata/Fairwaves-SIM.ok @@ -31,7 +31,7 @@ ffffff0000 # unused HPLMNAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused diff --git a/pysim-testdata/Wavemobile-SIM.ok b/pysim-testdata/Wavemobile-SIM.ok index 0eb8cc8..d8f1a6f 100644 --- a/pysim-testdata/Wavemobile-SIM.ok +++ b/pysim-testdata/Wavemobile-SIM.ok @@ -11,7 +11,7 @@ Hide in OPLMN: False PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff PLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -29,7 +29,7 @@ ffffff0000 # unused OPLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/pysim-testdata/sysmoISIM-SJA2.ok index 87cb857..a8c98d9 100644 --- a/pysim-testdata/sysmoISIM-SJA2.ok +++ b/pysim-testdata/sysmoISIM-SJA2.ok @@ -11,7 +11,7 @@ Hide in OPLMN: True PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff PLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -25,7 +25,7 @@ ffffff0000 # unused OPLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -39,7 +39,7 @@ ffffff0000 # unused HPLMNAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused diff --git a/pysim-testdata/sysmoUSIM-SJS1.ok b/pysim-testdata/sysmoUSIM-SJS1.ok index e65f276..14d7110 100644 --- a/pysim-testdata/sysmoUSIM-SJS1.ok +++ b/pysim-testdata/sysmoUSIM-SJS1.ok @@ -11,7 +11,7 @@ Hide in OPLMN: True PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff PLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -25,7 +25,7 @@ ffffff0000 # unused OPLMNwAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused @@ -39,7 +39,7 @@ ffffff0000 # unused HPLMNAcT: - 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT + 00f110ffff # MCC: 001 MNC: 01 AcT: UTRAN, E-UTRAN WB-S1, E-UTRAN NB-S1, NG-RAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT ffffff0000 # unused ffffff0000 # unused ffffff0000 # unused -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I881eadc7ae4b2c4aaaa0a37898f32be9e127f11a Gerrit-Change-Number: 26957 Gerrit-PatchSet: 1 Gerrit-Owner: Bjoern Riemer <bjoern.c3(a)nixda.biz> Gerrit-MessageType: newchange

3 years, 6 months

1
0
0 0

Change in dahdi-linux[master]: How did this ever work... stdbool.h is not in the kernel.

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26951 ) Change subject: How did this ever work... stdbool.h is not in the kernel. ...................................................................... How did this ever work... stdbool.h is not in the kernel. Change-Id: I36438e35bb99325e1ac86b68c1746670a9851e4a --- M drivers/dahdi/dahdi-base.c M drivers/dahdi/voicebus/vpmoct.h M drivers/dahdi/wcaxx-base.c M drivers/dahdi/wct4xxp/base.c M drivers/dahdi/wct4xxp/vpm450m.c M drivers/dahdi/wctc4xxp/base.c M drivers/dahdi/wctdm24xxp/base.c M drivers/dahdi/wcte12xp/base.c M drivers/dahdi/wcte13xp-base.c M drivers/dahdi/wcte43x-base.c M drivers/dahdi/wcxb.c M drivers/dahdi/wcxb_spi.h 12 files changed, 0 insertions(+), 12 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index cde56c1..96e4afd 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -86,7 +86,6 @@ #include "hpec/hpec_user.h" -#include <stdbool.h> #if defined(EMPULSE) && defined(EMFLASH) #error "You cannot define both EMPULSE and EMFLASH" diff --git a/drivers/dahdi/voicebus/vpmoct.h b/drivers/dahdi/voicebus/vpmoct.h index cb55826..5c90946 100644 --- a/drivers/dahdi/voicebus/vpmoct.h +++ b/drivers/dahdi/voicebus/vpmoct.h @@ -30,7 +30,6 @@ #include <linux/timer.h> #include "dahdi/kernel.h" -#include <stdbool.h> #define VPMOCT_FIRM_HEADER_LEN 32 #define VPMOCT_BOOT_RAM_LEN 128 diff --git a/drivers/dahdi/wcaxx-base.c b/drivers/dahdi/wcaxx-base.c index b934960..8467767 100644 --- a/drivers/dahdi/wcaxx-base.c +++ b/drivers/dahdi/wcaxx-base.c @@ -34,7 +34,6 @@ #include <linux/firmware.h> #include <linux/crc32.h> -#include <stdbool.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30) diff --git a/drivers/dahdi/wct4xxp/base.c b/drivers/dahdi/wct4xxp/base.c index 3412402..9d5b9a9 100644 --- a/drivers/dahdi/wct4xxp/base.c +++ b/drivers/dahdi/wct4xxp/base.c @@ -42,7 +42,6 @@ #include <linux/crc32.h> #include <linux/slab.h> -#include <stdbool.h> #include <dahdi/kernel.h> #include "wct4xxp.h" diff --git a/drivers/dahdi/wct4xxp/vpm450m.c b/drivers/dahdi/wct4xxp/vpm450m.c index 82a0463..38c68ab 100644 --- a/drivers/dahdi/wct4xxp/vpm450m.c +++ b/drivers/dahdi/wct4xxp/vpm450m.c @@ -28,7 +28,6 @@ #include <linux/version.h> #include <dahdi/kernel.h> -#include <stdbool.h> #include "vpm450m.h" #include <oct612x.h> diff --git a/drivers/dahdi/wctc4xxp/base.c b/drivers/dahdi/wctc4xxp/base.c index 3bd56d1..7ff3456 100644 --- a/drivers/dahdi/wctc4xxp/base.c +++ b/drivers/dahdi/wctc4xxp/base.c @@ -39,7 +39,6 @@ #include <linux/etherdevice.h> #include <linux/timer.h> -#include <stdbool.h> #include <dahdi/kernel.h> diff --git a/drivers/dahdi/wctdm24xxp/base.c b/drivers/dahdi/wctdm24xxp/base.c index 16bf384..6571f17 100644 --- a/drivers/dahdi/wctdm24xxp/base.c +++ b/drivers/dahdi/wctdm24xxp/base.c @@ -54,7 +54,6 @@ #include <linux/crc32.h> #include <linux/slab.h> -#include <stdbool.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30) /* Define this if you would like to load the modules in parallel. While this diff --git a/drivers/dahdi/wcte12xp/base.c b/drivers/dahdi/wcte12xp/base.c index e8a5861..c73acdd 100644 --- a/drivers/dahdi/wcte12xp/base.c +++ b/drivers/dahdi/wcte12xp/base.c @@ -43,7 +43,6 @@ #include <linux/slab.h> -#include <stdbool.h> #include <dahdi/kernel.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0) diff --git a/drivers/dahdi/wcte13xp-base.c b/drivers/dahdi/wcte13xp-base.c index b5f8043..69f7099 100644 --- a/drivers/dahdi/wcte13xp-base.c +++ b/drivers/dahdi/wcte13xp-base.c @@ -35,7 +35,6 @@ #include <linux/sched.h> #include <linux/crc32.h> -#include <stdbool.h> #include <dahdi/kernel.h> #include "wct4xxp/wct4xxp.h" /* For certain definitions */ diff --git a/drivers/dahdi/wcte43x-base.c b/drivers/dahdi/wcte43x-base.c index 45b0f6c..d164a69 100644 --- a/drivers/dahdi/wcte43x-base.c +++ b/drivers/dahdi/wcte43x-base.c @@ -43,7 +43,6 @@ #include <linux/firmware.h> #include <oct612x.h> -#include <stdbool.h> #include <dahdi/kernel.h> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0) diff --git a/drivers/dahdi/wcxb.c b/drivers/dahdi/wcxb.c index 122f9d3..3db22ee 100644 --- a/drivers/dahdi/wcxb.c +++ b/drivers/dahdi/wcxb.c @@ -36,7 +36,6 @@ #include <dahdi/kernel.h> -#include <stdbool.h> #include "wcxb.h" #include "wcxb_spi.h" diff --git a/drivers/dahdi/wcxb_spi.h b/drivers/dahdi/wcxb_spi.h index 418cd77..4575f14 100644 --- a/drivers/dahdi/wcxb_spi.h +++ b/drivers/dahdi/wcxb_spi.h @@ -24,7 +24,6 @@ #define __WCXB_SPI_H #include <linux/spi/spi.h> -#include <stdbool.h> struct wcxb_spi_transfer { const void *tx_buf; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I36438e35bb99325e1ac86b68c1746670a9851e4a Gerrit-Change-Number: 26951 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 6 months

1
0
0 0

Change in dahdi-linux[master]: How did this ever work... stdbool.h is not in the kernel.

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26951 ) Change subject: How did this ever work... stdbool.h is not in the kernel. ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26951 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I36438e35bb99325e1ac86b68c1746670a9851e4a Gerrit-Change-Number: 26951 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 20 Jan 2022 17:20:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26954 ) Change subject: PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip ...................................................................... PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip The old values are not valid anymore when running against open5gs version 2.4.2. Most likely, the default addresses got changed during the PGW split-up (now it's open5gs-smfd and open5gs-upfd). Change-Id: I3dd7d1f0d4aebb94b8859e8d12e952917de35071 Related: SYS#5602 --- M pgw/PGW_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index f026e58..c526fa2 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -19,14 +19,14 @@ modulepar { - charstring mp_pgw_hostname := "127.0.0.3"; + charstring mp_pgw_hostname := "127.0.0.4"; charstring mp_local_hostname_c := "127.0.0.1"; charstring mp_local_hostname_u := "127.0.0.1"; charstring mp_run_prog_as_user := "laforge"; charstring mp_ping_hostname := "10.45.0.1"; - charstring mp_pcrf_local_ip := "127.0.0.5"; + charstring mp_pcrf_local_ip := "127.0.0.9"; integer mp_pcrf_local_port := 3868; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3dd7d1f0d4aebb94b8859e8d12e952917de35071 Gerrit-Change-Number: 26954 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/GTPv2_Emulation: fix timer not being started in f_uecups_xcei...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26952 ) Change subject: library/GTPv2_Emulation: fix timer not being started in f_uecups_xceive() ...................................................................... library/GTPv2_Emulation: fix timer not being started in f_uecups_xceive() This change fixes the following error: Dynamic test case error: None of the branches can be chosen in the alt statement in file GTPv2_Emulation.ttcn between lines 362 and 370. which may happen when osmo-uecups-daemon fails to create a tunnel due to insufficient permissions. Change-Id: Icb229aed7fa9dedcf999837ec6ad249ab4fdebb7 Related: SYS#5602 --- M library/GTPv2_Emulation.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/GTPv2_Emulation.ttcn b/library/GTPv2_Emulation.ttcn index 8074269..f07afcb 100644 --- a/library/GTPv2_Emulation.ttcn +++ b/library/GTPv2_Emulation.ttcn @@ -359,6 +359,7 @@ var UECUPS_RecvFrom mrf; UECUPS.send(t_UECUPS_Send(g_uecups_conn_id, tx)); + T.start; alt { [] UECUPS.receive(tr_UECUPS_RecvFrom_R(rx_t)) -> value mrf { } [] UECUPS.receive(tr_SctpAssocChange) { repeat; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb229aed7fa9dedcf999837ec6ad249ab4fdebb7 Gerrit-Change-Number: 26952 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PGW_Tests: fix f_create_session(): add missing Serving Network IE

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26953 ) Change subject: PGW_Tests: fix f_create_session(): add missing Serving Network IE ...................................................................... PGW_Tests: fix f_create_session(): add missing Serving Network IE open5gs-smfd version 2.4.2 requires this IE to be present: [smf] INFO: [Added] Number of SMF-UEs is now 1 (../src/smf/context.c:820) [smf] INFO: [Added] Number of SMF-Sessions is now 1 (../src/smf/context.c:2610) [smf] ERROR: No Serving Network (../src/smf/s5c-handler.c:101) [smf] ERROR: No Data in Serving Network (../src/smf/s5c-handler.c:105) [smf] ERROR: Invalid Len[0] in Serving Network (../src/smf/s5c-handler.c:110) Change-Id: Idf6d147cc4a37996ee4ae6de18158b0e140d9db6 Related: SYS#5602 --- M library/GTPv2_Templates.ttcn M pgw/PGW_Tests.ttcn 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn index 3d69017..644728e 100644 --- a/library/GTPv2_Templates.ttcn +++ b/library/GTPv2_Templates.ttcn @@ -1035,6 +1035,25 @@ privateExtension := * }}); +/* 8.18 */ +template (value) ServingNetwork +ts_GTP2C_ServingNetwork(template (value) hexstring mcc, + template (value) hexstring mnc, + template (value) BIT4 instance := '0000'B) := +{ + elementIdentifier := '53'O, + lengthIndicator := 0, /* overwritten */ + instance := instance, + spare := '0000'B, + mccDigit1 := mcc[0], + mccDigit2 := mcc[1], + mccDigit3 := mcc[2], + mncDigit3 := mnc[2], /* 'F'H for 2 digit MNC */ + mncDigit1 := mnc[0], + mncDigit2 := mnc[1], + additionalOctets := omit +} + } diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 81e3552..f026e58 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -305,6 +305,7 @@ var template (value) TAI tai := { '0'H, '0'H, '1'H, 'F'H, '0'H, '1'H, '0001'O }; var template (value) ECGI ecgi := { '0'H, '0'H, '1'H, 'F'H, '0'H, '1'H, '0'H, 23 }; g2c.gtpcv2_pdu.createSessionRequest.userLocationInfo := ts_GTP2C_UserLocInfo(tai := tai, ecgi := ecgi); + g2c.gtpcv2_pdu.createSessionRequest.servingNetwork := ts_GTP2C_ServingNetwork('001'H, '01F'H); GTP2.send(g2c); if (DIAMETER_PROC.checkstate("Connected")) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idf6d147cc4a37996ee4ae6de18158b0e140d9db6 Gerrit-Change-Number: 26953 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26954 ) Change subject: PGW_Tests: update default values for mp_pgw_hostname/mp_pcrf_local_ip ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3dd7d1f0d4aebb94b8859e8d12e952917de35071 Gerrit-Change-Number: 26954 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 17:19:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: PGW_Tests: fix f_create_session(): add missing Serving Network IE

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26953 ) Change subject: PGW_Tests: fix f_create_session(): add missing Serving Network IE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idf6d147cc4a37996ee4ae6de18158b0e140d9db6 Gerrit-Change-Number: 26953 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 17:19:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/GTPv2_Emulation: fix timer not being started in f_uecups_xcei...

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26952 ) Change subject: library/GTPv2_Emulation: fix timer not being started in f_uecups_xceive() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb229aed7fa9dedcf999837ec6ad249ab4fdebb7 Gerrit-Change-Number: 26952 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 17:18:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log