dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28884 )
Change subject: bsc_subscr_conn_fsm: fix use after free
......................................................................
bsc_subscr_conn_fsm: fix use after free
In cases where the MGCP client endpoint FSM is terminating early the bsc
sbscr conn FSM receives the signal GSCON_EV_FORGET_MGW_ENDPOINT, which
then calls gscon_forget_mgw_endpoint(). However, this only nulls the
conn->user_plane->mgw_endpoint_ci_msc struct pointer, not the others.
This causes the assignment FSM to access
conn->assignment.created_ci_for_msc whle trying to initiate a DLCX. We
must make sure that when the MGCP client endpoint FSM dies, that all
other CI pointers that reference the same CI are also set to NULL.
Change-Id: Ia857e3af6c17282b7e8178b6d249eb0f99ed98e3
Related: OS#5572
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/28884/1
diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 9af28c7..7c0c7c3 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -940,6 +940,10 @@
mgcp_client = osmo_mgcpc_ep_client(conn->user_plane.mgw_endpoint);
mgcp_client_pool_put(mgcp_client);
+ /* Be sure that the endpoint CI we are maintaining in user_plane
+ * is also removed from the other locations as well. */
+ gscon_forget_mgw_endpoint_ci(conn, conn->user_plane.mgw_endpoint_ci_msc);
+
conn->user_plane.mgw_endpoint = NULL;
conn->user_plane.mgw_endpoint_ci_msc = NULL;
conn->ho.created_ci_for_msc = NULL;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28884
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia857e3af6c17282b7e8178b6d249eb0f99ed98e3
Gerrit-Change-Number: 28884
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28883
to look at the new patch set (#2).
Change subject: cbc: Send Write-Replace-Warn-Ind after ACKing the request
......................................................................
cbc: Send Write-Replace-Warn-Ind after ACKing the request
This way we can test how does osmo-cbc behave when receiving such
message.
Related: OS#4945
Change-Id: Ifcdcddc7dccb5439126a5fa29bb540669ed25908
---
M cbc/CBC_Tests.ttcn
M cbc/MME_ConnectionHandler.ttcn
M library/sbcap/SBC_AP_Templates.ttcn
3 files changed, 106 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/28883/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28883
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdcddc7dccb5439126a5fa29bb540669ed25908
Gerrit-Change-Number: 28883
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, pespin, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28882 )
Change subject: scripts/obs: rewrite pushing source pkgs to OBS
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> Using python for this looks a bit overkill but fine :)
thanks for reviewing! reasoning for using python is getting a readable trace when the script fails and argparse
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28882
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I45a555d05a9da808c0fe0145aae665f583cb80d9
Gerrit-Change-Number: 28882
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Aug 2022 14:33:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, laforge, fixeria.
Hello Jenkins Builder, laforge, pespin, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/28882
to look at the new patch set (#2).
Change subject: scripts/obs: rewrite pushing source pkgs to OBS
......................................................................
scripts/obs: rewrite pushing source pkgs to OBS
Harald requested that the OBS scripts should not stop if building one
specific source package fails, instead it should keep going and report
at the end a non-success exit code.
Given that the shell script code has historically grown and became hard
to maintain, I decided to rewrite the scripts for implementing this
feature. This rewrite solves additional problems:
* No full checkout of an OBS project like network:osmocom:latest
anymore, with lots of packages that won't get updated (e.g. the uhd
package has a uhd-images_3.14.1.1.tar.xz file that is 108 MB). With
the old code, developers had to wait minutes during the checkout
before the script reaches code that is currently being developed. Now
only single packages get checked out right before they get updated.
* No need to clone git repositories over and over. With the new code,
git repos only get cloned if needed (for latest it is not needed if
the remote git tag is the same as the version in OBS). During
development, the cloned git repositories are cached.
* Output from commands like "git tag -l" is not written to the log
unless they failed. This makes the log more readable, which is
especially important when a package fails to build, we keep going and
need to spot the build error in the middle of the log later on.
* No more duplicated code for nightly and latest scripts that worked
similar but had slight differences. Also the list of packages is not
duplicated for nightly and latest anymore; nightly uses all packages
and latest uses packages that have at least one git tag.
* Building source packages is decoupled from uploading them. A separate
script build_srcpkg.py can be used to just build the deb + rpm spec
source packages, without interacting with the OBS server.
* The scripts can optionally run in docker with a command-line switch,
and this is used by jenkins. This way we don't need to install
more dependencies on the host such as rebar3 which is now needed for
erlang/osmo_dia2gsup.
* Add erlang/osmo_dia2gsup and run its generate_build_dep.sh (SYS#6006)
I have done the new implementation in python to make use of argparse
and to be able to use try/except and print a trace when building one
package fails.
Example output:
* https://jenkins.osmocom.org/jenkins/job/Osmocom_OBS_nightly_obs.osmocom.org…
* https://jenkins.osmocom.org/jenkins/job/Osmocom_OBS_latest_obs.osmocom.org/…
Change-Id: I45a555d05a9da808c0fe0145aae665f583cb80d9
---
M .gitignore
M jobs/osmocom-obs.yml
D scripts/common-obs-conflict.sh
D scripts/common-obs.sh
A scripts/obs/build_srcpkg.py
A scripts/obs/data/Dockerfile
A scripts/obs/data/Release.key
A scripts/obs/data/rpmlintrc
A scripts/obs/lib/__init__.py
A scripts/obs/lib/config.py
A scripts/obs/lib/debian.py
A scripts/obs/lib/docker.py
A scripts/obs/lib/git.py
A scripts/obs/lib/metapkg.py
A scripts/obs/lib/osc.py
A scripts/obs/lib/rpm_spec.py
A scripts/obs/lib/srcpkg.py
A scripts/obs/update_obs_project.py
D scripts/osmocom-latest-packages.sh
D scripts/osmocom-next-packages.sh
D scripts/osmocom-nightly-packages.sh
21 files changed, 1,338 insertions(+), 1,016 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/82/28882/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28882
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I45a555d05a9da808c0fe0145aae665f583cb80d9
Gerrit-Change-Number: 28882
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset