- gerrit-log - lists.osmocom.org

Change in pysim[master]: add missing bit definition for NG-RAN in xAcT

by bjoern

Attention is currently required from: laforge. bjoern has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26956 ) Change subject: add missing bit definition for NG-RAN in xAcT ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > thanks, but indeed tes results need updating i tried to update the expected results in the pysim-testdata folder however this somehow went into 26957. How do i correctly update the testdata? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 Gerrit-Change-Number: 26956 Gerrit-PatchSet: 1 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:23:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 2: (1 comment) File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/8dda1680_19741fbc PS2, Line 315: * Check whether the logging framework is initialized (osmo_log_info exists) */ : int log_initialized(void) : { : if (!osmo_log_info) : return 0; : return 1; : } this is a non-inline function that does nothing else but exporting the value of an (already global, exported) variable. So rather than a simple load-and-compare, the code would call a function to then perform the load-and-compare. I would say this should at the very least be an inline function inside the header file, or since the only two users are already macros, just check for osmo_log_info directly from those macros? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:21:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: subject still says "stdout" but patch is now using "stderr" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:18:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in pysim[master]: implement shell command to update PLMN in IMSI

by bjoern

Attention is currently required from: fixeria. bjoern has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26959 ) Change subject: implement shell command to update PLMN in IMSI ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: fixed both issues in the patchset2 File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26959/comment/1323d9b3_19ce9c84 PS1, Line 485: string > There is no such type in Python, should be 'str' instead. Done https://gerrit.osmocom.org/c/pysim/+/26959/comment/0f6a7d24_45406566 PS1, Line 488: if len(plmn) == 5: > If I am not mistaken, it can also be 6 in case of 3-digit MNC. Ack -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc Gerrit-Change-Number: 26959 Gerrit-PatchSet: 2 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:17:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in pysim[master]: add missing bit definition for NG-RAN in xAcT

by laforge

Attention is currently required from: bjoern. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26956 ) Change subject: add missing bit definition for NG-RAN in xAcT ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: thanks, but indeed tes results need updating -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I910df28c4c59ec94cce9603377786325f6d8c1a3 Gerrit-Change-Number: 26956 Gerrit-PatchSet: 1 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:15:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in pysim[master]: implement shell command to update PLMN in IMSI

by bjoern

Attention is currently required from: bjoern. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/26959 to look at the new patch set (#2). Change subject: implement shell command to update PLMN in IMSI ...................................................................... implement shell command to update PLMN in IMSI Add file specific command `update_imsi_plmn` to EF_IMSI to replace the mcc and mnc part of the imsi for use in bulk_script(s) Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc --- M pySim/ts_51_011.py 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/59/26959/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9662ff074acf9dc974ae4c78edac44db286e98fc Gerrit-Change-Number: 26959 Gerrit-PatchSet: 2 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz> Gerrit-MessageType: newpatchset

3 years, 6 months

1
0
0 0

Change in pysim[master]: catch and ignore SwMatchError on probing for AID's

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26958 ) Change subject: catch and ignore SwMatchError on probing for AID's ...................................................................... catch and ignore SwMatchError on probing for AID's When probing applications on a card by running select_adf_by_aid() SwMatchError exceptions indicating the non exsistance of that application on the card should be ignored. Change-Id: I3aa7deaf46bdf352a201c3089b3714405a06f281 --- M pySim/filesystem.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index dfe1677..32688db 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1113,11 +1113,13 @@ # Some card applications may not be registered in EF.DIR, we will actively # probe for those applications for f in set(apps_profile) - set(apps_taken): - data, sw = self.card.select_adf_by_aid(f.aid) - if sw == "9000": - print(" %s: %s" % (f.name, f.aid)) - apps_taken.append(f) - + try: + data, sw = self.card.select_adf_by_aid(f.aid) + if sw == "9000": + print(" %s: %s" % (f.name, f.aid)) + apps_taken.append(f) + except SwMatchError: + pass return apps_taken def reset(self, cmd_app=None) -> Hexstr: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3aa7deaf46bdf352a201c3089b3714405a06f281 Gerrit-Change-Number: 26958 Gerrit-PatchSet: 1 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 6 months

1
0
0 0

Change in pysim[master]: catch and ignore SwMatchError on probing for AID's

by laforge

Attention is currently required from: bjoern. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26958 ) Change subject: catch and ignore SwMatchError on probing for AID's ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > ha, I just did exactly the same in https://gerrit.osmocom. […] nevermind, the ADF selectin is only done for those not listed in EF.DIR, so your patch is more correct. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3aa7deaf46bdf352a201c3089b3714405a06f281 Gerrit-Change-Number: 26958 Gerrit-PatchSet: 1 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:14:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in pysim[master]: _match_applications: catch SwMatchError e.g. if permission denied

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/26961 ) Change subject: _match_applications: catch SwMatchError e.g. if permission denied ...................................................................... Abandoned https://gerrit.osmocom.org/c/pysim/+/26958 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id03a44c84cc8939908bc15f9fe42a9955d58c643 Gerrit-Change-Number: 26961 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: abandon

3 years, 6 months

1
0
0 0

Change in pysim[master]: catch and ignore SwMatchError on probing for AID's

by laforge

Attention is currently required from: bjoern. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26958 ) Change subject: catch and ignore SwMatchError on probing for AID's ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: ha, I just did exactly the same in https://gerrit.osmocom.org/c/pysim/+/26961 with the difference that I'm printing those situations as error. I guess we should print it only as an error if the AID was listed in EF.DIR but not if it was a random probe. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3aa7deaf46bdf352a201c3089b3714405a06f281 Gerrit-Change-Number: 26958 Gerrit-PatchSet: 1 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: bjoern <bjoern.c3(a)nixda.biz> Gerrit-Comment-Date: Fri, 21 Jan 2022 11:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log