Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28886 ) Change subject: cbsp/sbcap: Set link fsm id with peer's name ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: What File src/cbsp_link.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28886/comment/4a1e752b_46908a23 PS1, Line 51: peer->name If peer->name contains an illegal character (see osmo_identifier_valid()), osmo_fsm_inst_alloc() will fail with "Attempting to set illegal id for FSM instance of type '%s': %s\n". For a better user experience we may need to enforce some naming restrictions in the VTY code. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28886 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I8a6850293cbe01c66e4fb545d646d63743ddaecb Gerrit-Change-Number: 28886 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 02 Aug 2022 09:29:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment