- gerrit-log - lists.osmocom.org

Change in simtrace2[master]: contrib/simtrace.lua: Add header with author/description/usage

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26978 ) Change subject: contrib/simtrace.lua: Add header with author/description/usage ...................................................................... contrib/simtrace.lua: Add header with author/description/usage Change-Id: I56574741cd77436f9f452420677c00d8049a50cc --- M contrib/simtrace.lua 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/78/26978/1 diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua index 09ee9e6..d05ff0a 100644 --- a/contrib/simtrace.lua +++ b/contrib/simtrace.lua @@ -1,3 +1,9 @@ +-- wireshark LUA dissector for the SIMtrace USB protocol +-- (C) 2021 by sysmocom - s.f.m.c. GmbH, Author: Eric Wild +-- SPDX-License-Identifier: GPL-2.0+ +-- +-- Usage: Put this into your ~/.wireshark/init.lua [or include it from there] + usb_simtrace_protocol = Proto("USB_simtrace", "USB simtrace protocol") -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I56574741cd77436f9f452420677c00d8049a50cc Gerrit-Change-Number: 26978 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 6 months

1
0
0 0

Change in libosmocore[master]: logging: log to stderr when logging is not initialized

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stderr when logging is not initialized ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jan 2022 17:18:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in simtrace2[master]: host: properly zero-initialize interface match structures

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26975 ) Change subject: host: properly zero-initialize interface match structures ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I304d55b584e37d9dccb75b24057bb682f799beb2 Gerrit-Change-Number: 26975 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jan 2022 17:02:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in libosmocore[master]: logging: log to stderr when logging is not initialized

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stderr when logging is not initialized ...................................................................... Patch Set 4: (1 comment) File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/d35f54f3_374c7206 PS2, Line 315: * Check whether the logging framework is initialized (osmo_log_info exists) */ : int log_initialized(void) : { : if (!osmo_log_info) : return 0; : return 1; : } > this is a non-inline function that does nothing else but exporting the value of an (already global, […] This variable is global, but I think its not exported. I have put it as extern variable in the header file now so that I can use it directly from the macros. I also thought of doing this, but I wasn't sure if it is was a good idea to expose osmo_log_info. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jan 2022 16:57:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in libosmocore[master]: logging: log to stderr when logging is not initialized

by dexter

Attention is currently required from: laforge. Hello osmith, Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26950 to look at the new patch set (#4). Change subject: logging: log to stderr when logging is not initialized ...................................................................... logging: log to stderr when logging is not initialized When the logging framework is not initialized we get an error: "ERROR: osmo_log_info == NULL! You must call log_init() before using logging in ..." There are sometimes situations where some code tries to log before logging was initialied. This is a problem because the actual log line with the debug info we need is covered up by the error message from the logging framework. Lets introduce a fallback logging function that is called when the the logging framework is not available. This function can just use fprintf to output to stderr. Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 --- M include/osmocom/core/logging.h M src/logging.c 2 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/26950/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 6 months

1
0
0 0

Change in libosmocore[master]: logging: log to stderr when logging is not initialized

by dexter

Attention is currently required from: dexter. Hello osmith, Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26950 to look at the new patch set (#3). Change subject: logging: log to stderr when logging is not initialized ...................................................................... logging: log to stderr when logging is not initialized When the logging framework is not initialized we get an error: "ERROR: osmo_log_info == NULL! You must call log_init() before using logging in ..." There are sometimes situations where some code tries to log before logging was initialied. This is a problem because the actual log line with the debug info we need is covered up by the error message from the logging framework. Lets introduce a fallback logging function that is called when the the logging framework is not available. This function can just use fprintf to output to stderr. Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 --- M include/osmocom/core/logging.h M src/logging.c 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/26950/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 6 months

1
0
0 0

Change in libosmocore[master]: osmo_libusb: Fix NULL check in osmo_usb_removed_cb()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26972 ) Change subject: osmo_libusb: Fix NULL check in osmo_usb_removed_cb() ...................................................................... osmo_libusb: Fix NULL check in osmo_usb_removed_cb() Thread 1 "simtrace2-tool" received signal SIGSEGV, Segmentation fault. 0x00007ffff73dd2a0 in llist_del (entry=0x0) at ../include/osmocom/core/linuxlist.h:130 130 __llist_del(entry->prev, entry->next); (gdb) bt Change-Id: I2b7ab8dddd69453826053663dd5589a941c2e47d --- M src/usb/osmo_libusb.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/usb/osmo_libusb.c b/src/usb/osmo_libusb.c index 05331a1..a6f194a 100644 --- a/src/usb/osmo_libusb.c +++ b/src/usb/osmo_libusb.c @@ -99,7 +99,7 @@ static void osmo_usb_removed_cb(int fd, void *user_data) { struct osmo_fd *ofd = osmo_fd_get_by_fd(fd); - if (!fd) + if (!ofd) return; osmo_fd_unregister(ofd); talloc_free(ofd); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2b7ab8dddd69453826053663dd5589a941c2e47d Gerrit-Change-Number: 26972 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 6 months

1
0
0 0

Change in libosmocore[master]: osmo_libusb: Fix NULL check in osmo_usb_removed_cb()

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26972 ) Change subject: osmo_libusb: Fix NULL check in osmo_usb_removed_cb() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2b7ab8dddd69453826053663dd5589a941c2e47d Gerrit-Change-Number: 26972 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jan 2022 16:02:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 6 months

1
0
0 0

Change in simtrace2[master]: host: Print strerror(errno) in case of problems opening the USB device

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26973 ) Change subject: host: Print strerror(errno) in case of problems opening the USB device ...................................................................... host: Print strerror(errno) in case of problems opening the USB device Change-Id: If446bf08655739281f616df952714751fe9a3b18 --- M host/src/simtrace2-cardem-pcsc.c M host/src/simtrace2-sniff.c M host/src/simtrace2-tool.c 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index 2806b0f..3ec7509 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -561,7 +561,7 @@ transp->usb_async = true; transp->usb_devh = osmo_libusb_open_claim_interface(NULL, NULL, ifm); if (!transp->usb_devh) { - fprintf(stderr, "can't open USB device\n"); + fprintf(stderr, "can't open USB device: %s\n", strerror(errno)); goto close; } diff --git a/host/src/simtrace2-sniff.c b/host/src/simtrace2-sniff.c index a4eccb2..c223008 100644 --- a/host/src/simtrace2-sniff.c +++ b/host/src/simtrace2-sniff.c @@ -472,7 +472,7 @@ do { _transp.usb_devh = osmo_libusb_open_claim_interface(NULL, NULL, &ifm_selected); if (!_transp.usb_devh) { - fprintf(stderr, "can't open USB device\n"); + fprintf(stderr, "can't open USB device: %s\n", strerror(errno)); goto close_exit; } diff --git a/host/src/simtrace2-tool.c b/host/src/simtrace2-tool.c index eb61ee2..d705796 100644 --- a/host/src/simtrace2-tool.c +++ b/host/src/simtrace2-tool.c @@ -313,7 +313,7 @@ osmo_strlcpy(ifm->path, path, sizeof(ifm->path)); transp->usb_devh = osmo_libusb_open_claim_interface(NULL, NULL, ifm); if (!transp->usb_devh) { - fprintf(stderr, "can't open USB device\n"); + fprintf(stderr, "can't open USB device: %s\n", strerror(errno)); goto close_exit; } -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If446bf08655739281f616df952714751fe9a3b18 Gerrit-Change-Number: 26973 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 6 months

1
0
0 0

Change in simtrace2[master]: cosmetic: Fix indent of printf() statement

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26974 ) Change subject: cosmetic: Fix indent of printf() statement ...................................................................... cosmetic: Fix indent of printf() statement Change-Id: I9f5c9f7720b3bc3c8d5df9750b031d8bcf2dd435 --- M host/src/simtrace2-sniff.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/host/src/simtrace2-sniff.c b/host/src/simtrace2-sniff.c index c223008..8504e8b 100644 --- a/host/src/simtrace2-sniff.c +++ b/host/src/simtrace2-sniff.c @@ -442,9 +442,9 @@ } struct usb_interface_match ifm_selected = ifm_filtered[0]; printf("Using USB device %04x:%04x Addr=%u, Path=%s, Cfg=%u, Intf=%u, Alt=%u: %d/%d/%d ", - ifm_selected.vendor, ifm_selected.product, ifm_selected.addr, ifm_selected.path, - ifm_selected.configuration, ifm_selected.interface, ifm_selected.altsetting, - ifm_selected.class, ifm_selected.sub_class, ifm_selected.protocol); + ifm_selected.vendor, ifm_selected.product, ifm_selected.addr, ifm_selected.path, + ifm_selected.configuration, ifm_selected.interface, ifm_selected.altsetting, + ifm_selected.class, ifm_selected.sub_class, ifm_selected.protocol); libusb_device_handle *dev_handle; rc = libusb_open(ifm_selected.usb_dev, &dev_handle); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9f5c9f7720b3bc3c8d5df9750b031d8bcf2dd435 Gerrit-Change-Number: 26974 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log