- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: signal.h: make om2k mo const
by fixeria 03 Aug '22

03 Aug '22

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28913 ) Change subject: signal.h: make om2k mo const ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id0969d44855506af18974de1ea81105653920d2f Gerrit-Change-Number: 28913 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 20:25:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: fix_perms: use debian:bullseye
by fixeria 03 Aug '22

03 Aug '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28903 ) Change subject: fix_perms: use debian:bullseye ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd Gerrit-Change-Number: 28903 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 20:24:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: debian-bullseye-obs-asan: new container
by fixeria 03 Aug '22

03 Aug '22

Attention is currently required from: osmith, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28902 ) Change subject: debian-bullseye-obs-asan: new container ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Then tests every night can be run using -nightly, and people can manually easy run -master to find o […] We can do multi-stage builds (https://docs.docker.com/develop/develop-images/multistage-build/). Currently most of the images in docker-playground are built upon debian-bullseye-build. With multi-stage builds we could build sanitized libosmocore in one image, and then simply use the products of `make install` for building other libraries like libosmo-abis, and finally for building sanitized osmo-apps. This approach would eliminate the need for building libosmo-* again and again for each osmo-*-master image. This is just an option, FYI. I am ok with having a sanitized packages too. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic7d6e7cc401acadbae9156d3e7f3a6230c2fb198 Gerrit-Change-Number: 28902 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 20:23:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: {gb,sim,usb}: ensure -no-undefined is present in *_la_LDFLAGS
by fixeria 03 Aug '22

03 Aug '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28918 ) Change subject: {gb,sim,usb}: ensure -no-undefined is present in *_la_LDFLAGS ...................................................................... {gb,sim,usb}: ensure -no-undefined is present in *_la_LDFLAGS Make sure that there is no undefined references in shared libraries. Inspired by GitHub PR#6 [1] by Michael Dickens. Tweaked by me. Change-Id: I7ddd6c75935b0f25d78a948f1577656d77a204e3 Related: [1] https://github.com/osmocom/libosmocore/pull/6 --- M src/gb/Makefile.am M src/sim/Makefile.am M src/usb/Makefile.am 3 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/18/28918/1 diff --git a/src/gb/Makefile.am b/src/gb/Makefile.am index 022578f..b0fcaa9 100644 --- a/src/gb/Makefile.am +++ b/src/gb/Makefile.am @@ -15,7 +15,11 @@ if ENABLE_GB lib_LTLIBRARIES = libosmogb.la -libosmogb_la_LDFLAGS = $(LTLDFLAGS_OSMOGB) -version-info $(LIBVERSION) +libosmogb_la_LDFLAGS = \ + $(LTLDFLAGS_OSMOGB) \ + -version-info $(LIBVERSION) \ + -no-undefined \ + $(NULL) libosmogb_la_LIBADD = $(TALLOC_LIBS) \ $(top_builddir)/src/libosmocore.la \ $(top_builddir)/src/vty/libosmovty.la \ diff --git a/src/sim/Makefile.am b/src/sim/Makefile.am index a73ce4b..3d30506 100644 --- a/src/sim/Makefile.am +++ b/src/sim/Makefile.am @@ -15,7 +15,10 @@ libosmosim_la_SOURCES = core.c reader.c class_tables.c \ card_fs_sim.c card_fs_usim.c card_fs_uicc.c \ card_fs_isim.c card_fs_hpsim.c card_fs_tetra.c -libosmosim_la_LDFLAGS = -version-info $(LIBVERSION) +libosmosim_la_LDFLAGS = \ + -version-info $(LIBVERSION) \ + -no-undefined \ + $(NULL) libosmosim_la_LIBADD = \ $(top_builddir)/src/libosmocore.la \ $(top_builddir)/src/gsm/libosmogsm.la \ diff --git a/src/usb/Makefile.am b/src/usb/Makefile.am index 50d45c2..a1426f9 100644 --- a/src/usb/Makefile.am +++ b/src/usb/Makefile.am @@ -12,7 +12,10 @@ lib_LTLIBRARIES = libosmousb.la libosmousb_la_SOURCES = osmo_libusb.c -libosmousb_la_LDFLAGS = -version-info $(LIBVERSION) +libosmousb_la_LDFLAGS = \ + -version-info $(LIBVERSION) \ + -no-undefined \ + $(NULL) libosmousb_la_LIBADD = \ $(top_builddir)/src/libosmocore.la \ $(TALLOC_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7ddd6c75935b0f25d78a948f1577656d77a204e3 Gerrit-Change-Number: 28918 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmocore[master]: logging: add a new category DLCSN1 for libosmo-csn1
by fixeria 03 Aug '22

03 Aug '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28917 ) Change subject: logging: add a new category DLCSN1 for libosmo-csn1 ...................................................................... logging: add a new category DLCSN1 for libosmo-csn1 This new category is going to be used by CSN.1 codec in libosmo-csn1. Change-Id: Ie8c0effb764547a0f9cc8c6825e11a6617501e95 --- M include/osmocom/core/logging.h M src/logging.c M tests/logging/logging_vty_test.vty 3 files changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/28917/1 diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index 0078425..f1304f5 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -151,7 +151,8 @@ #define DLNSSIGNAL -23 /*!< Osmocom NS layer signal pdus */ #define DLIUUP -24 /*!< Osmocom IuUP layer */ #define DLPFCP -25 /*!< Osmocom Packet Forwarding Control Protocol */ -#define OSMO_NUM_DLIB 25 /*!< Number of logging sub-systems in libraries */ +#define DLCSN1 -26 /*!< CSN.1 (Concrete Syntax Notation 1) codec */ +#define OSMO_NUM_DLIB 26 /*!< Number of logging sub-systems in libraries */ /* Colors that can be used in log_info_cat.color */ #define OSMO_LOGCOLOR_NORMAL NULL diff --git a/src/logging.c b/src/logging.c index 1a0abc2..ce42e4c 100644 --- a/src/logging.c +++ b/src/logging.c @@ -307,6 +307,12 @@ .enabled = 1, .loglevel = LOGL_NOTICE, .color = "\033[38;5;51m", }, + [INT2IDX(DLCSN1)] = { + .name = "DLCSN1", + .description = "libosmo-csn1 Concrete Syntax Notation 1 codec", + .enabled = 1, .loglevel = LOGL_NOTICE, + .color = "\033[38;5;11m", + }, }; void assert_loginfo(const char *src) diff --git a/tests/logging/logging_vty_test.vty b/tests/logging/logging_vty_test.vty index 860f5c5..2cff62c 100644 --- a/tests/logging/logging_vty_test.vty +++ b/tests/logging/logging_vty_test.vty @@ -54,7 +54,7 @@ logging print level (0|1) logging print file (0|1|basename) [last] logging set-log-mask MASK - logging level (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp) (debug|info|notice|error|fatal) + logging level (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1) (debug|info|notice|error|fatal) logging level set-all (debug|info|notice|error|fatal) logging level force-all (debug|info|notice|error|fatal) no logging level force-all @@ -472,7 +472,7 @@ logging_vty_test# list ... - logp (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp) (debug|info|notice|error|fatal) .LOGMESSAGE + logp (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1) (debug|info|notice|error|fatal) .LOGMESSAGE ... logging_vty_test# logp? @@ -509,6 +509,7 @@ lnssignal GPRS NS layer signal PDU liuup Iu UP layer lpfcp libosmo-pfcp Packet Forwarding Control Protocol + lcsn1 libosmo-csn1 Concrete Syntax Notation 1 codec logging_vty_test# logp lglobal ? debug Log debug messages and higher levels -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie8c0effb764547a0f9cc8c6825e11a6617501e95 Gerrit-Change-Number: 28917 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-cbc[master]: sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req
by fixeria 03 Aug '22

03 Aug '22

Attention is currently required from: osmith, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28897 ) Change subject: sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I4a5ac56b7e6eeb85aee07ae2ddf10fa2afbbf4ef Gerrit-Change-Number: 28897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 19:18:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-pfcp[master]: configure: fix AC_CONFIG_MACRO_DIRS related warnings
by fixeria 03 Aug '22

03 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28900 ) Change subject: configure: fix AC_CONFIG_MACRO_DIRS related warnings ...................................................................... configure: fix AC_CONFIG_MACRO_DIRS related warnings Create m4/.gitkeep to eliminate the following warning: aclocal: warning: couldn't open directory 'm4': No such file or directory Add 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac to as suggested: libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac Change-Id: Id9d605490c4b403b99ed54745838cc9f242030c3 --- M configure.ac A m4/.gitkeep 2 files changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 4391ff9..8d0ebb1 100644 --- a/configure.ac +++ b/configure.ac @@ -6,6 +6,7 @@ AC_CONFIG_AUX_DIR([.]) AM_INIT_AUTOMAKE([dist-bzip2]) +AC_CONFIG_MACRO_DIRS([m4]) AC_CONFIG_TESTDIR(tests) CFLAGS="$CFLAGS -std=gnu11" diff --git a/m4/.gitkeep b/m4/.gitkeep new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/m4/.gitkeep -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id9d605490c4b403b99ed54745838cc9f242030c3 Gerrit-Change-Number: 28900 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmo-pfcp[master]: configure: fix warning: AC_OUTPUT should be used without arguments
by fixeria 03 Aug '22

03 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28901 ) Change subject: configure: fix warning: AC_OUTPUT should be used without arguments ...................................................................... configure: fix warning: AC_OUTPUT should be used without arguments Change-Id: I71fc8dc78b8b10628ef0533c69e42c0298fb27df --- M configure.ac 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 8d0ebb1..77cb672 100644 --- a/configure.ac +++ b/configure.ac @@ -85,7 +85,7 @@ dnl Generate the output AM_CONFIG_HEADER(config.h) -AC_OUTPUT( +AC_CONFIG_FILES([ libosmo-gtlv.pc libosmo-pfcp.pc include/Makefile @@ -104,4 +104,5 @@ doc/Makefile doc/charts/Makefile contrib/Makefile - Makefile) + Makefile]) +AC_OUTPUT -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I71fc8dc78b8b10628ef0533c69e42c0298fb27df Gerrit-Change-Number: 28901 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: cbc: Test ETWS msg over CBSP
by laforge 03 Aug '22

03 Aug '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 ) Change subject: cbc: Test ETWS msg over CBSP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de Gerrit-Change-Number: 28912 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 16:11:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: cbc: Test sending Unknown TAI List to osmo-cbc
by laforge 03 Aug '22

03 Aug '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893 ) Change subject: cbc: Test sending Unknown TAI List to osmo-cbc ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893/comment/a18a8ceb_5ae7… PS2, Line 7: sneding Unknwon > you appear to be competing against me in terms of typo density here... […] Done File cbc/CBC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893/comment/11e1227a_40ea… PS2, Line 505: unknwon > even here this unkn-won, must be some ancient korean unit of currency :) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7d8cf5e6498d03ad340b8f843ce93a20171e9fca Gerrit-Change-Number: 28893 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Aug 2022 16:10:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log