Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 )
Change subject: cbc: Test ETWS msg over CBSP
......................................................................
Patch Set 2:
(1 comment)
File library/CBSP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/9b862fa4_ddde…
PS2, Line 424: > 6.5.0
jenkins runs eclipse-titan 8.0.0. Did you mean < 6.5.0?
Otherwise adding a reference here to fix this in the future is probably useful (osmocom issue?)
same below
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de
Gerrit-Change-Number: 28912
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 11:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893 )
Change subject: cbc: Test sending Unknown TAI List to osmo-cbc
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File library/sbcap/SBC_AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893/comment/57bbafc9_7ba5…
PS3, Line 260: }; */
left this on purpose?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28893
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7d8cf5e6498d03ad340b8f843ce93a20171e9fca
Gerrit-Change-Number: 28893
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 11:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 )
Change subject: abis_om2000: move switch-case to function
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmo-bsc/abis_om2000.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/42ee9eaf_02cb0fbc
PS1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state)
> I am not sure about the naming scheme. "abis" is one layer below. […]
Why do you say abis is one layer below? AFAIU OM2K is (part of) an implementation of the Abis interface, which deviates from what is specified in TS 12.21.
abis_nm_op_sate_from_om2k_op_state()
om2k_to_abis_nm_op_state()
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317
Gerrit-Change-Number: 28914
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 10:45:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28914
to look at the new patch set (#2).
Change subject: abis_om2000: move switch-case to function
......................................................................
abis_om2000: move switch-case to function
The switch-case in update_op_state() and update_mo_state() can be split
off into functions. This makes to code better readable.
Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317
Related: OS#5634
---
M src/osmo-bsc/abis_om2000.c
1 file changed, 41 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/14/28914/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317
Gerrit-Change-Number: 28914
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 )
Change subject: abis_om2000: move switch-case to function
......................................................................
Patch Set 2:
(4 comments)
File src/osmo-bsc/abis_om2000.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/9d616c3e_a8adb091
PS1, Line 964: oml_avstate_from_om2k_mostate
> static?
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/6e594a99_5be912e9
PS1, Line 997: switch (mo->class) {
> You can probably move this inside oml_avstate_from_om2k_mostate() too, and pass mo->class there as a […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/4e50cb90_dd571a7b
PS1, Line 1016: oml_opstate_from_om2k_opstate
> static?
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/8d93e84e_3d5f657d
PS1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state)
> it's a bit strange that a function starting with "oml_opstate" returns a "abis_nm_op_state" don't yo […]
I am not sure about the naming scheme. "abis" is one layer below. As far as I understand om2k is also on top of abis. The real difference is between OM2K and OML.
Du you have a suggestion for a better function name?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317
Gerrit-Change-Number: 28914
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 10:27:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment