- gerrit-log - lists.osmocom.org

Change in docker-playground[master]: fix_perms: use debian:bullseye
by osmith 04 Aug '22

04 Aug '22

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28903 ) Change subject: fix_perms: use debian:bullseye ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd Gerrit-Change-Number: 28903 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:45:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: fix_perms: use debian:bullseye
by osmith 04 Aug '22

04 Aug '22

Attention is currently required from: osmith. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/28903 to look at the new patch set (#2). Change subject: fix_perms: use debian:bullseye ...................................................................... fix_perms: use debian:bullseye Use debian:bullseye instead of debian-bullseye-build. Building the latter requires a lot of time, it's definitively not needed for just running chmod. Use debian:bullseye, since we use it as base for most images and it's therefore very likely that it's already downloaded (and if not, it would get downloaded here). Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd --- M jenkins-common.sh 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/03/28903/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd Gerrit-Change-Number: 28903 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: Cosmetic: jobs/ttcn3: debian-stretch -> debian
by osmith 04 Aug '22

04 Aug '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28908 ) Change subject: Cosmetic: jobs/ttcn3: debian-stretch -> debian ...................................................................... Cosmetic: jobs/ttcn3: debian-stretch -> debian Remove reference to stretch (debian 9), as the jobs run on a newer debian version now. Remove the reference altogether so we don't need to update it here. The current version can be looked up in docker-playground.git. Change-Id: I06c74830b0f6fe0baed44c300f9e1023fb0522de --- M jobs/ttcn3-testsuites.yml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 131ffac..2016dd2 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -20,7 +20,7 @@ - "{job-name}" # Folders from docker-playground.git job-name: - # debian-stretch nightly - order by time + # debian nightly - order by time - nplab-m3ua-test: blocking: "^(nplab|NPLAB-.*)-m3ua-test.*" timer: 10 03 * * * @@ -160,7 +160,7 @@ description: | Test open5gs-smfd + open5gs-upfd PGW main. - # debian-stretch latest stable + # debian latest stable - nplab-m3ua-test-latest: blocking: "^(nplab|NPLAB-.*)-m3ua-test.*" timer: 10 03 * * * @@ -240,7 +240,7 @@ blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*" timer: 40 13 * * * - # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian-stretch) jobs + # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian) jobs # centos7 nightly - TTCN3-centos7-pcap-client-test: 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I06c74830b0f6fe0baed44c300f9e1023fb0522de Gerrit-Change-Number: 28908 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: Cosmetic: jobs/ttcn3: debian-stretch -> debian
by osmith 04 Aug '22

04 Aug '22

Attention is currently required from: osmith. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28908 to look at the new patch set (#3). Change subject: Cosmetic: jobs/ttcn3: debian-stretch -> debian ...................................................................... Cosmetic: jobs/ttcn3: debian-stretch -> debian Remove reference to stretch (debian 9), as the jobs run on a newer debian version now. Remove the reference altogether so we don't need to update it here. The current version can be looked up in docker-playground.git. Change-Id: I06c74830b0f6fe0baed44c300f9e1023fb0522de --- M jobs/ttcn3-testsuites.yml 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/08/28908/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I06c74830b0f6fe0baed44c300f9e1023fb0522de Gerrit-Change-Number: 28908 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: logging: add a new category DLCSN1 for libosmo-csn1
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28917 ) Change subject: logging: add a new category DLCSN1 for libosmo-csn1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > You could simply set a dynamic value at runtime for it, but ok. AFAIU, the idea behind these DLFOO categories is to avoid the need to create the same logging category in several projects. The CSN.1 codec is currently used in osmo-pcu.git and going to be used in osmocom-bb.git (several applications: trxcon, mobile) and probably in osmo-bsc.git (for Rest Octets and MS Classmark parsing). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie8c0effb764547a0f9cc8c6825e11a6617501e95 Gerrit-Change-Number: 28917 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:39:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: sbcap: Fix spec references in comments
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28930 ) Change subject: sbcap: Fix spec references in comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I89bc9d15548e6c709f0e1b614f00bc98ec41d441 Gerrit-Change-Number: 28930 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:33:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: cbc: Test ETWS msg over SBc-AP
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28929 ) Change subject: cbc: Test ETWS msg over SBc-AP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I506322fc8a664716db8cd79217c2091b0b926836 Gerrit-Change-Number: 28929 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:33:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: cbc: Test ETWS msg over CBSP
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 ) Change subject: cbc: Test ETWS msg over CBSP ...................................................................... Patch Set 3: (2 comments) File cbc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/4c012693_93bf… PS3, Line 101: var template (omit) uint8_t channel_ind := omit; AFAIU, if msg.channel_ind is omitted, then channel_ind would also be equal to omit. Could you explain why are you adding a separate template variable? What's wrong with passing msg.channel_ind directly? File cbc/CBC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/47e68c4d_87a6… PS3, Line 353: g_pars.exp_cbs_msg.channel_ind Here I guess you're doing ispresent() because g_pars.exp_cbs_msg may be omitted? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de Gerrit-Change-Number: 28912 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-cbc[master]: cbsp: Log storing of CellId info received from peers
by pespin 04 Aug '22

04 Aug '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28932 ) Change subject: cbsp: Log storing of CellId info received from peers ...................................................................... cbsp: Log storing of CellId info received from peers This is already done similarly in Sbc-AP. Change-Id: I81ad8d40c5e2b9fbc011db795993fb7f00e99692 --- M src/cbsp_smscb_peer_fsm.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/32/28932/1 diff --git a/src/cbsp_smscb_peer_fsm.c b/src/cbsp_smscb_peer_fsm.c index 8a435f9..f5e3d95 100644 --- a/src/cbsp_smscb_peer_fsm.c +++ b/src/cbsp_smscb_peer_fsm.c @@ -171,6 +171,8 @@ cci_from_cbsp(cci, id_discr, &ce->cell_id); cci->num_compl.num_compl += ce->num_compl; cci->num_compl.num_bcast_info += ce->num_bcast_info; + LOGPFSML(mp->fi, LOGL_DEBUG, "Appending CellId %s to Broadcast Completed list\n", + cbc_cell_id2str(cci)); } static void msg_peer_append_cbsp_compl(struct cbc_message_peer *mp, struct osmo_cbsp_num_compl_list *nclist) @@ -195,6 +197,8 @@ llist_add_tail(&cci->list, &mp->cell_list); } cci_from_cbsp(cci, id_discr, &ce->cell_id); + LOGPFSML(mp->fi, LOGL_DEBUG, "Appending CellId %s to Cell list\n", + cbc_cell_id2str(cci)); } static void msg_peer_append_cbsp_cell(struct cbc_message_peer *mp, struct osmo_cbsp_cell_list *clist) @@ -219,6 +223,8 @@ } cci->id_discr = cci_discr_from_cell_id(fe->id_discr); cci->fail.cause = fe->cause; + LOGPFSML(mp->fi, LOGL_DEBUG, "Appending CellId %s (cause: %u) to Failed list\n", + cbc_cell_id2str(cci), cci->fail.cause); } static void msg_peer_append_cbsp_fail(struct cbc_message_peer *mp, struct llist_head *flist) { -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I81ad8d40c5e2b9fbc011db795993fb7f00e99692 Gerrit-Change-Number: 28932 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-cbc[master]: cbsp: Store content of received Cell Id from Failed List
by pespin 04 Aug '22

04 Aug '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28933 ) Change subject: cbsp: Store content of received Cell Id from Failed List ...................................................................... cbsp: Store content of received Cell Id from Failed List Change-Id: I10d2627cb5ef327fd57c22480a4e7d9a464930f0 --- M src/cbsp_smscb_peer_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/33/28933/1 diff --git a/src/cbsp_smscb_peer_fsm.c b/src/cbsp_smscb_peer_fsm.c index f5e3d95..001b822 100644 --- a/src/cbsp_smscb_peer_fsm.c +++ b/src/cbsp_smscb_peer_fsm.c @@ -221,7 +221,7 @@ return; llist_add_tail(&cci->list, &mp->fail_list); } - cci->id_discr = cci_discr_from_cell_id(fe->id_discr); + cci_from_cbsp(cci, fe->id_discr, &fe->cell_id); cci->fail.cause = fe->cause; LOGPFSML(mp->fi, LOGL_DEBUG, "Appending CellId %s (cause: %u) to Failed list\n", cbc_cell_id2str(cci), cci->fail.cause); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I10d2627cb5ef327fd57c22480a4e7d9a464930f0 Gerrit-Change-Number: 28933 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log