- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: obs-mirror.sh: exclude dotfiles
by osmith 04 Aug '22

04 Aug '22

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28927 ) Change subject: obs-mirror.sh: exclude dotfiles ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iacee2ea4acada60d8de960592fb828911a55781e Gerrit-Change-Number: 28927 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 13:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: debian-bullseye-obs-asan: new container
by osmith 04 Aug '22

04 Aug '22

Attention is currently required from: laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28902 ) Change subject: debian-bullseye-obs-asan: new container ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We can do multi-stage builds (https://docs.docker.com/develop/develop-images/multistage-build/). […] pespin wrote: > I'd probably change the osmo-*-master Dockerfiles to build all dependency libs from master with --enable-asan enabled, I have been doing that for ages in my local copy of docker-playground.git > This has the benefit that during development one can for instance, easily set LIBOSMO_NETIF_BRANCH=myownbranch when testing ie. osmo-stp-master. IMHO this is not a good reason to build everything from source in the docker containers. This approach is suboptimal for getting a short test cycle, one still has to push the changes to osmocom git servers, then have docker fetch them again and build the program completely from scratch instead of preserving objects for c files that were not modified. fixeria wrote: > We can do multi-stage builds (https://docs.docker.com/develop/develop-images/multistage-build/). Currently most of the images in docker-playground are built upon debian-bullseye-build. With multi-stage builds we could build sanitized libosmocore in one image, and then simply use the products of `make install` for building other libraries like libosmo-abis, and finally for building sanitized osmo-apps. This approach would eliminate the need for building libosmo-* again and again for each osmo-*-master image. I'm not sure if this would actually make the logic in docker-playground more complicated. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic7d6e7cc401acadbae9156d3e7f3a6230c2fb198 Gerrit-Change-Number: 28902 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 13:36:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in gapk[master]: configure: fix warning: AC_OUTPUT should be used without arguments
by fixeria 04 Aug '22

04 Aug '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/28934 ) Change subject: configure: fix warning: AC_OUTPUT should be used without arguments ...................................................................... configure: fix warning: AC_OUTPUT should be used without arguments Change-Id: I32b07f8f8c3f4092683fa6a25a7e895f188640b7 --- M configure.ac 1 file changed, 10 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/34/28934/1 diff --git a/configure.ac b/configure.ac index b16acc8..ad659ca 100644 --- a/configure.ac +++ b/configure.ac @@ -15,16 +15,6 @@ AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_TESTDIR(tests) -AC_CONFIG_FILES([ - Makefile - src/Makefile - libgsmhr/Makefile - include/Makefile - include/gsmhr/Makefile - libosmogapk.pc - tests/atlocal - tests/Makefile -]) # Options AC_ARG_ENABLE(gsmhr, @@ -117,4 +107,13 @@ AC_FUNC_MALLOC AC_CHECK_FUNCS([memset]) -AC_OUTPUT([contrib/gapk.spec]) +AC_CONFIG_FILES([contrib/gapk.spec + Makefile + src/Makefile + libgsmhr/Makefile + include/Makefile + include/gsmhr/Makefile + libosmogapk.pc + tests/atlocal + tests/Makefile]) +AC_OUTPUT -- To view, visit https://gerrit.osmocom.org/c/gapk/+/28934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I32b07f8f8c3f4092683fa6a25a7e895f188640b7 Gerrit-Change-Number: 28934 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-tetra[master]: Added basic AFC as implemented by SQ5BPF into float_to_bits.c
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: wbokslag, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28894 ) Change subject: Added basic AFC as implemented by SQ5BPF into float_to_bits.c ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1c9343b83739108a1e423c4880e1dc7964656529 Gerrit-Change-Number: 28894 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 04 Aug 2022 13:02:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: obs-mirror: use obs.osmocom.org packages as source
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28928 ) Change subject: obs-mirror: use obs.osmocom.org packages as source ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6be69530a7aa65b0cf3866fc7e65af79c9d9d45 Gerrit-Change-Number: 28928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 13:00:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: obs-mirror.sh: exclude dotfiles
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28927 ) Change subject: obs-mirror.sh: exclude dotfiles ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iacee2ea4acada60d8de960592fb828911a55781e Gerrit-Change-Number: 28927 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:59:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-cbc[master]: cbsp: Store content of received Cell Id from Failed List
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28933 ) Change subject: cbsp: Store content of received Cell Id from Failed List ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I10d2627cb5ef327fd57c22480a4e7d9a464930f0 Gerrit-Change-Number: 28933 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:58:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-cbc[master]: cbsp: Log storing of CellId info received from peers
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28932 ) Change subject: cbsp: Log storing of CellId info received from peers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I81ad8d40c5e2b9fbc011db795993fb7f00e99692 Gerrit-Change-Number: 28932 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:57:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: obs: add osmo-bsc-nat, osmo-fl2k
by fixeria 04 Aug '22

04 Aug '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28931 ) Change subject: obs: add osmo-bsc-nat, osmo-fl2k ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4b96f15e95c70f1dca12a292964e6f12b04e4a04 Gerrit-Change-Number: 28931 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:46:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: fix_perms: use debian:bullseye
by osmith 04 Aug '22

04 Aug '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28903 ) Change subject: fix_perms: use debian:bullseye ...................................................................... fix_perms: use debian:bullseye Use debian:bullseye instead of debian-bullseye-build. Building the latter requires a lot of time, it's definitively not needed for just running chmod. Use debian:bullseye, since we use it as base for most images and it's therefore very likely that it's already downloaded (and if not, it would get downloaded here). Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd --- M jenkins-common.sh 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Jenkins Builder: Verified osmith: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/jenkins-common.sh b/jenkins-common.sh index b393b05..33b1a67 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -238,16 +238,12 @@ } fix_perms() { - if ! docker_image_exists "debian-bullseye-build"; then - docker_images_require "debian-bullseye-build" - fi - echo Fixing permissions docker run --rm \ -v $VOL_BASE_DIR:/data \ -v $CACHE_DIR:/cache \ --name ${BUILD_TAG}-cleaner \ - $REPO_USER/debian-bullseye-build \ + debian:bullseye \ chmod -R a+rX /data/ /cache/ } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd Gerrit-Change-Number: 28903 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log