Attention is currently required from: laforge, fixeria.
Hello Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170
to look at the new patch set (#4).
Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper
......................................................................
SIGTRAN: add osmo_sccp_tx_disconn_data() helper
SCCP RLSD message might have up to 130 bytes of optional data according to ITU-T Rec Q.713 §4.5 - add helper which
allows sending it and use it in example code.
Related: OS#5579
Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe
---
M examples/sccp_test_vty.c
M include/osmocom/sigtran/sccp_helpers.h
M src/sccp_helpers.c
3 files changed, 24 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/70/29170/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe
Gerrit-Change-Number: 29170
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 )
Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper
......................................................................
Patch Set 3:
(4 comments)
File examples/sccp_test_vty.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/3246d21f_86c3c4d5
PS1, Line 97:
> I would expect it to be aligned to the opening brace, and it looks like you intended to do so. […]
Done
File examples/sccp_test_vty.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/02318179_c4a28f71
PS2, Line 97: [DATA]
> You forgot to add documentation an optional parameter: […]
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/f0e77100_09142d00
PS2, Line 103: argv[1]
> Is argv[1] guaranteed to be NULL if argc < 2? There might be garbage left in the argv[] buffer, so I […]
Indeed. Actually, I think it's better to skip the data variable altogether - see next revision.
I don't see any use for hex input: so far only the presence of data and the amount of it were important for testing - actual content was irrelevant.
File include/osmocom/sigtran/sccp_helpers.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/0b2c5208_cd72b691
PS2, Line 48:
> Really weird alignment making it rather harder to read. Tab-size should be 8.
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29170
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I92ae22d2cab5863245fba3d904a300055fda34fe
Gerrit-Change-Number: 29170
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Aug 2022 12:46:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 )
Change subject: SIGTRAN: add function to check connection existence
......................................................................
Patch Set 13:
(1 comment)
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/20129f38_044df09b
PS12, Line 459: osmo_sccp_conn_id_exists
> My suggestion is to expose conn_find_by_id() and use it to check connection existence, instead of ad […]
I don't see any advantage in doing that: even if we expose that function it would still be more convenient to write the wrapper returning bool.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01
Gerrit-Change-Number: 29087
Gerrit-PatchSet: 13
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Aug 2022 12:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment