- gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: packaging: add missing libnftnl, libnftables deps
by laforge 22 Aug '22

22 Aug '22

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29188 ) Change subject: packaging: add missing libnftnl, libnftables deps ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I am wondering why we are depending on libnftnl at all. Are we using it directly from osmo-upf codebase? To me it seesm that all we use is libnftables, and that in turn has an upstream dependency to libnftnl, which again has a dependency to libmnl. But those downstream dependencies should not be of our concern, it is the job of distribution packaging and pkg-config to pull those in. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I974dd3163e50e6b1a099eac5d5f6a1cac07f44ad Gerrit-Change-Number: 29188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:19:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-pfcp[master]: packaging: depend on libosmocore >= 1.7.0
by laforge 22 Aug '22

22 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 ) Change subject: packaging: depend on libosmocore >= 1.7.0 ...................................................................... packaging: depend on libosmocore >= 1.7.0 Require the same libosmocore version in configure.ac and rpm spec as already set in debian/control. Change-Id: I701f1aacca22a697f35aba0041a71945c5aea107 --- M configure.ac M contrib/libosmo-pfcp.spec.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 6d51465..1b8436e 100644 --- a/configure.ac +++ b/configure.ac @@ -37,7 +37,7 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) dnl checks for header files AC_HEADER_STDC diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index e47d52c..d6481c2 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -11,7 +11,7 @@ BuildRequires: libtool >= 2 BuildRequires: lksctp-tools-devel BuildRequires: pkgconfig >= 0.20 -BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmocore) >= 1.7.0 BuildRequires: pkgconfig(talloc) %description -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I701f1aacca22a697f35aba0041a71945c5aea107 Gerrit-Change-Number: 29185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in libosmo-pfcp[master]: rpm spec: reduce summary line length
by laforge 22 Aug '22

22 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29165 ) Change subject: rpm spec: reduce summary line length ...................................................................... rpm spec: reduce summary line length Fixes the following rpmlint error: [ 17s] libosmo-pfcp.src: E: summary-too-long (Badness: 200) libosmo-pfcp: PFCP protocol encoding and decoding, and generic PFCP endpoint implementation [ 17s] The 'Summary:' must not exceed 79 characters. also, coincidentally it fixes: [ 17s] libosmo-pfcp.src: E: summary-not-capitalized (Badness: 20) libosmo-pfcp: PFCP protocol encoding and decoding, and generic PFCP endpoint implementation [ 17s] Summary doesn't begin with a capital letter. and the non-critical warning: [ 17s] libosmo-pfcp.src: W: name-repeated-in-summary libosmo-pfcp [ 17s] The name of the package is repeated in its summary. Make the summary brief and [ 17s] to the point without including redundant information in it. Related: OS#5653 Change-Id: I293f77849d50e68753b82d7b5476c19217ecc2de --- M contrib/libosmo-pfcp.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index 286a644..4ef2607 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -1,7 +1,7 @@ Name: libosmo-pfcp Version: @VERSION@ Release: 0 -Summary: libosmo-pfcp: PFCP protocol encoding and decoding, and generic PFCP endpoint implementation +Summary: PFCP protocol encoding, decoding and endpoint implementation License: AGPL-3.0-or-later AND GPL-2.0-or-later Group: Hardware/Mobile URL: https://osmocom.org/projects/libosmo-pfcp -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I293f77849d50e68753b82d7b5476c19217ecc2de Gerrit-Change-Number: 29165 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmo-pfcp[master]: rpm spec: use --disable-static
by laforge 22 Aug '22

22 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 ) Change subject: rpm spec: use --disable-static ...................................................................... rpm spec: use --disable-static Follow what we are doing in other Osmocom rpm packaging by not building and packaging static libraries. Fix for rpmlint errors when building for OpenSUSE: libosmo-gtlv-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/libosmo-gtlv.a libosmo-pfcp-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/libosmo-pfcp.a libosmo-gtlv-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-gtlv.a libosmo-pfcp-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-pfcp.a (If we wanted to build with static libraries, we would need to use -ffat-lto-objects to get rid of the second error.) Related: https://github.com/rpm-software-management/rpmlint/issues/458 Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 --- M contrib/libosmo-pfcp.spec.in 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index 4ef2607..e47d52c 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -72,6 +72,7 @@ echo "%{version}" >.tarball-version autoreconf -fi %configure \ + --disable-static \ --includedir="%_includedir/%name" make %{?_smp_mflags} @@ -95,7 +96,6 @@ %dir %{_includedir}/%{name}/osmocom %{_includedir}/%{name}/osmocom/gtlv %{_libdir}/libosmo-gtlv.so -%{_libdir}/libosmo-gtlv.a %{_libdir}/pkgconfig/libosmo-gtlv.pc %files -n libosmo-pfcp0 @@ -106,7 +106,6 @@ %dir %{_includedir}/%{name}/osmocom %{_includedir}/%{name}/osmocom/pfcp %{_libdir}/libosmo-pfcp.so -%{_libdir}/libosmo-pfcp.a %{_libdir}/pkgconfig/libosmo-pfcp.pc %changelog -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 Gerrit-Change-Number: 29183 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in libosmo-pfcp[master]: debian/control: move -dev deps of libosmo-gtlv-dev
by laforge 22 Aug '22

22 Aug '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 ) Change subject: debian/control: move -dev deps of libosmo-gtlv-dev ...................................................................... debian/control: move -dev deps of libosmo-gtlv-dev Only the -dev package of libosmo-gtlv should depend on other -dev packages. Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a --- M debian/control 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian/control b/debian/control index c5d9f04..1d4822d 100644 --- a/debian/control +++ b/debian/control @@ -33,8 +33,6 @@ Multi-Arch: same Depends: ${shlibs:Depends}, ${misc:Depends}, - libosmocore-dev (>= 1.7.0), - libtalloc-dev (>= 2.1.0) Pre-Depends: ${misc:Pre-Depends} Description: Generic TLV and TLIV protocol support Decoding, encoding and logging of protocols using a Tag-Length-Value and/or @@ -45,7 +43,9 @@ Multi-Arch: same Section: libdevel Depends: ${misc:Depends}, - libosmo-gtlv0 (= ${binary:Version}) + libosmo-gtlv0 (= ${binary:Version}), + libosmocore-dev (>= 1.7.0), + libtalloc-dev (>= 2.1.0) Description: Development files for libosmo-gtlv libosmo-gtlv implements decoding, encoding and logging of protocols using a Tag-Length-Value and/or Tag-Length-Instance-Value structure. This package in -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a Gerrit-Change-Number: 29184 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in libosmo-pfcp[master]: Bump version: 0.1.0.32-823b → 0.1.1
by laforge 22 Aug '22

22 Aug '22

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 ) Change subject: Bump version: 0.1.0.32-823b → 0.1.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I9a7be8342754fdbc21b83281c8ebcbf38112c61b Gerrit-Change-Number: 29186 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:16:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-pfcp[master]: packaging: depend on libosmocore >= 1.7.0
by laforge 22 Aug '22

22 Aug '22

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 ) Change subject: packaging: depend on libosmocore >= 1.7.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I701f1aacca22a697f35aba0041a71945c5aea107 Gerrit-Change-Number: 29185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:16:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-pfcp[master]: debian/control: move -dev deps of libosmo-gtlv-dev
by laforge 22 Aug '22

22 Aug '22

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 ) Change subject: debian/control: move -dev deps of libosmo-gtlv-dev ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I4a7ba317e54f7f19d0947e95f7ab0b4f1e8fd43a Gerrit-Change-Number: 29184 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:16:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-pfcp[master]: rpm spec: use --disable-static
by laforge 22 Aug '22

22 Aug '22

Attention is currently required from: osmith, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 ) Change subject: rpm spec: use --disable-static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 Gerrit-Change-Number: 29183 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Aug 2022 13:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: examples: update vty code
by msuraev 22 Aug '22

22 Aug '22

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29192 ) Change subject: examples: update vty code ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I52d0823b7843aa61594e728a0fac19d884ff78fe Gerrit-Change-Number: 29192 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 22 Aug 2022 12:57:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log