- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: lint: ignore MACRO_WITH_FLOW_CONTROL
by neels 15 Sep '22

15 Sep '22

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29359 ) Change subject: lint: ignore MACRO_WITH_FLOW_CONTROL ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: i have made one too, OSMO_NAME_C_IMPL(), but still i think it's ok to let the linter complain about it. because in general we should avoid flow control macros, and for the very rare cases where we allow it, it should be good enough to find someone to remove the linter vote before merging -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I79da5a426db59031e3b16aecedeaa1498c91e847 Gerrit-Change-Number: 29359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:06:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: Make esme struct shared
by neels 15 Sep '22

15 Sep '22

Attention is currently required from: laforge, pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 21: (2 comments) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/5e997766_64e5457e PS21, Line 14: esme You marked my comment as resolved without responding. struct naming seems unclear; we now have struct esme and struct smpp_esme, right? api doc explanation of the difference would be good File src/utils/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/57114f65_ac22c05a PS19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \ > I completely agree - this problems dates back to BSC/MSC split and the shared gsm_network struct whi […] struct gsm_network contains opaque pointers to vlr_instance, that shouldn't pull in libvlr as dependency; is it gsm_network_init()? this is not so important, but seems like an easy way out here -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 21 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:01:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: SMPP: move read/write callbacks to libsmpputil
by neels 15 Sep '22

15 Sep '22

Attention is currently required from: osmith, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28848 ) Change subject: SMPP: move read/write callbacks to libsmpputil ...................................................................... Patch Set 28: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/0f4c540b_64b8ea6a PS28, Line 7: SMPP: move read/write callbacks to libsmpputil would be good to give a reason for the move / which other caller is currently expected File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/dcbf9993_b50aaa3a PS28, Line 51: + * osmo_fd to properly check for errors. you have diff '+' leaked into the C code https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/683ef905_fe48acca PS28, Line 53: + * an error. The code there should handle closing the connection. I would prefer to keep this macro confined locally to a .c file, i guess smpp_utils.c - contains flow control (not local to a .c file but in a header file) - requiring a label - requiring a specific return type in calling code If this makes it into public API, it needs a more detailed explanation, particularly about the 'return 0' meaning "try again". I guess best would be a code example of what the macro expects. https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/95e06b96_0280d326 PS28, Line 55: + * projects as well. hmm idk. this should have a name that is different from the general libosmocore-style to avoid naming conflicts. For example if you plan to move it to libosmocore, then you can clearly switch from one to the other. like SMPP_CHECK_FD_READ File src/libsmpputil/smpp_utils.c: https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/75c3dae7_8579125f PS28, Line 58: /* !\brief call-back when per-ESME TCP socket has some data to be read */ drop \brief, see https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_AP… https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/8448af0d_bece25b5 PS28, Line 117: int esme_write_callback(struct esme *esme, int fd, struct msgb *msg) documentation for args and rc? (I tried to understand the 'exit(99)' below and found no explanation for rc == 0) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76 Gerrit-Change-Number: 28848 Gerrit-PatchSet: 28 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 11:43:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: add ttcn3-hnbgw-test variant with-pfcp
by pespin 15 Sep '22

15 Sep '22

Attention is currently required from: osmith, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 ) Change subject: add ttcn3-hnbgw-test variant with-pfcp ...................................................................... Patch Set 3: (1 comment) File ttcn3-hnbgw-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/29339/comment/6968df9e_198… PS3, Line 82: echo Starting container with STP > is it worth the effort? this is just a ci shell script, the single user is our jenkins, it works in […] If you want to understand what's run here, and how run a subset of the things here: yes it helps a lot. Also if for instance I want to temporarily run some program with gdb, then I need to change it in one place, not find out where. So sparing you now one round of running the script may save others time and efforts later. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe Gerrit-Change-Number: 29339 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 11:31:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: lint: ignore MACRO_WITH_FLOW_CONTROL
by pespin 15 Sep '22

15 Sep '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29359 ) Change subject: lint: ignore MACRO_WITH_FLOW_CONTROL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I79da5a426db59031e3b16aecedeaa1498c91e847 Gerrit-Change-Number: 29359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 11:29:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: add ttcn3-hnbgw-test variant with-pfcp
by neels 15 Sep '22

15 Sep '22

Attention is currently required from: osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 ) Change subject: add ttcn3-hnbgw-test variant with-pfcp ...................................................................... Patch Set 3: (1 comment) File ttcn3-hnbgw-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/29339/comment/50cc92fc_d37… PS3, Line 82: echo Starting container with STP > It would be really great if you moved duplicated chunks of code into functions, like start_stp, star […] is it worth the effort? this is just a ci shell script, the single user is our jenkins, it works in this state and changing it would mean another round of testing. The result is more indirection/complexity in calling some shell commands. unlikely that this is a substantial help in future maintenance. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe Gerrit-Change-Number: 29339 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 11:08:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: SMPP: move read/write callbacks to libsmpputil
by osmith 15 Sep '22

15 Sep '22

Attention is currently required from: osmith. osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28848 ) Change subject: SMPP: move read/write callbacks to libsmpputil ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76 Gerrit-Change-Number: 28848 Gerrit-PatchSet: 28 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 0

Change in osmo-msc[master]: SMPP: move read/write callbacks to libsmpputil
by msuraev 15 Sep '22

15 Sep '22

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28848 ) Change subject: SMPP: move read/write callbacks to libsmpputil ...................................................................... Patch Set 28: (1 comment) Patchset: PS28: > I also dislike flow control macro but in this case it doesn't make sense indeed. Seems like I can't remove jenkins vote: the trash icon is only visible next to my own vote. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76 Gerrit-Change-Number: 28848 Gerrit-PatchSet: 28 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 09:43:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: SMPP: move read/write callbacks to libsmpputil
by msuraev 15 Sep '22

15 Sep '22

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28848 ) Change subject: SMPP: move read/write callbacks to libsmpputil ...................................................................... Patch Set 28: Verified+1 (1 comment) Patchset: PS28: > FYI you can just override the jenkins linter error if it doesn't make sense (remove the -1 build ver […] I also dislike flow control macro but in this case it doesn't make sense indeed. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76 Gerrit-Change-Number: 28848 Gerrit-PatchSet: 28 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 09:42:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: SMPP: move read/write callbacks to libsmpputil
by osmith 15 Sep '22

15 Sep '22

Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28848 ) Change subject: SMPP: move read/write callbacks to libsmpputil ...................................................................... Patch Set 28: (1 comment) Patchset: PS28: FYI you can just override the jenkins linter error if it doesn't make sense (remove the -1 build verification vote from jenkins and add your own +1 build verification). We should probably disable the check for MACRO_WITH_FLOW_CONTROL? -> https://gerrit.osmocom.org/c/osmo-ci/+/29359 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76 Gerrit-Change-Number: 28848 Gerrit-PatchSet: 28 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 09:00:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log