Change in docker-playground[master]: add ttcn3-hnbgw-test variant with-pfcp
Attention is currently required from: osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 ) Change subject: add ttcn3-hnbgw-test variant with-pfcp ...................................................................... Patch Set 3: (1 comment) File ttcn3-hnbgw-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/29339/comment/50cc92fc_d37c... PS3, Line 82: echo Starting container with STP
It would be really great if you moved duplicated chunks of code into functions, like start_stp, star […] is it worth the effort? this is just a ci shell script, the single user is our jenkins, it works in this state and changing it would mean another round of testing. The result is more indirection/complexity in calling some shell commands. unlikely that this is a substantial help in future maintenance.
-- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe Gerrit-Change-Number: 29339 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 11:08:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
neels