- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: vty: Allow using hex representations in cmd numeric ranges
by pespin 15 Sep '22

15 Sep '22

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/19422 to look at the new patch set (#4). Change subject: vty: Allow using hex representations in cmd numeric ranges ...................................................................... vty: Allow using hex representations in cmd numeric ranges Ranges can now be specified in hexadecimal range. In this case, only hexadecimal values are accepted (prefixed with "0x"). In order to allow using a hexadecimal value as an input argument, the command must specify the range in hexadecimal form. This way all existing commands (decimal) won't get an hexadecimal value unless they are further extended in the future, avoiding hard to notice breakage due to use of stroul() without using base=0 or even worse, using atoi() directly (which only understands decimal and provides no error checking mechanism). A command argument can be expanded to accept both decimal and hex in a range by means of specifying both, example: "mycmd (<0-255>|<0x0-0xff>)". Related: OS#5631 Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 --- M src/vty/command.c M tests/vty/vty_test.c M tests/vty/vty_test.ok 3 files changed, 168 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/19422/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in docker-playground[master]: add ttcn3-hnbgw-test variant with-pfcp
by pespin 15 Sep '22

15 Sep '22

Attention is currently required from: osmith, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 ) Change subject: add ttcn3-hnbgw-test variant with-pfcp ...................................................................... Patch Set 3: (1 comment) File ttcn3-hnbgw-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/29339/comment/de962889_61b… PS3, Line 82: echo Starting container with STP It would be really great if you moved duplicated chunks of code into functions, like start_stp, start_hnbgw, start_ttcn3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe Gerrit-Change-Number: 29339 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 16:44:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: add ttcn3-hnbgw-test variant with-pfcp
by neels 15 Sep '22

15 Sep '22

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 ) Change subject: add ttcn3-hnbgw-test variant with-pfcp ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe Gerrit-Change-Number: 29339 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 16:29:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: vty: Allow using hex and octal representations in cmd numeric ranges
by pespin 15 Sep '22

15 Sep '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 ) Change subject: vty: Allow using hex and octal representations in cmd numeric ranges ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I still need to add tests for this, but sharing now in case someone wants to provide early feedback. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 14 Sep 2022 15:58:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: vty: Allow using hex and octal representations in cmd numeric ranges
by Jenkins Builder 15 Sep '22

15 Sep '22

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 ) Change subject: vty: Allow using hex and octal representations in cmd numeric ranges ...................................................................... Patch Set 3: (1 comment) File src/vty/command.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-503): https://gerrit.osmocom.org/c/libosmocore/+/19422/comment/fce93f98_f3db605a PS3, Line 1566: val = strtoul(str, &endptr,val_base); space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 14 Sep 2022 15:57:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: join ttcn3-hnbgw-test-pfcp
by neels 15 Sep '22

15 Sep '22

neels has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29357 ) Change subject: join ttcn3-hnbgw-test-pfcp ...................................................................... Abandoned accidental submission -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id0f8a01f108e39ea7d0617132d05614770e86880 Gerrit-Change-Number: 29357 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 0

Change in libosmocore[master]: vty: Allow using hex and octal representations in cmd numeric ranges
by pespin 15 Sep '22

15 Sep '22

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/19422 to look at the new patch set (#3). Change subject: vty: Allow using hex and octal representations in cmd numeric ranges ...................................................................... vty: Allow using hex and octal representations in cmd numeric ranges Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 --- M src/vty/command.c 1 file changed, 53 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/19422/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

Change in docker-playground[master]: join ttcn3-hnbgw-test-pfcp
by neels 15 Sep '22

15 Sep '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29357 ) Change subject: join ttcn3-hnbgw-test-pfcp ...................................................................... join ttcn3-hnbgw-test-pfcp Change-Id: Id0f8a01f108e39ea7d0617132d05614770e86880 --- M ttcn3-hnbgw-test/jenkins.sh A ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg A ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg 3 files changed, 155 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/57/29357/1 diff --git a/ttcn3-hnbgw-test/jenkins.sh b/ttcn3-hnbgw-test/jenkins.sh index 71a4dc6..f04a2ca 100755 --- a/ttcn3-hnbgw-test/jenkins.sh +++ b/ttcn3-hnbgw-test/jenkins.sh @@ -57,6 +57,59 @@ $DOCKER_ARGS \ $REPO_USER/ttcn3-hnbgw-test +echo Running HNBGW_Tests with PFCP enabled... + echo Stopping containers docker container kill ${BUILD_TAG}-hnbgw docker container kill ${BUILD_TAG}-stp + +echo Restarting containers for: with-pfcp + +VOL_BASE_DIR_PFCP="$VOL_BASE_DIR_PFCP/with-pfcp" +mkdir $VOL_BASE_DIR_PFCP/hnbgw-tester/unix +cp with-pfcp/HNBGW_Tests.cfg $VOL_BASE_DIR_PFCP/hnbgw-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR_PFCP/hnbgw-tester/HNBGW_Tests.cfg" + +mkdir $VOL_BASE_DIR_PFCP/stp +cp osmo-stp.cfg $VOL_BASE_DIR_PFCP/stp/ + +mkdir $VOL_BASE_DIR_PFCP/hnbgw +mkdir $VOL_BASE_DIR_PFCP/hnbgw/unix +cp with-pfcp/osmo-hnbgw.cfg $VOL_BASE_DIR/hnbgw/ + +echo Starting container with STP +docker run --rm \ + $(docker_network_params $SUBNET 200) \ + --ulimit core=-1 \ + -v $VOL_BASE_DIR/stp:/data \ + --name ${BUILD_TAG}-stp -d \ + $DOCKER_ARGS \ + $REPO_USER/osmo-stp-$IMAGE_SUFFIX + +echo Starting container with HNBGW +docker run --rm \ + $(docker_network_params $SUBNET 20) \ + --ulimit core=-1 \ + -v $VOL_BASE_DIR_PFCP/hnbgw:/data \ + -v $VOL_BASE_DIR_PFCP/unix:/data/unix \ + --name ${BUILD_TAG}-hnbgw -d \ + $DOCKER_ARGS \ + $REPO_USER/osmo-hnbgw-$IMAGE_SUFFIX + +echo Starting container with HNBGW testsuite +docker run --rm \ + $(docker_network_params $SUBNET 203) \ + --ulimit core=-1 \ + -e "TTCN3_PCAP_PATH=/data" \ + -v $VOL_BASE_DIR_PFCP/hnbgw-tester:/data \ + -v $VOL_BASE_DIR_PFCP/unix:/data/unix \ + --name ${BUILD_TAG}-ttcn3-hnbgw-test \ + $DOCKER_ARGS \ + $REPO_USER/ttcn3-hnbgw-test + +docker container kill ${BUILD_TAG}-hnbgw +docker container kill ${BUILD_TAG}-stp + +# Make jenkins results show ':with-pfcp': append ':with-pfcp' to the jenkins results classnames +sed -i "s/classname='$[^']\+$'/classname='\1:with-pfcp'/g" \ + $VOL_BASE_DIR_PFCP/hnbgw-tester/junit-xml-*.log diff --git a/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg b/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg new file mode 100644 index 0000000..d3ea553 --- /dev/null +++ b/ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg @@ -0,0 +1,49 @@ +[ORDERED_INCLUDE] +# Common configuration, shared between test suites +"/osmo-ttcn3-hacks/Common.cfg" +# testsuite specific configuration, not expected to change +"/osmo-ttcn3-hacks/hnbgw/HNBGW_Tests.default" + +# Local configuration below + +[LOGGING] + +[TESTPORT_PARAMETERS] +*.HNBGWVTY.CTRL_HOSTNAME := "172.18.35.20" + +[MODULE_PARAMETERS] +HNBGW_Tests.mp_hnodeb_ip := "172.18.35.203"; +HNBGW_Tests.mp_hnbgw_ip := "172.18.35.20"; +HNBGW_Tests.mp_mgw_ip := "172.18.35.203"; +HNBGW_Tests.mp_msc_cfg := { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23905, "172.18.35.203", 2905, "172.18.35.200" }, + own_pc := 188, /* 0.23.4 first MSC emulation */ + own_ssn := 142, + peer_pc := 189, /* 0.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 1 +}; +HNBGW_Tests.mp_sgsn_cfg := { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23906, "172.18.35.203", 2905, "172.18.35.200" }, + own_pc := 185, /* 0.23.1 first SGSN emulation */ + own_ssn := 142, + peer_pc := 189, /* 0.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 2 +}; + +HNBGW_Tests.mp_enable_pfcp_tests := true; +HNBGW_Tests.mp_pfcp_ip_local := "172.18.35.203"; +HNBGW_Tests.mp_pfcp_ip_remote := "172.18.35.20"; + + +[MAIN_CONTROLLER] + +[EXECUTE] +HNBGW_Tests.control diff --git a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg new file mode 100644 index 0000000..ce8e673 --- /dev/null +++ b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg @@ -0,0 +1,53 @@ +! +! OsmoHNBGW (1.1.0) configuration saved from vty +!! +! +log gsmtap 172.18.35.203 + logging level set-all debug + logging filter all 1 +! +log stderr + logging filter all 1 + logging color 1 + logging print category-hex 1 + logging print category 1 + logging print thread-id 0 + logging print extended-timestamp 1 + logging print file 1 + logging level set-all debug +! +line vty + no login + bind 0.0.0.0 +! +cs7 instance 0 + asp asp-clnt-msc-0 2905 2905 m3ua + local-ip 172.18.35.20 + remote-ip 172.18.35.200 + point-code 0.23.5 + sccp-address msc + routing-indicator PC + point-code 0.23.4 + sccp-address sgsn + routing-indicator PC + point-code 0.23.1 +hnbgw + log-prefix hnb-id + iuh + local-ip 172.18.35.20 + local-port 29169 + hnbap-allow-tmsi 1 + iucs + remote-addr msc + iups + remote-addr sgsn + mgcp + mgw local-ip 172.18.35.20 + mgw remote-ip 172.18.35.203 + pfcp + remote-addr 172.18.35.203 + local-addr 172.18.35.20 + # so far HNBGW_Tests.ttcn does not heed the port an Assoc Setup Req came from, it always responds to port 8805 + local-port 8805 + # send PFCP Assoc Setup Req more often + timer pfcp x26 5 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id0f8a01f108e39ea7d0617132d05614770e86880 Gerrit-Change-Number: 29357 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in docker-playground[master]: osmo-hnbgw-master: build with --enable-pfcp
by pespin 15 Sep '22

15 Sep '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29355 ) Change subject: osmo-hnbgw-master: build with --enable-pfcp ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I would really enable pfcp by default at some point near in time. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If84261cba2bf3b75c454fd5d16fd19a88a468eb7 Gerrit-Change-Number: 29355 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 15:52:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: osmo-hnbgw-master: build with --enable-pfcp
by pespin 15 Sep '22

15 Sep '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29355 ) Change subject: osmo-hnbgw-master: build with --enable-pfcp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If84261cba2bf3b75c454fd5d16fd19a88a468eb7 Gerrit-Change-Number: 29355 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 15:51:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log