- gerrit-log - lists.osmocom.org

Change in osmo-tetra[master]: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC f...
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29386 ) Change subject: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ib0967fdeef3bf37c612124626a74d240aa571a66 Gerrit-Change-Number: 29386 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Tue, 20 Sep 2022 12:11:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: add upf/ to test osmo-upf
by neels 20 Sep '22

20 Sep '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 to look at the new patch set (#3). Change subject: add upf/ to test osmo-upf ...................................................................... add upf/ to test osmo-upf So far testing only PFCP interaction without real GTP traffic. Related: SYS#5599 Change-Id: If67819dea785597841f21d8c444cb4866cfde571 --- M Makefile A upf/CPF_ConnectionHandler.ttcn A upf/README.md A upf/README.txt A upf/UPF_Tests.cfg A upf/UPF_Tests.default A upf/UPF_Tests.ttcn A upf/expected-results.xml A upf/gen_links.sh A upf/osmo-upf.cfg A upf/regen_makefile.sh 11 files changed, 1,061 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/29420/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If67819dea785597841f21d8c444cb4866cfde571 Gerrit-Change-Number: 29420 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ttcn3-hacks[master]: add upf/ to test osmo-upf
by neels 20 Sep '22

20 Sep '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 ) Change subject: add upf/ to test osmo-upf ...................................................................... Patch Set 1: (4 comments) File upf/CPF_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420/comment/3a5e0659_e0f4… PS1, Line 29: type component CPF_ConnHdlr extends StatsD_ConnHdlr { > Isn't this "CPF" an "SMF"? or is "CPF" some standaried name for a more generic thing? CPF = Control Plane Function, the generic name for entities that send PFCP requests File upf/UPF_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420/comment/eff935ee_b0f9… PS1, Line 177: private function f_parse_gtp_action(out GTP_Action ret, charstring str) return boolean { > Do we really want to have tests based on VTY output? it is the most concise way to verify that osmo-upf has the correct internal state https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420/comment/477b32f3_e1cf… PS1, Line 627: private function f_ruleset_endecaps(GTP_Action gtp) return PFCP_Ruleset > "endecaps" shounds really confusing term. encapsulation decapsulation https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420/comment/05aca102_538a… PS1, Line 635: private function f_session_est(inout PFCP_session s, PFCP_Ruleset rules) runs on CPF_ConnHdlr { > ***_establish? otherwise it's difficult to gasp whether it's a "established" checking function or ac […] This is like f_chan_est() in BSC_Tests. In PFCP, the central procedure is a PFCP Session Establishment. A checking function should have {is,check,expect} in its name see e.g. f_vty_expect_session_active() -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If67819dea785597841f21d8c444cb4866cfde571 Gerrit-Change-Number: 29420 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 11:28:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: add upf/ to test osmo-upf
by neels 20 Sep '22

20 Sep '22

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 to look at the new patch set (#2). Change subject: add upf/ to test osmo-upf ...................................................................... add upf/ to test osmo-upf So far testing only PFCP interaction without real GTP traffic. Related: SYS#5599 Change-Id: If67819dea785597841f21d8c444cb4866cfde571 --- M Makefile A upf/CPF_ConnectionHandler.ttcn A upf/README.md A upf/README.txt A upf/UPF_Tests.cfg A upf/UPF_Tests.default A upf/UPF_Tests.ttcn A upf/expected-results.xml A upf/gen_links.sh A upf/osmo-upf.cfg A upf/regen_makefile.sh 11 files changed, 1,061 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/29420/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If67819dea785597841f21d8c444cb4866cfde571 Gerrit-Change-Number: 29420 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in docker-playground[master]: Use gerrit as osmo-ttcn3-hacks.git git remote
by osmith 20 Sep '22

20 Sep '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29421 ) Change subject: Use gerrit as osmo-ttcn3-hacks.git git remote ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File ttcn3-bsc-test-vamos/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/29421/comment/71631630_783… PS1, Line 6: ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-ttcn3-hacks/+/$OSMO_TTCN3_B… /tmp/commit I wasn't sure what this points at - it's base64 encoded commit information. decoded: tree 5c189f41b84577cd12a71ccd1220da546d7c903b parent 3998c03df34c0dc1fdc99d4cb6c04e93c8fb1933 author Pau Espin Pedrol <pespin(a)sysmocom.de> 1663611817 +0200 committer Pau Espin Pedrol <pespin(a)sysmocom.de> 1663613623 +0200 bsc: Test assignment of non-AMR codec with Osmux enabled Change-Id: I31ea10963bdf61b2e070ed6ac3257b872245f724 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic87c196f8b91a3a3e6ddde2cca36482ce7070df7 Gerrit-Change-Number: 29421 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 10:21:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: ipaccess-config: Fix writing pcap output to fd=0 (stdin)
by pespin 20 Sep '22

20 Sep '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29378 ) Change subject: ipaccess-config: Fix writing pcap output to fd=0 (stdin) ...................................................................... ipaccess-config: Fix writing pcap output to fd=0 (stdin) It ended up in seeing lots of garbage in my terminal every time I run the program. Change-Id: I9ee0a4c51f4f10bf71390f884d67d87b623773df --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index a22d311..3df9f61 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -141,6 +141,7 @@ return -EINVAL; } e1inp_line_bind_ops(line, &ipaccess_e1inp_line_ops); + e1_set_pcap_fd2(line, -1); /* Disable writing to pcap */ sign_ts = e1inp_line_ipa_oml_ts(line); rsl_ts = e1inp_line_ipa_rsl_ts(line, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ee0a4c51f4f10bf71390f884d67d87b623773df Gerrit-Change-Number: 29378 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: ipacces-config: override gsm_bts_check_cfg() to void checking unset b...
by pespin 20 Sep '22

20 Sep '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29376 ) Change subject: ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration ...................................................................... ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration the shared code in libbsc checks for sane config being set, but this doesn't really apply to ipaccess-config, wihich doesn't set such config fields internally. Change-Id: I22ff0d22d6dcf9b0f715bfa4e0daeb52c4028308 --- M src/ipaccess/stubs.c M src/osmo-bsc/bts.c 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/ipaccess/stubs.c b/src/ipaccess/stubs.c index 60fa626..aaec4c5 100644 --- a/src/ipaccess/stubs.c +++ b/src/ipaccess/stubs.c @@ -30,3 +30,9 @@ /* No TS init required here. */ return true; } + +int gsm_bts_check_cfg(struct gsm_bts *bts) +{ + /* No checks required here */ + return 0; +} diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 95e7430..b7d3c3c 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -461,7 +461,7 @@ } /* Validate BTS configuration (ARFCN settings and physical channel configuration) */ -int gsm_bts_check_cfg(struct gsm_bts *bts) +__attribute__((weak)) int gsm_bts_check_cfg(struct gsm_bts *bts) { struct gsm_bts_trx *trx; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I22ff0d22d6dcf9b0f715bfa4e0daeb52c4028308 Gerrit-Change-Number: 29376 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: ipaccess: Remove unused stub
by pespin 20 Sep '22

20 Sep '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29377 ) Change subject: ipaccess: Remove unused stub ...................................................................... ipaccess: Remove unused stub function on_gsm_ts_init() doesn't exist at all in the repository, so it can be dropped from here. Change-Id: I863ccad044960d3ba267fa2bbf3c697abdf596a8 --- M src/ipaccess/stubs.c 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/ipaccess/stubs.c b/src/ipaccess/stubs.c index aaec4c5..8549397 100644 --- a/src/ipaccess/stubs.c +++ b/src/ipaccess/stubs.c @@ -1,6 +1,6 @@ /* Stubs required for linking */ -/* (C) 2018 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> +/* (C) 2018-2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> * * All Rights Reserved * @@ -19,17 +19,7 @@ * */ -#include <stdbool.h> struct gsm_bts; -struct gsm_bts_trx_ts; -struct msgb; -struct bsc_msc_data; - -bool on_gsm_ts_init(struct gsm_bts_trx_ts *ts) -{ - /* No TS init required here. */ - return true; -} int gsm_bts_check_cfg(struct gsm_bts *bts) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I863ccad044960d3ba267fa2bbf3c697abdf596a8 Gerrit-Change-Number: 29377 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: ipaccess-config: Fix writing pcap output to fd=0 (stdin)
by pespin 20 Sep '22

20 Sep '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29378 ) Change subject: ipaccess-config: Fix writing pcap output to fd=0 (stdin) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ee0a4c51f4f10bf71390f884d67d87b623773df Gerrit-Change-Number: 29378 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Sep 2022 10:16:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: ipacces-config: override gsm_bts_check_cfg() to void checking unset b...
by pespin 20 Sep '22

20 Sep '22

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29376 ) Change subject: ipacces-config: override gsm_bts_check_cfg() to void checking unset bts configuration ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I22ff0d22d6dcf9b0f715bfa4e0daeb52c4028308 Gerrit-Change-Number: 29376 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Sep 2022 10:16:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log