Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/28388
to look at the new patch set (#2).
Change subject: NOT FOR MERGE: testing gerrit job, vty tests
......................................................................
NOT FOR MERGE: testing gerrit job, vty tests
Change-Id: Ie3e38cedf0fe49330ede1fb9882a322a64d603a9
---
M contrib/jenkins.sh
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/88/28388/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28388
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ie3e38cedf0fe49330ede1fb9882a322a64d603a9
Gerrit-Change-Number: 28388
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28309 )
Change subject: implement GTP tunnel mapping via netfilter
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> the build error comes from the VTY-test, from the nftables command […]
(oh no, gerrit renders the second paragraph of a bullet point as pre)
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d319eb4f98cd51a5999c804c4203ab0bdda650
Gerrit-Change-Number: 28309
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 19 Jun 2022 12:32:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28309 )
Change subject: implement GTP tunnel mapping via netfilter
......................................................................
Patch Set 5:
(1 comment)
This change is ready for review.
Patchset:
PS5:
the build error comes from the VTY-test, from the nftables command
"add table inet osmo-upf"
happening at osmo-upf startup.
I think the reason for failure is that it requires cap_net_admin?
Could also be that the kernel is too old?
Ways to resolve:
- change osmo-upf: only dispatch "add table" the first time nftables is used.
But i think it is a good idea for production admin to verify at startup that nftables is usable.
This change would be a dumb workaround for our CI only.
- change build job:
I guess add cap_net_admin to the binary, but i thought the build job is already running as root in a docker container.
Maybe need a newer kernel??? i'll try to find out...
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d319eb4f98cd51a5999c804c4203ab0bdda650
Gerrit-Change-Number: 28309
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 19 Jun 2022 12:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 )
Change subject: add pfcp_endpoint
......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/pfcp/pfcp_endpoint.h:
https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/b6d5e571_7b47d9c4
PS3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx;
> General comment: Pointing to historical mistakes is never a good reason not to improve new code. […]
the difficulty is to distinguish between historical mistakes and established conventions,
there is no clear discussion and agreement on these things AFAICT...
https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/c1ad6694_34bc9d42
PS3, Line 104:
> We used a lot of public structs in the beginning, and my experience is that this _usually_ haunts us […]
i'll see if i can apply the extra mile without too much effort.
(this will have to happen in libosmo-pfcp.git now, where this patch accidentally already slipped into the master branch during migration)
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac
Gerrit-Change-Number: 28244
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 19 Jun 2022 12:23:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/28308
to look at the new patch set (#4).
Change subject: add osmo-upf
......................................................................
add osmo-upf
Related: SYS#5599
Change-Id: I745bcbde6859004c41ddbfd2558036bf9a2d1de2
---
A doc/examples/osmo-upf/osmo-upf-create-dev.cfg
M doc/examples/osmo-upf/osmo-upf.cfg
M include/osmocom/upf/Makefile.am
A include/osmocom/upf/up_endpoint.h
A include/osmocom/upf/up_gtp_action.h
A include/osmocom/upf/up_peer.h
A include/osmocom/upf/up_session.h
A include/osmocom/upf/up_session_to_gtp.c
M include/osmocom/upf/upf.h
A include/osmocom/upf/upf_gtp.h
A include/osmocom/upf/upf_nft.h
M src/osmo-upf/Makefile.am
M src/osmo-upf/osmo_upf_main.c
A src/osmo-upf/up_endpoint.c
A src/osmo-upf/up_gtp_action.c
A src/osmo-upf/up_peer.c
A src/osmo-upf/up_peer_fsm.c
A src/osmo-upf/up_session.c
M src/osmo-upf/upf.c
A src/osmo-upf/upf_gtp.c
A src/osmo-upf/upf_vty.c
M tests/upf.vty
22 files changed, 4,054 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/08/28308/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28308
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I745bcbde6859004c41ddbfd2558036bf9a2d1de2
Gerrit-Change-Number: 28308
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/28342
to look at the new patch set (#2).
Change subject: After RX of an SMPP Submit, send the SMS we just received.
......................................................................
After RX of an SMPP Submit, send the SMS we just received.
Previously, after we have stored the new SMS in the db, we then
signalled the queue to run, but this is not good enough.
The queue may not pick up this new SMS on the next run,
if there are sufficient older messages in the queue. So let's
specifically send the message that was just submitted.
Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c
---
M include/osmocom/msc/signal.h
M src/libmsc/gsm_04_11.c
M src/libmsc/smpp_openbsc.c
M src/libmsc/sms_queue.c
4 files changed, 43 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/42/28342/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c
Gerrit-Change-Number: 28342
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset