- gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: llc: separate enum osmo_gprs_llc_primitive to llc_prim.h
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29409 ) Change subject: llc: separate enum osmo_gprs_llc_primitive to llc_prim.h ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm also wondering what the rationale of this is. Why do we need a separate header file for just that enum? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29409 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ida9ce56f48474313064d798ea7b9a72e9b99bb8d Gerrit-Change-Number: 29409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:34:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: tests: reorganize llc/rlcmac specific dirs and files
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29408 ) Change subject: tests: reorganize llc/rlcmac specific dirs and files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8592cea020dbbf64940266cd6af14b14d34be3a6 Gerrit-Change-Number: 29408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:28:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: llc: osmo_gprs_llc_hdr_dump[_buf](): also print SAPI name
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29404 ) Change subject: llc: osmo_gprs_llc_hdr_dump[_buf](): also print SAPI name ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I95763e622bb3c3678c06901ddaecfc200d359d8d Gerrit-Change-Number: 29404 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: llc: add -export-symbols-regex '^osmo_' to CFLAGS
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29401 ) Change subject: llc: add -export-symbols-regex '^osmo_' to CFLAGS ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: did you verify manually "before" and "after" to ensure only unwanted symbols are suppressed? It might very well be that a non "osmo_" symbol was exported and got used somewhere :/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7fac3ef730ea4b2719002dd61289b22c424f43f4 Gerrit-Change-Number: 29401 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: llc: import FCS (CRC24) calculation API from osmo-sgsn.git
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29400 ) Change subject: llc: import FCS (CRC24) calculation API from osmo-sgsn.git ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ib4465c289d9ef2a1b8ef5730c559bc799bb1f012 Gerrit-Change-Number: 29400 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:26:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: llc: add definitions from 3GPP TS 44.064 section 6.4
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29399 ) Change subject: llc: add definitions from 3GPP TS 44.064 section 6.4 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6d0e1a878fb80c57a901da08798620a6ea4471a4 Gerrit-Change-Number: 29399 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:25:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-gprs[master]: llc: add missing LLE <-> (RLC/MAC,BSSGP) primitives
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: neels, pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29398 ) Change subject: llc: add missing LLE <-> (RLC/MAC,BSSGP) primitives ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmocom/gprs/llc/llc.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/29398/comment/d7c806cf_2ab1b9e8 PS2, Line 58: /* LLE <-> RLC/MAC (MS side) */ > i thought the same in previous patch: LLGMM vs LL. […] the eNUM already contains members for primitives of two multiple different SAPs, so it is logical to extend it further to cover a third one. Strictly speaking one could have separate enums for separate SAPs, but there's no reason we neccessarily need to start from 0 (new enum) for every of them... -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I10bb63220585424584185ce2bde2d9f8fd0d8342 Gerrit-Change-Number: 29398 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:25:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: abis: Avoid TCP/IPA RSL sockets continue conn establishment while shu...
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29366 ) Change subject: abis: Avoid TCP/IPA RSL sockets continue conn establishment while shutting down ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I599d074f51f490b43c9a89b105d1823391926947 Gerrit-Change-Number: 29366 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:16:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: set log level of expected code path to INFO
by laforge 20 Sep '22

20 Sep '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29416 ) Change subject: osmux: set log level of expected code path to INFO ...................................................................... osmux: set log level of expected code path to INFO Change-Id: I5caf850b7bb19c66716139512f16568d4f8459eb --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 51a4b9c..98f2639 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -303,7 +303,7 @@ mgcp_conn_dump(conn->conn)); return -1; } - LOGPCONN(conn->conn, DOSMUX, LOGL_ERROR, + LOGPCONN(conn->conn, DOSMUX, LOGL_INFO, "Osmux %s CID %u towards %s is now enabled\n", sending ? "sent" : "received", conn->osmux.cid, osmo_sockaddr_to_str(&rem_addr)); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I5caf850b7bb19c66716139512f16568d4f8459eb Gerrit-Change-Number: 29416 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-mgw[master]: osmux: set log level of expected code path to INFO
by laforge 20 Sep '22

20 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29416 ) Change subject: osmux: set log level of expected code path to INFO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I5caf850b7bb19c66716139512f16568d4f8459eb Gerrit-Change-Number: 29416 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 07:15:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log