- gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: add upf/ to test osmo-upf
by neels 21 Sep '22

21 Sep '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 ) Change subject: add upf/ to test osmo-upf ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: combine votes -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If67819dea785597841f21d8c444cb4866cfde571 Gerrit-Change-Number: 29420 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Sep 2022 01:12:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmux: Log sendto() error
by fixeria 20 Sep '22

20 Sep '22

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29424 ) Change subject: osmux: Log sendto() error ...................................................................... Patch Set 1: (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29424/comment/ff1e2b2b_bb14cafc PS1, Line 96: strerror_r > There's nothing wrong with using strerror_r, and provides more robustness in case somebody wishes to […] Well, it looks cumbersome compared to strerror(). In any case, not a merge blocker. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I195ebe0fdb05195a7f3b1390630e83084b5dea3a Gerrit-Change-Number: 29424 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 20:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmux: Log sendto() error
by pespin 20 Sep '22

20 Sep '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29424 ) Change subject: osmux: Log sendto() error ...................................................................... osmux: Log sendto() error Change-Id: I195ebe0fdb05195a7f3b1390630e83084b5dea3a --- M src/common/osmux.c 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/common/osmux.c b/src/common/osmux.c index d1d8355..e443d1d 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -78,6 +78,7 @@ struct osmux_handle *handle = data; struct gsm_bts *bts = handle->bts; socklen_t dest_len; + ssize_t rc; switch (handle->rem_addr.u.sa.sa_family) { case AF_INET6: @@ -88,8 +89,14 @@ dest_len = sizeof(handle->rem_addr.u.sin); break; } - sendto(bts->osmux.fd.fd, batch_msg->data, batch_msg->len, 0, + rc = sendto(bts->osmux.fd.fd, batch_msg->data, batch_msg->len, 0, (struct sockaddr *)&handle->rem_addr.u.sa, dest_len); + if (rc < 0) { + char errbuf[129]; + strerror_r(errno, errbuf, sizeof(errbuf)); + LOGP(DOSMUX, LOGL_ERROR, "osmux sendto(%s) failed: %s\n", + osmo_sockaddr_to_str(&handle->rem_addr), errbuf); + } msgb_free(batch_msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I195ebe0fdb05195a7f3b1390630e83084b5dea3a Gerrit-Change-Number: 29424 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: lchan: Reset Abis RTP/Osmux config during lchan release
by pespin 20 Sep '22

20 Sep '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29425 ) Change subject: lchan: Reset Abis RTP/Osmux config during lchan release ...................................................................... lchan: Reset Abis RTP/Osmux config during lchan release Otherwise some shared variables used by both Osmux and RTP was left set, like connect_ip and connect_port, and next time the lchan was selected, those were already configured even if they didn't come in IPAC CRCX. This is specially bad if the channel was reused to set up an Osmux call, since the osmux code path relied on those fields being properly reset until set by IPAC CRCX. Change-Id: I414bd0bc801451357bb45b89197a95e51b7c97f1 --- M src/common/lchan.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/common/lchan.c b/src/common/lchan.c index 892d9b7..0402c17 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -207,6 +207,8 @@ } else if (lchan->abis_ip.osmux.use) { lchan_osmux_release(lchan); } + /* reset all Abis related config: */ + memset(&lchan->abis_ip, 0, sizeof(lchan->abis_ip)); /* FIXME: right now we allow creating the rtp_socket even if chan is not * activated... Once we check for that, we can move this check at the -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I414bd0bc801451357bb45b89197a95e51b7c97f1 Gerrit-Change-Number: 29425 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: lchan: Reset Abis RTP/Osmux config during lchan release
by pespin 20 Sep '22

20 Sep '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29425 ) Change subject: lchan: Reset Abis RTP/Osmux config during lchan release ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I414bd0bc801451357bb45b89197a95e51b7c97f1 Gerrit-Change-Number: 29425 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 19:17:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmux: Log sendto() error
by pespin 20 Sep '22

20 Sep '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29424 ) Change subject: osmux: Log sendto() error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I195ebe0fdb05195a7f3b1390630e83084b5dea3a Gerrit-Change-Number: 29424 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 19:17:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmux: Log sendto() error
by pespin 20 Sep '22

20 Sep '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29424 ) Change subject: osmux: Log sendto() error ...................................................................... Patch Set 1: (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29424/comment/48e15b14_1bfdb466 PS1, Line 96: strerror_r > Why not just using strerror()? osmo-bts is single-thread, and (I hope) will unlikely be multi-thread […] There's nothing wrong with using strerror_r, and provides more robustness in case somebody wishes to move to multithread or reuse the code somewhere else. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I195ebe0fdb05195a7f3b1390630e83084b5dea3a Gerrit-Change-Number: 29424 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 19:17:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: lchan: Reset Abis RTP/Osmux config during lchan release
by fixeria 20 Sep '22

20 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29425 ) Change subject: lchan: Reset Abis RTP/Osmux config during lchan release ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I414bd0bc801451357bb45b89197a95e51b7c97f1 Gerrit-Change-Number: 29425 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 16:41:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmux: Log sendto() error
by fixeria 20 Sep '22

20 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29424 ) Change subject: osmux: Log sendto() error ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29424/comment/f979d8a3_c1897a0b PS1, Line 96: strerror_r Why not just using strerror()? osmo-bts is single-thread, and (I hope) will unlikely be multi-thread... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I195ebe0fdb05195a7f3b1390630e83084b5dea3a Gerrit-Change-Number: 29424 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 16:11:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: add upf/ to test osmo-upf
by pespin 20 Sep '22

20 Sep '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 ) Change subject: add upf/ to test osmo-upf ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File upf/expected-results.xml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420/comment/99d0c909_091b… PS3, Line 2: UPF > here it is Ah sorry I probably looked at the wrong patch version. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If67819dea785597841f21d8c444cb4866cfde571 Gerrit-Change-Number: 29420 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Sep 2022 15:38:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log