Attention is currently required from: laforge, fixeria, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22621 )
Change subject: TRXD: cosmetic: use attribute 'rotate' for 1 bit fields
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> The actual build is running inside a debian 10 image in docker: […]
Okay looks like this patch was failing before, and you expected it to pass once we move away from debian 9 and have a newer python3-blockdiag version.
Well, these builds run against debian 10 now (not 11 to ensure that we can still build the packages for debian 10 too). Debian 10 has the same python3-blockdiag version 1.5.3 as debian 9, it only gets upgraded to 2.0.1 in debian 11 and upwards: https://packages.debian.org/search?suite=default§ion=all&arch=any&searc…
So we can't merge this yet, we would break building the package on debian 10.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22621
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I604cd85f79a8c21ef536840e017e8af399e935c7
Gerrit-Change-Number: 22621
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Jul 2022 09:10:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, fixeria, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22621 )
Change subject: TRXD: cosmetic: use attribute 'rotate' for 1 bit fields
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> According to https://osmocom.org/issues/5601, we shouldn't be testing against Debian 9 anymore. […]
The actual build is running inside a debian 10 image in docker:
https://gitea.osmocom.org/osmocom/osmo-ci/src/commit/2b272e0e83906214aae86b…
But if the build passed for you locally, the failure is probably related to switching the docker image from 9 to 10. I'll look into it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22621
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I604cd85f79a8c21ef536840e017e8af399e935c7
Gerrit-Change-Number: 22621
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Jul 2022 08:38:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23633 )
Change subject: Py2 -> Py3: do not inherit classes from object
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23633
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I15003ba591510d68f3235f71526ad5d8a456088e
Gerrit-Change-Number: 23633
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 06 Jul 2022 20:07:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22621 )
Change subject: TRXD: cosmetic: use attribute 'rotate' for 1 bit fields
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
Patchset:
PS4:
According to https://osmocom.org/issues/5601, we shouldn't be testing against Debian 9 anymore. However, build verification for this patch still fails and in the console (https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-gsm-manuals/627/a1=defa…) I see "Building remotely on gtp0-deb9build (ttcn3 osmocom-gerrit-debian9 osmocom-master-debian9)". Am I missing something?
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22621
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I604cd85f79a8c21ef536840e017e8af399e935c7
Gerrit-Change-Number: 22621
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Jul 2022 20:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28527 )
Change subject: jobs/registry-update-base-images: drop old images
......................................................................
jobs/registry-update-base-images: drop old images
No need to mirror these images if we don't use them anymore.
Remove debian 8 and 9, and ubuntu zesty. The latter is the codename for
ubuntu 17.04, which is a non-LTS and was unsupported since 2018-01-13.
Related: OS#5601
Change-Id: If1c198038b0fd5faf0763172447962969448940e
---
M jobs/registry-update-base-images.yml
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml
index 328dbf6..de5c448 100644
--- a/jobs/registry-update-base-images.yml
+++ b/jobs/registry-update-base-images.yml
@@ -17,14 +17,10 @@
- shell: |
REGISTRY="registry.osmocom.org"
IMAGES="
- debian:jessie
- debian:stretch
debian:buster
debian:bullseye
debian:sid
- ubuntu:zesty
-
centos:centos7
almalinux:8
"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: If1c198038b0fd5faf0763172447962969448940e
Gerrit-Change-Number: 28527
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged