- gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: stream: Return 0 when receiving sctp notification SCTP_COMM_LOST
by pespin 30 Sep '22

30 Sep '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29545 ) Change subject: stream: Return 0 when receiving sctp notification SCTP_COMM_LOST ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/29545/comment/95689439_c01e536a PS1, Line 9: kernel > I'm not aware that we officialy support any other kernel/OS so far. Done https://gerrit.osmocom.org/c/libosmo-netif/+/29545/comment/5596ded7_b1db2ff2 PS1, Line 23: death > dead Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If94d44f25b76a96a5ea402fec9fc14c4e6296ba3 Gerrit-Change-Number: 29545 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:40:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Remove unneeded break statement
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29544 ) Change subject: stream: Remove unneeded break statement ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iaa36a3661fc3d049f656342ee6dc3aafd45498bb Gerrit-Change-Number: 29544 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:32:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Set sctp_ppid and sctp_stream when sctp notifciation is received
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29543 ) Change subject: stream: Set sctp_ppid and sctp_stream when sctp notifciation is received ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I99f6098d8d9fc1c06bc28373bf7ee76f15d5f525 Gerrit-Change-Number: 29543 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:32:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Log rx of sctp notification SCTP_SEND_FAILED
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29542 ) Change subject: stream: Log rx of sctp notification SCTP_SEND_FAILED ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I16d3ed950d4da3b13cca25bcd8f29af0d880c23e Gerrit-Change-Number: 29542 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:32:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Erase sctp_msg_flags if receiving user data
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29541 ) Change subject: stream: Erase sctp_msg_flags if receiving user data ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id358140db82b018e3973111e530834589c0b7224 Gerrit-Change-Number: 29541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:31:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Set proper msgb length when returning sctp_notification
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29540 ) Change subject: stream: Set proper msgb length when returning sctp_notification ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I95e2457498fd8e0d790d221cb97695ace0dd673e Gerrit-Change-Number: 29540 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:30:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Set proper msgb length when returning sctp_notification
by pespin 30 Sep '22

30 Sep '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29540 ) Change subject: stream: Set proper msgb length when returning sctp_notification ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > this case of sctp_notification is confusing; if it was clear, the ret from sctp_recvmsg() would retu […] No, tha wouldn't make sense. return code is >0 marking the amount of "user data" read from the conn. What we talk here (sctp_notification) is out-of-band data. The caller knowing nothing about that, aka using the API as regular recv() should not interact with that that, that's why -EAGAIN is returned when out-of-band data is received. Willing to change that would break lots of existing code. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I95e2457498fd8e0d790d221cb97695ace0dd673e Gerrit-Change-Number: 29540 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:28:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Set proper msgb length when returning sctp_notification
by neels 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29540 ) Change subject: stream: Set proper msgb length when returning sctp_notification ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: this case of sctp_notification is confusing; if it was clear, the ret from sctp_recvmsg() would return the size of the union sctp_notification, and we would always msgb_put() if rc > 0, and not use sizeof(). Do you think that could work / makes sense / have you tried that? 'man sctp_recvmsg' is a very short joke; would be nice to have the relation of ret, flags and sizeof explained by in-code comments, at least what we assume to be true. if there's anything you can improve, that would be welcome. File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29540/comment/9d76d392_ac28d363 PS1, Line 1563: msgb_put(msg, ret); > This is the generic and regular place where user data content is updated in the msgb, so it's fine h […] i understand now that this is needed here for the recv() case. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I95e2457498fd8e0d790d221cb97695ace0dd673e Gerrit-Change-Number: 29540 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:23:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Erase sctp_msg_flags if receiving user data
by pespin 30 Sep '22

30 Sep '22

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29541 ) Change subject: stream: Erase sctp_msg_flags if receiving user data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > ah! now i understand, this is about clearing previous state in a msgb passed in from the caller. […] Not sure what you mean. The function doesn't touch any of those l1234h header, it just puts data at the end of the msgb. It's freedom of the caller to prepare the msgb as he wants regarding where data read is to be stored. In any case, that's a separate topic. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id358140db82b018e3973111e530834589c0b7224 Gerrit-Change-Number: 29541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:17:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: stream: Erase sctp_msg_flags if receiving user data
by neels 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29541 ) Change subject: stream: Erase sctp_msg_flags if receiving user data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: ah! now i understand, this is about clearing previous state in a msgb passed in from the caller. I completely failed to understand that from the commit log. In that case, how about the msgb->head, ->tail, ->data state, the l[1234]h, all of that might be completely messed up in the msgb provided by the caller, and by writing into the msgb data buffer none of them are accurate anymore. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id358140db82b018e3973111e530834589c0b7224 Gerrit-Change-Number: 29541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:01:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log