- gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: Fix handling of sctp SCTP_SHUTDOWN_EVENT notification
by pespin 30 Sep '22

30 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29546 ) Change subject: Fix handling of sctp SCTP_SHUTDOWN_EVENT notification ...................................................................... Fix handling of sctp SCTP_SHUTDOWN_EVENT notification SCTP_SHUTDOWN_EVENT is a first class event, and not a subtype of SCTP_ASSOC_CHANGE (such as SCTP_SHUTDOWN_COMP). Related: SYS#6113 Change-Id: I7fa648142c07f63c55091d2a15b9d7312bcd4cec --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/46/29546/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 6d75525..0c59c7d 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -262,15 +262,15 @@ LOGHNB(hnb, DMAIN, LOGL_NOTICE, "HNB SCTP conn RESTARTed, marking as HNBAP-unregistered\n"); hnb->hnb_registered = false; break; - case SCTP_SHUTDOWN_EVENT: - LOGHNB(hnb, DMAIN, LOGL_NOTICE, - "sctp_recvmsg(%s) = SCTP_SHUTDOWN_EVENT, closing conn\n", - osmo_sock_get_name2(osmo_stream_srv_get_ofd(conn)->fd)); - osmo_stream_srv_destroy(conn); - rc = -1; - break; } break; + case SCTP_SHUTDOWN_EVENT: + LOGHNB(hnb, DMAIN, LOGL_NOTICE, + "sctp_recvmsg(%s) = SCTP_SHUTDOWN_EVENT, closing conn\n", + osmo_sock_get_name2(osmo_stream_srv_get_ofd(conn)->fd)); + osmo_stream_srv_destroy(conn); + rc = -1; + break; } goto out; } else if (rc == -EAGAIN) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7fa648142c07f63c55091d2a15b9d7312bcd4cec Gerrit-Change-Number: 29546 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-netif[master]: stream: Return 0 when receiving sctp notification SCTP_COMM_LOST
by pespin 30 Sep '22

30 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29545 ) Change subject: stream: Return 0 when receiving sctp notification SCTP_COMM_LOST ...................................................................... stream: Return 0 when receiving sctp notification SCTP_COMM_LOST It was seen on a real pcap trace (sctp & gsmtap_log) that the kernel stack may decide to kill the connection (sending an ABORT) if it fails to transmit some data after a while: ABORT Cause code: "Protocol violation (0x000d)", Cause Information: "Association exceeded its max_retrans count". When this occurs, the kernel sends the MSG_NOTIFICATION,SCTP_ASSOC_CHANGE,SCTP_COMM_LOST notification when reading from the socket with sctp_recvmsg(). This basically signals that the socket conn is death, and subsequent writes to it will result in send() failures (and receive SCTP_SEND_FAILED notification upon follow up reads). It's important to notice that after those events, there's no other sort of different event like SHUTDOWN coming in, so that's the time at which we must tell the user to close the socket. Hence, let's signal the caller that the socket is death by returning 0, to comply with usual recv() API. Related: SYS#6113 Change-Id: If94d44f25b76a96a5ea402fec9fc14c4e6296ba3 --- M src/stream.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/45/29545/1 diff --git a/src/stream.c b/src/stream.c index 5e15142..38d24fe 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1490,7 +1490,8 @@ break; case SCTP_COMM_LOST: LOGPC(DLINP, LOGL_DEBUG, " LOST\n"); - break; + /* Handle this like a regular disconnect */ + return 0; case SCTP_RESTART: LOGPC(DLINP, LOGL_DEBUG, " RESTART\n"); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If94d44f25b76a96a5ea402fec9fc14c4e6296ba3 Gerrit-Change-Number: 29545 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-netif[master]: stream: Remove unneeded break statement
by pespin 30 Sep '22

30 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29544 ) Change subject: stream: Remove unneeded break statement ...................................................................... stream: Remove unneeded break statement Change-Id: Iaa36a3661fc3d049f656342ee6dc3aafd45498bb --- M src/stream.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/44/29544/1 diff --git a/src/stream.c b/src/stream.c index 604955b..5e15142 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1512,7 +1512,6 @@ LOGP(DLINP, LOGL_DEBUG, "===> SHUTDOWN EVT\n"); /* Handle this like a regular disconnect */ return 0; - break; } return -EAGAIN; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iaa36a3661fc3d049f656342ee6dc3aafd45498bb Gerrit-Change-Number: 29544 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-netif[master]: stream: Log rx of sctp notification SCTP_SEND_FAILED
by pespin 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/29542 to look at the new patch set (#2). Change subject: stream: Log rx of sctp notification SCTP_SEND_FAILED ...................................................................... stream: Log rx of sctp notification SCTP_SEND_FAILED Change-Id: I16d3ed950d4da3b13cca25bcd8f29af0d880c23e --- M src/stream.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/42/29542/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I16d3ed950d4da3b13cca25bcd8f29af0d880c23e Gerrit-Change-Number: 29542 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-netif[master]: stream: Set sctp_ppid and sctp_stream when sctp notifciation is received
by pespin 30 Sep '22

30 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29543 ) Change subject: stream: Set sctp_ppid and sctp_stream when sctp notifciation is received ...................................................................... stream: Set sctp_ppid and sctp_stream when sctp notifciation is received Let's set these values in all cases. Change-Id: I99f6098d8d9fc1c06bc28373bf7ee76f15d5f525 --- M src/stream.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/43/29543/1 diff --git a/src/stream.c b/src/stream.c index 383103c..604955b 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1474,6 +1474,8 @@ ret = sctp_recvmsg(fd, msgb_data(msg), msgb_tailroom(msg), NULL, NULL, &sinfo, &flags); msgb_sctp_msg_flags(msg) = 0; + msgb_sctp_ppid(msg) = ntohl(sinfo.sinfo_ppid); + msgb_sctp_stream(msg) = sinfo.sinfo_stream; if (flags & MSG_NOTIFICATION) { union sctp_notification *notif = (union sctp_notification *)msgb_data(msg); LOGP(DLINP, LOGL_DEBUG, "NOTIFICATION %u flags=0x%x\n", notif->sn_header.sn_type, notif->sn_header.sn_flags); @@ -1514,8 +1516,6 @@ } return -EAGAIN; } - msgb_sctp_ppid(msg) = ntohl(sinfo.sinfo_ppid); - msgb_sctp_stream(msg) = sinfo.sinfo_stream; return ret; } #endif -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I99f6098d8d9fc1c06bc28373bf7ee76f15d5f525 Gerrit-Change-Number: 29543 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-netif[master]: stream: Log rx of sctp notification SCTP_SEND_FAILED
by pespin 30 Sep '22

30 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29542 ) Change subject: stream: Log rx of sctp notification SCTP_SEND_FAILED ...................................................................... stream: Log rx of sctp notification SCTP_SEND_FAILED Change-Id: I16d3ed950d4da3b13cca25bcd8f29af0d880c23e --- M src/stream.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/42/29542/1 diff --git a/src/stream.c b/src/stream.c index 78238b6..dc80ee6 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1500,6 +1500,9 @@ break; } break; + case case SCTP_SEND_FAILED: + LOGP(DLINP, LOGL_DEBUG, "===> SEND FAILED\n"); + break; case SCTP_PEER_ADDR_CHANGE: LOGP(DLINP, LOGL_DEBUG, "===> PEER ADDR CHANGE\n"); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I16d3ed950d4da3b13cca25bcd8f29af0d880c23e Gerrit-Change-Number: 29542 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-netif[master]: stream: Set proper msgb length when returning sctp_notification
by pespin 30 Sep '22

30 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29540 ) Change subject: stream: Set proper msgb length when returning sctp_notification ...................................................................... stream: Set proper msgb length when returning sctp_notification This allows the user to properly check the size of the content in case the struct ABI changes. -EAGAIN is still returned to avoid older users of the API reading SCTP notifications as user data. Change-Id: I95e2457498fd8e0d790d221cb97695ace0dd673e --- M src/stream.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/40/29540/1 diff --git a/src/stream.c b/src/stream.c index b45b730..31aecc4 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1476,6 +1476,7 @@ if (flags & MSG_NOTIFICATION) { union sctp_notification *notif = (union sctp_notification *)msgb_data(msg); LOGP(DLINP, LOGL_DEBUG, "NOTIFICATION %u flags=0x%x\n", notif->sn_header.sn_type, notif->sn_header.sn_flags); + msgb_put(msg, sizeof(union sctp_notification)); msgb_sctp_msg_flags(msg) = OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION; switch (notif->sn_header.sn_type) { case SCTP_ASSOC_CHANGE: -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I95e2457498fd8e0d790d221cb97695ace0dd673e Gerrit-Change-Number: 29540 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-netif[master]: stream: Erase sctp_msg_flags if receiving user data
by pespin 30 Sep '22

30 Sep '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29541 ) Change subject: stream: Erase sctp_msg_flags if receiving user data ...................................................................... stream: Erase sctp_msg_flags if receiving user data It could be that the user reuses the msgb passed to osmo_stream_srv_recv() all the time, hence we need to reset the flags, otherwise it may end up being set forever. Change-Id: Id358140db82b018e3973111e530834589c0b7224 --- M src/stream.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/41/29541/1 diff --git a/src/stream.c b/src/stream.c index 31aecc4..78238b6 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1473,6 +1473,7 @@ ret = sctp_recvmsg(fd, msgb_data(msg), msgb_tailroom(msg), NULL, NULL, &sinfo, &flags); + msgb_sctp_msg_flags(msg) = 0; if (flags & MSG_NOTIFICATION) { union sctp_notification *notif = (union sctp_notification *)msgb_data(msg); LOGP(DLINP, LOGL_DEBUG, "NOTIFICATION %u flags=0x%x\n", notif->sn_header.sn_type, notif->sn_header.sn_flags); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id358140db82b018e3973111e530834589c0b7224 Gerrit-Change-Number: 29541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-mgw[master]: Allocate struct osmux_in_handle through new libosmo-netif APIs
by pespin 30 Sep '22

30 Sep '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29526 ) Change subject: Allocate struct osmux_in_handle through new libosmo-netif APIs ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29526/comment/ee7f8f0a_e14bc3a4 PS1, Line 147: TALLOC_FREE(h->in); > same question here. […] https://gerrit.osmocom.org/c/osmo-bts/+/29530/comment/f901ae75_6ee24e10/ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I013c99d1f915279684ce278648e9c69e39b94266 Gerrit-Change-Number: 29526 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:48:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: Allocate struct osmux_in_handle through new libosmo-netif APIs
by pespin 30 Sep '22

30 Sep '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29530 ) Change subject: Allocate struct osmux_in_handle through new libosmo-netif APIs ...................................................................... Patch Set 1: (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29530/comment/d20ad901_8a96fc80 PS1, Line 141: TALLOC_FREE > why uppercase? Don't recall having seen this before... […] it's a standard talloc API (define) and already used in several places. It calls talloc_free and sets the pointer to NULL. I know the h structure is being freed immediately afterwards, but I prefer setting this as NULL in order to avoid weird accesses in the future in case there's some talloc destructor set in the parent "h" structure. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I132a7c03213cb20dfe118616c8cfd7032b075507 Gerrit-Change-Number: 29530 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:48:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log