- gerrit-log - lists.osmocom.org

Change in osmo-gbproxy[master]: implement LL DISCARD with second BVCI
by laforge 30 Sep '22

30 Sep '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29508 ) Change subject: implement LL DISCARD with second BVCI ...................................................................... implement LL DISCARD with second BVCI Needs TTCN3 tests Depends: libosmocore I76dc3b08a63cfd78c9f7657fb58c2ddfa9b4b7e2 Change-Id: Iaa488ee8ac3d85b86c0f360d9d6440f7cda82230 --- M src/gb_proxy.c 1 file changed, 40 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/gb_proxy.c b/src/gb_proxy.c index b4a53bc..488ef91 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -1414,7 +1414,8 @@ struct gbproxy_bvc *sgsn_bvc; struct tlv_parsed tp[2]; int data_len; - uint16_t bvci; + uint16_t bvci, bvci2; + uint32_t tlli; char log_pfx[32]; int rc = 0; int i; @@ -1483,17 +1484,51 @@ rc = osmo_fsm_inst_dispatch(sgsn_bvc->fi, BSSGP_BVCFSM_E_RX_UNBLOCK_ACK, msg); break; case BSSGP_PDUT_FLUSH_LL: - /* TODO: If new BVCI is on different NSE we should remove the new BVCI so the - * message is interpreted as a request to delete the PDUs, not forward them. - * If we negotiate Inter-NSE re-routing or LCS-procedures we can also + /* TODO: If we negotiate Inter-NSE re-routing or LCS-procedures we can also * add the NSEI TLV to trigger re-routing the PDUs */ /* simple case: BVCI IE is mandatory */ bvci = ntohs(tlvp_val16_unal(&tp[0], BSSGP_IE_BVCI)); sgsn_bvc = gbproxy_bvc_by_bvci(nse, bvci); if (!sgsn_bvc) goto err_no_bvc; - if (sgsn_bvc->cell && sgsn_bvc->cell->bss_bvc) + + /* bvc is not valid */ + if (!sgsn_bvc->cell || !sgsn_bvc->cell->bss_bvc) { + rc = -EINVAL; + break; + } + + /* When both the old and new BVCI is present: + * If old & new BVCI is on the same NSEI, forward message as is, + * otherwise remove new BVCI. */ + if (TLVP_PRESENT(&tp[1], BSSGP_IE_BVCI)) { + struct gbproxy_bvc *bvc2; + struct msgb *flush; + + bvci2 = ntohs(tlvp_val16_unal(&tp[1], BSSGP_IE_BVCI)); + bvc2 = gbproxy_bvc_by_bvci(nse, bvci2); + + /* it's the same NSEI, we can pass the message as is */ + if (bvc2->nse == sgsn_bvc->nse) { + rc = gbprox_relay2peer(msg, sgsn_bvc->cell->bss_bvc, ns_bvci); + break; + } + + tlli = osmo_load32be(TLVP_VAL(&tp[0], BSSGP_IE_TLLI)); + /* build a new message in order to drop the old one */ + flush = bssgp2_enc_flush_ll(tlli, bvci, NULL, NULL); + if (!flush) { + /* TODO: error message */ + rc = -ENOMEM; + break; + } + + DEBUGP(DGPRS, "NSE(%05u/%s)-BVC(%05u/??) proxying to NSE(%05u/%s)\n", msgb_nsei(msg), + !nse->sgsn_facing ? "SGSN" : "BSS", ns_bvci, nse->nsei, nse->sgsn_facing ? "SGSN" : "BSS"); + rc = bssgp2_nsi_tx_ptp(nse->cfg->nsi, nse->nsei, ns_bvci, flush, tlli); + } else { rc = gbprox_relay2peer(msg, sgsn_bvc->cell->bss_bvc, ns_bvci); + } break; case BSSGP_PDUT_DUMMY_PAGING_PS: /* Routing area is optional in dummy paging and we have nothing else to go by -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Iaa488ee8ac3d85b86c0f360d9d6440f7cda82230 Gerrit-Change-Number: 29508 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-gbproxy[master]: implement LL DISCARD with second BVCI
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29508 ) Change subject: implement LL DISCARD with second BVCI ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Iaa488ee8ac3d85b86c0f360d9d6440f7cda82230 Gerrit-Change-Number: 29508 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:38:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: osmux: Replace deprecated osmux_xfrm_input_* APIs in examples & tests
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29529 ) Change subject: osmux: Replace deprecated osmux_xfrm_input_* APIs in examples & tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7f3f8d40f89ffdd135a73316ee60fd429ba2a5b0 Gerrit-Change-Number: 29529 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:37:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: osmux: Allocate struct osmux_out_handle through API
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29528 ) Change subject: osmux: Allocate struct osmux_out_handle through API ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I752ab031f935f04731bb1a354333f1682a1aa5bd Gerrit-Change-Number: 29528 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:37:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: tests/osmo-pcap/osmux: Replace deprecatd API osmux_xfrm_output_init2()
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29527 ) Change subject: tests/osmo-pcap/osmux: Replace deprecatd API osmux_xfrm_output_init2() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/29527/comment/ebb328fe_0de5f902 PS1, Line 7: deprecatd spelling -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia0958dfae951d82feafe427eff2112d327d3b0a4 Gerrit-Change-Number: 29527 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:36:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: osmux: Split input and output code into separate files
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29524 ) Change subject: osmux: Split input and output code into separate files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia72995092a36ca50147611e617cb88c4dcf231d5 Gerrit-Change-Number: 29524 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:36:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-netif[master]: cosmetic: osmux: Make linter happy
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29525 ) Change subject: cosmetic: osmux: Make linter happy ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I8472e1b508babfa231c7e0ecc75b4fe63e090a0d Gerrit-Change-Number: 29525 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:36:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: Drop logging of osmux internal counters
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29531 ) Change subject: osmux: Drop logging of osmux internal counters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I853e118f843070ea29b19e1b0fe56b52f267437a Gerrit-Change-Number: 29531 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:34:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: Allocate struct osmux_in_handle through new libosmo-netif APIs
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29526 ) Change subject: Allocate struct osmux_in_handle through new libosmo-netif APIs ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29526/comment/3a323bcd_93d4db20 PS1, Line 147: TALLOC_FREE(h->in); same question here. Why use a macro in the line here but the function call in the line below ?!? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I013c99d1f915279684ce278648e9c69e39b94266 Gerrit-Change-Number: 29526 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:34:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-mgw[master]: osmux: Keep decoding osmux pkt if a batch contains an unknown CID
by laforge 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29535 ) Change subject: osmux: Keep decoding osmux pkt if a batch contains an unknown CID ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I315949853bdcc07bef15d2e8579029cc72c427cf Gerrit-Change-Number: 29535 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:31:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log