- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: coverity/prepare_source_Osmocom.sh: execute with '-xe'
by pespin 03 Oct '22

03 Oct '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29553 ) Change subject: coverity/prepare_source_Osmocom.sh: execute with '-xe' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 Gerrit-Change-Number: 29553 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:32:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present
by keith 03 Oct '22

03 Oct '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 to look at the new patch set (#2). Change subject: Set MNCC_F_GCR field when the gcr is present ...................................................................... Set MNCC_F_GCR field when the gcr is present Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the MNCC field flag MNCC_F_GCR should be set when the GCR is present, but did not set it. Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692 --- M src/mncc.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/60/29560/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692 Gerrit-Change-Number: 29560 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present
by keith 03 Oct '22

03 Oct '22

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 ) Change subject: Set MNCC_F_GCR field when the gcr is present ...................................................................... Set MNCC_F_GCR field when the gcr is present Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the MNCC field flag MNCC_F_GCR should be set when the GCR is present, but did not set it. Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692 --- M src/mncc.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/60/29560/1 diff --git a/src/mncc.c b/src/mncc.c index f302b3e..ddc1ae6 100644 --- a/src/mncc.c +++ b/src/mncc.c @@ -936,10 +936,13 @@ /* Encode the Global Call Reference (if present) */ if (call->gcr_present) { msg = msgb_alloc(sizeof(mncc.gcr), "MNCC GCR"); - if (msg == NULL || (rc = osmo_enc_gcr(msg, &call->gcr)) == 0) + if (msg == NULL || (rc = osmo_enc_gcr(msg, &call->gcr)) == 0) { LOGP(DMNCC, LOGL_ERROR, "MNCC leg(%u) failed to encode GCR\n", call->id); - else + } else { memcpy(&mncc.gcr[0], msg->data, rc); + mncc.fields |= MNCC_F_GCR; + } + msgb_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692 Gerrit-Change-Number: 29560 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

1 0

Change in osmo-msc[master]: Update MNCC field validation mask.
by keith 03 Oct '22

03 Oct '22

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/29559 ) Change subject: Update MNCC field validation mask. ...................................................................... Update MNCC field validation mask. In c6921e5068ba62cde67707fb3c8103919d1e0c0e, 0x4000 was added to the possible MNCC field flags, but before this commit, using it would result in an ERROR of "Unknown MNCC field mask 0x....." Related: #OS5282 Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d --- M src/libmsc/mncc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/59/29559/1 diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c index 0a38997..f446f98 100644 --- a/src/libmsc/mncc.c +++ b/src/libmsc/mncc.c @@ -110,7 +110,7 @@ * MNCC validation code. Move to libosmocore once headers are merged ************************************************************************/ -#define MNCC_F_ALL 0x3fff +#define MNCC_F_ALL 0x7fff static int check_string_terminated(const char *str, unsigned int size) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d Gerrit-Change-Number: 29559 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: pcu: osmo-pcu.cfg: update GSMTAP Um logging configuration
by fixeria 02 Oct '22

02 Oct '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29558 ) Change subject: pcu: osmo-pcu.cfg: update GSMTAP Um logging configuration ...................................................................... pcu: osmo-pcu.cfg: update GSMTAP Um logging configuration Change-Id: Ia53f59da04fd30f055ee3a6a46e9afb5ecd48162 --- M pcu/osmo-pcu.cfg 1 file changed, 2 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/29558/1 diff --git a/pcu/osmo-pcu.cfg b/pcu/osmo-pcu.cfg index 31f8cda..f33dfd8 100644 --- a/pcu/osmo-pcu.cfg +++ b/pcu/osmo-pcu.cfg @@ -32,17 +32,5 @@ gamma 0 pcu-socket /tmp/pcu_bts neighbor resolution 127.0.0.1 - gsmtap-category dl-unknown - gsmtap-category dl-dummy - gsmtap-category dl-ctrl - gsmtap-category dl-data-gprs - gsmtap-category dl-data-egprs - gsmtap-category dl-ptcch - gsmtap-category dl-agch - gsmtap-category dl-pch - gsmtap-category ul-unknown - gsmtap-category ul-dummy - gsmtap-category ul-ctrl - gsmtap-category ul-data-gprs - gsmtap-category ul-data-egprs - gsmtap-category ul-rach + gsmtap-remote-host 127.0.0.1 + gsmtap-category enable-all -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia53f59da04fd30f055ee3a6a46e9afb5ecd48162 Gerrit-Change-Number: 29558 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in docker-playground[master]: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-category enable-all'
by fixeria 02 Oct '22

02 Oct '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29556 ) Change subject: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-category enable-all' ...................................................................... ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-category enable-all' Change-Id: I19fbb75890935a338c31b7eb5e624ec988f91468 --- M ttcn3-pcu-test/osmo-pcu.cfg 1 file changed, 1 insertion(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/56/29556/1 diff --git a/ttcn3-pcu-test/osmo-pcu.cfg b/ttcn3-pcu-test/osmo-pcu.cfg index 733cebe..cde87b4 100644 --- a/ttcn3-pcu-test/osmo-pcu.cfg +++ b/ttcn3-pcu-test/osmo-pcu.cfg @@ -32,17 +32,4 @@ alpha 0 gamma 0 pcu-socket /data/unix/pcu_bts - gsmtap-category dl-unknown - gsmtap-category dl-dummy - gsmtap-category dl-ctrl - gsmtap-category dl-data-gprs - gsmtap-category dl-data-egprs - gsmtap-category dl-ptcch - gsmtap-category dl-agch - gsmtap-category dl-pch - gsmtap-category ul-unknown - gsmtap-category ul-dummy - gsmtap-category ul-ctrl - gsmtap-category ul-data-gprs - gsmtap-category ul-data-egprs - gsmtap-category ul-rach + gsmtap-category enable-all -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19fbb75890935a338c31b7eb5e624ec988f91468 Gerrit-Change-Number: 29556 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in docker-playground[master]: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-remote-host'
by fixeria 02 Oct '22

02 Oct '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29557 ) Change subject: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-remote-host' ...................................................................... ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-remote-host' Change-Id: Ib7d6e564e12db08a8dd4890426d2599b3260fa9d --- M ttcn3-pcu-test/jenkins.sh M ttcn3-pcu-test/osmo-pcu.cfg 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/57/29557/1 diff --git a/ttcn3-pcu-test/jenkins.sh b/ttcn3-pcu-test/jenkins.sh index dd5b924..4c0455d 100755 --- a/ttcn3-pcu-test/jenkins.sh +++ b/ttcn3-pcu-test/jenkins.sh @@ -32,7 +32,7 @@ --name ${BUILD_TAG}-pcu -d \ $DOCKER_ARGS \ $REPO_USER/osmo-pcu-$IMAGE_SUFFIX \ - /bin/sh -c "/usr/local/bin/respawn.sh osmo-pcu -c /data/osmo-pcu.cfg -i 172.18.13.10 >>/data/osmo-pcu.log 2>&1" + /bin/sh -c "/usr/local/bin/respawn.sh osmo-pcu -c /data/osmo-pcu.cfg >>/data/osmo-pcu.log 2>&1" echo Starting container with PCU testsuite docker run --rm \ diff --git a/ttcn3-pcu-test/osmo-pcu.cfg b/ttcn3-pcu-test/osmo-pcu.cfg index cde87b4..4031e26 100644 --- a/ttcn3-pcu-test/osmo-pcu.cfg +++ b/ttcn3-pcu-test/osmo-pcu.cfg @@ -32,4 +32,5 @@ alpha 0 gamma 0 pcu-socket /data/unix/pcu_bts + gsmtap-remote-host 172.18.13.10 gsmtap-category enable-all -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29557 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib7d6e564e12db08a8dd4890426d2599b3260fa9d Gerrit-Change-Number: 29557 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-hnbgw[master]: hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-...
by pespin 01 Oct '22

01 Oct '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29549 ) Change subject: hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-after-free ...................................................................... hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-after-free Otherwise the libosmo-netif stream API may continue accessing the conn after returning if the socket has the WRITE flag active in the same main loop iteration. Change-Id: I628c59a88d94d299f432f405b37fbe602381d47e --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index b824dd3..38d33eb 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -264,7 +264,7 @@ "sctp_recvmsg(%s) = SCTP_COMM_LOST, closing conn\n", osmo_sock_get_name2(ofd->fd)); osmo_stream_srv_destroy(conn); - rc = -1; + rc = -EBADF; break; case SCTP_RESTART: LOGHNB(hnb, DMAIN, LOGL_NOTICE, "HNB SCTP conn RESTARTed, marking as HNBAP-unregistered\n"); @@ -277,7 +277,7 @@ "sctp_recvmsg(%s) = SCTP_SHUTDOWN_EVENT, closing conn\n", osmo_sock_get_name2(ofd->fd)); osmo_stream_srv_destroy(conn); - rc = -1; + rc = -EBADF; break; } goto out; @@ -291,12 +291,13 @@ LOGHNB(hnb, DMAIN, LOGL_ERROR, "Error during sctp_recvmsg(%s)\n", osmo_sock_get_name2(ofd->fd)); osmo_stream_srv_destroy(conn); + rc = -EBADF; goto out; } else if (rc == 0) { LOGHNB(hnb, DMAIN, LOGL_NOTICE, "Connection closed sctp_recvmsg(%s) = 0\n", osmo_sock_get_name2(ofd->fd)); osmo_stream_srv_destroy(conn); - rc = -1; + rc = -EBADF; goto out; } else { msgb_put(msg, rc); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I628c59a88d94d299f432f405b37fbe602381d47e Gerrit-Change-Number: 29549 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: Close conn when receiving SCTP_ASSOC_CHANGE notification
by pespin 01 Oct '22

01 Oct '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547 ) Change subject: Close conn when receiving SCTP_ASSOC_CHANGE notification ...................................................................... Close conn when receiving SCTP_ASSOC_CHANGE notification It was seen on a real pcap trace (sctp & gsmtap_log) that the kernel stack may decide to kill the connection (sending an ABORT) if it fails to transmit some data after a while: ABORT Cause code: "Protocol violation (0x000d)", Cause Information: "Association exceeded its max_retrans count". When this occurs, the kernel sends the MSG_NOTIFICATION,SCTP_ASSOC_CHANGE,SCTP_COMM_LOST notification when reading from the socket with sctp_recvmsg(). This basically signals that the socket conn is dead, and subsequent writes to it will result in send() failures (and receive SCTP_SEND_FAILED notification upon follow up reads). It's important to notice that after those events, there's no other sort of different event like SHUTDOWN coming in, so that's the time at which we must tell the user to close the socket. Hence, let's signal the caller that the socket is dead by returning 0, to comply with usual recv() API. Related: SYS#6113 Change-Id: If35efd404405f926a4a6cc45862eeadd1b04e08c --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 0c59c7d..dd0999c 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -258,6 +258,13 @@ switch (notif->sn_header.sn_type) { case SCTP_ASSOC_CHANGE: switch (notif->sn_assoc_change.sac_state) { + case SCTP_COMM_LOST: + LOGHNB(hnb, DMAIN, LOGL_NOTICE, + "sctp_recvmsg(%s) = SCTP_COMM_LOST, closing conn\n", + osmo_sock_get_name2(osmo_stream_srv_get_ofd(conn)->fd)); + osmo_stream_srv_destroy(conn); + rc = -1; + break; case SCTP_RESTART: LOGHNB(hnb, DMAIN, LOGL_NOTICE, "HNB SCTP conn RESTARTed, marking as HNBAP-unregistered\n"); hnb->hnb_registered = false; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If35efd404405f926a4a6cc45862eeadd1b04e08c Gerrit-Change-Number: 29547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-hnbgw[master]: hnb_read_cb: use local var to reduce get_ofd() calls
by pespin 01 Oct '22

01 Oct '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29548 ) Change subject: hnb_read_cb: use local var to reduce get_ofd() calls ...................................................................... hnb_read_cb: use local var to reduce get_ofd() calls Change-Id: Ic7058b5a05b0d34b80617006d4e929a523212221 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index dd0999c..b824dd3 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -239,6 +239,7 @@ static int hnb_read_cb(struct osmo_stream_srv *conn) { struct hnb_context *hnb = osmo_stream_srv_get_data(conn); + struct osmo_fd *ofd = osmo_stream_srv_get_ofd(conn); struct msgb *msg = msgb_alloc(IUH_MSGB_SIZE, "Iuh rx"); int rc; @@ -261,7 +262,7 @@ case SCTP_COMM_LOST: LOGHNB(hnb, DMAIN, LOGL_NOTICE, "sctp_recvmsg(%s) = SCTP_COMM_LOST, closing conn\n", - osmo_sock_get_name2(osmo_stream_srv_get_ofd(conn)->fd)); + osmo_sock_get_name2(ofd->fd)); osmo_stream_srv_destroy(conn); rc = -1; break; @@ -274,7 +275,7 @@ case SCTP_SHUTDOWN_EVENT: LOGHNB(hnb, DMAIN, LOGL_NOTICE, "sctp_recvmsg(%s) = SCTP_SHUTDOWN_EVENT, closing conn\n", - osmo_sock_get_name2(osmo_stream_srv_get_ofd(conn)->fd)); + osmo_sock_get_name2(ofd->fd)); osmo_stream_srv_destroy(conn); rc = -1; break; @@ -288,12 +289,12 @@ goto out; } else if (rc < 0) { LOGHNB(hnb, DMAIN, LOGL_ERROR, "Error during sctp_recvmsg(%s)\n", - osmo_sock_get_name2(osmo_stream_srv_get_ofd(conn)->fd)); + osmo_sock_get_name2(ofd->fd)); osmo_stream_srv_destroy(conn); goto out; } else if (rc == 0) { LOGHNB(hnb, DMAIN, LOGL_NOTICE, "Connection closed sctp_recvmsg(%s) = 0\n", - osmo_sock_get_name2(osmo_stream_srv_get_ofd(conn)->fd)); + osmo_sock_get_name2(ofd->fd)); osmo_stream_srv_destroy(conn); rc = -1; goto out; 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic7058b5a05b0d34b80617006d4e929a523212221 Gerrit-Change-Number: 29548 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log