- gerrit-log - lists.osmocom.org

Change in osmo-trx[master]: configure.ac: enable-werror: add -Wno-error=psabi
by osmith 11 Jul '22

11 Jul '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28556 ) Change subject: configure.ac: enable-werror: add -Wno-error=psabi ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hm, this build passed on arm without having the patch merged. So Pau is right, this is just a note and doesn't stop the build. https://jenkins.osmocom.org/jenkins/job/master-osmo-trx/INSTR=--with-neon-v… (Maybe it ran out of RAM where the build was stopped?) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4497ba8f71215284df33c48c18864e1058520723 Gerrit-Change-Number: 28556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 11:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-trx[master]: configure.ac: enable-werror: add -Wno-error=psabi
by osmith 11 Jul '22

11 Jul '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28556 ) Change subject: configure.ac: enable-werror: add -Wno-error=psabi ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Are you sure this is what's making gcc to stop? Because I see it is a "note", not a "warning", and I […] I wasn't 100% sure... but saw several arm build failures all aborting close to printing the note and not other error message, and with this patch it's not failing anymore (as the jenkins build passed). It says "note", but the flag looks like it's a warning with -Wpsabi. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4497ba8f71215284df33c48c18864e1058520723 Gerrit-Change-Number: 28556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 10:38:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-trx[master]: configure.ac: enable-werror: add -Wno-error=psabi
by pespin 11 Jul '22

11 Jul '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28556 ) Change subject: configure.ac: enable-werror: add -Wno-error=psabi ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4497ba8f71215284df33c48c18864e1058520723 Gerrit-Change-Number: 28556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 10:10:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-trx[master]: configure.ac: enable-werror: add -Wno-error=psabi
by pespin 11 Jul '22

11 Jul '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28556 ) Change subject: configure.ac: enable-werror: add -Wno-error=psabi ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > e.g. from https://jenkins.osmocom. […] Are you sure this is what's making gcc to stop? Because I see it is a "note", not a "warning", and I always thought -Werror transforms only warning sinto error, but not notes. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4497ba8f71215284df33c48c18864e1058520723 Gerrit-Change-Number: 28556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 10:09:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-trx[master]: configure.ac: enable-werror: add -Wno-error=psabi
by osmith 11 Jul '22

11 Jul '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28556 ) Change subject: configure.ac: enable-werror: add -Wno-error=psabi ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Can you povide the full error log please? e.g. from https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-trx/1132/INSTR=--with-n…: make[5]: Entering directory '/build/osmo-trx-1.4.1.2-3231/_build/sub/Transceiver52M/device/lms' CXX LMSDevice.lo In file included from /usr/include/c++/8/map:60, from ../../../../../Transceiver52M/device/lms/LMSDevice.cpp:24: /usr/include/c++/8/bits/stl_tree.h: In member function ‘std::pair<std::_Rb_tree_node_base*, std::_Rb_tree_node_base*> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_get_insert_hint_unique_pos(std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::const_iterator, const key_type&) [with _Key = lms_dev_type; _Val = std::pair<const lms_dev_type, dev_desc>; _KeyOfValue = std::_Select1st<std::pair<const lms_dev_type, dev_desc> >; _Compare = std::less<lms_dev_type>; _Alloc = std::allocator<std::pair<const lms_dev_type, dev_desc> >]’: /usr/include/c++/8/bits/stl_tree.h:2146:5: note: parameter passing for argument of type ‘std::_Rb_tree<lms_dev_type, std::pair<const lms_dev_type, dev_desc>, std::_Select1st<std::pair<const lms_dev_type, dev_desc> >, std::less<lms_dev_type>, std::allocator<std::pair<const lms_dev_type, dev_desc> > >::const_iterator’ {aka ‘std::_Rb_tree_const_iterator<std::pair<const lms_dev_type, dev_desc> >’} changed in GCC 7.1 _Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>:: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/8/bits/stl_tree.h: In member function ‘std::pair<std::_Rb_tree_node_base*, std::_Rb_tree_node_base*> std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_get_insert_hint_unique_pos(std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::const_iterator, const key_type&) [with _Key = std::tuple<lms_dev_type, gsm_band>; _Val = std::pair<const std::tuple<lms_dev_type, gsm_band>, dev_band_desc>; _KeyOfValue = std::_Select1st<std::pair<const std::tuple<lms_dev_type, gsm_band>, dev_band_desc> >; _Compare = std::less<std::tuple<lms_dev_type, gsm_band> >; _Alloc = std::allocator<std::pair<const std::tuple<lms_dev_type, gsm_band>, dev_band_desc> >]’: /usr/include/c++/8/bits/stl_tree.h:2146:5: note: parameter passing for argument of type ‘std::_Rb_tree<std::tuple<lms_dev_type, gsm_band>, std::pair<const std::tuple<lms_dev_type, gsm_band>, dev_band_desc>, std::_Select1st<std::pair<const std::tuple<lms_dev_type, gsm_band>, dev_band_desc> >, std::less<std::tuple<lms_dev_type, gsm_band> >, std::allocator<std::pair<const std::tuple<lms_dev_type, gsm_band>, dev_band_desc> > >::const_iterator’ {aka ‘std::_Rb_tree_const_iterator<std::pair<const std::tuple<lms_dev_type, gsm_band>, dev_band_desc> >’} changed in GCC 7.1 CXXLD libdevice.la ar: `u' modifier ignored since `D' is the default (see `U') make[4]: *** [Makefile:432: all-recursive] Terminated make[2]: *** wait: No child processes. Stop. make[2]: *** Waiting for unfinished jobs.... make[2]: *** wait: No child processes. Stop. make: *** [Makefile:734: distcheck] Terminated make[5]: *** [Makefile:426: libdevice.la] Terminated make[1]: *** [Makefile:451: all] Error 2 make[3]: *** [Makefile:860: all-recursive] Terminated Build step 'Execute shell' marked build as failure Finished: FAILURE -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4497ba8f71215284df33c48c18864e1058520723 Gerrit-Change-Number: 28556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 10:02:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-trx[master]: configure.ac: enable-werror: add -Wno-error=psabi
by pespin 11 Jul '22

11 Jul '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28556 ) Change subject: configure.ac: enable-werror: add -Wno-error=psabi ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can you povide the full error log please? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4497ba8f71215284df33c48c18864e1058520723 Gerrit-Change-Number: 28556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 09:52:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: separate the scheduler into libl1sched.la
by pespin 11 Jul '22

11 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28555 ) Change subject: trxcon: separate the scheduler into libl1sched.la ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28555 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I001fb7bc2663eea308b5a8882746ed9863f2c2f8 Gerrit-Change-Number: 28555 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 09:51:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC
by pespin 11 Jul '22

11 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28554 ) Change subject: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Gerrit-Change-Number: 28554 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 09:51:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in simtrace2[master]: host/cardem: fix integer overflow in process_do_rx_da()
by fixeria 11 Jul '22

11 Jul '22

Attention is currently required from: Hoernchen, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/28513 ) Change subject: host/cardem: fix integer overflow in process_do_rx_da() ...................................................................... Patch Set 4: (2 comments) This change is ready for review. File host/src/simtrace2-cardem-pcsc.c: https://gerrit.osmocom.org/c/simtrace2/+/28513/comment/457cb0e6_92110d93 PS3, Line 170: if (rc < 0) > The point is that at this point we cannot possibly continue, as we don't know if we should continue […] Done https://gerrit.osmocom.org/c/simtrace2/+/28513/comment/618aefbf_cfee4410 PS3, Line 203: else if > certainly not, as we don't know if rx or tx is the next step in the communication. […] Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/28513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 Gerrit-Change-Number: 28513 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Jul 2022 09:50:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: make l1ctl_tx_dt_ind() accept const pointers
by pespin 11 Jul '22

11 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28553 ) Change subject: trxcon: make l1ctl_tx_dt_ind() accept const pointers ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I34f665a39c7d036efd4cbe335084fbe21142a48c Gerrit-Change-Number: 28553 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 09:48:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log