Attention is currently required from: pespin, dexter.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494 )
Change subject: MGCP_Test: fix TC_dlcx_wildcarded
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Not sure why f_stats_reset doesn't work, but in that case +1 from me
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5fe18e433b32c364778b515ed37fcbcf443b3cb3
Gerrit-Change-Number: 28494
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Jul 2022 13:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28557 )
Change subject: contrib/jenkins: don't run "make distcheck" on arm
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm not sure we want to merge this. […]
Okay, I don't have a strong opinion here. Let's see what other reviewers say.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ib4fbf7d54d479bbdda3c1415493bfc57b37d3971
Gerrit-Change-Number: 28557
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Jul 2022 12:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/28557 )
Change subject: contrib/jenkins: don't run "make distcheck" on arm
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm not sure we want to merge this. Even if it takes time, it still makes sense running that in different architectures imho.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ib4fbf7d54d479bbdda3c1415493bfc57b37d3971
Gerrit-Change-Number: 28557
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Jul 2022 12:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/28557 )
Change subject: contrib/jenkins: don't run "make distcheck" on arm
......................................................................
contrib/jenkins: don't run "make distcheck" on arm
Avoid building osmo-trx a second time on arm during "make distcheck". If
the build of osmo-trx already passed on arm, running "make distcheck"
should give the exact same result as on x86_64.
This should shorten the build time significantly for osmo-trx jobs
running on raspberry pis, currently they take half an hour.
Change-Id: Ib4fbf7d54d479bbdda3c1415493bfc57b37d3971
---
M contrib/jenkins.sh
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/28557/1
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index bcdcca4..584de07 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -106,8 +106,11 @@
$MAKE $PARALLEL_MAKE
$MAKE check \
|| cat-testlogs.sh
-DISTCHECK_CONFIGURE_FLAGS="$CONFIG" $MAKE $PARALLEL_MAKE distcheck \
- || cat-testlogs.sh
+
+if arch | grep -v -q arm; then
+ DISTCHECK_CONFIGURE_FLAGS="$CONFIG" $MAKE $PARALLEL_MAKE distcheck \
+ || cat-testlogs.sh
+fi
if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then
make -C "$base/doc/manuals" publish
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/28557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ib4fbf7d54d479bbdda3c1415493bfc57b37d3971
Gerrit-Change-Number: 28557
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange