- gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: Allocate struct osmux_in_handle through new libosmo-netif APIs
by laforge 03 Oct '22

03 Oct '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29530 ) Change subject: Allocate struct osmux_in_handle through new libosmo-netif APIs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29530/comment/25eb56f4_c894eb5e PS1, Line 141: TALLOC_FREE > it's a standard talloc API (define) and already used in several places. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I132a7c03213cb20dfe118616c8cfd7032b075507 Gerrit-Change-Number: 29530 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:23:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call
by laforge 03 Oct '22

03 Oct '22

Attention is currently required from: neels, fixeria, keith, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28509 ) Change subject: Change CC_CAUSE returned on unanswered MT Call ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701 Gerrit-Change-Number: 28509 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:22:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call
by keith 03 Oct '22

03 Oct '22

Attention is currently required from: neels, laforge, fixeria, dexter. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28509 ) Change subject: Change CC_CAUSE returned on unanswered MT Call ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Looking at that, and reading the comments, that guard timeout is designed to overall protect against […] reading further, I see we have implemented spec compliant T301. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701 Gerrit-Change-Number: 28509 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:18:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: keith <keith(a)rhizomatica.org> Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call
by keith 03 Oct '22

03 Oct '22

Attention is currently required from: neels, laforge, fixeria, dexter. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28509 ) Change subject: Change CC_CAUSE returned on unanswered MT Call ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > regarding proper CC timeout: the old cc implementation apparently only has one overall guard timer, […] Looking at that, and reading the comments, that guard timeout is designed to overall protect against something becoming non responsive: /*NOTE: The purpose of this timer is to prevent the cc state machine * from hanging [......] * So if the cc state machine does not show any activity for an * extended amount of time during call setup or teardown the guard * timer will time out and hard-clear the connection. */ One /could/ start adding conditions to this timer, but I think that might get in the way of it's stated purpose. It would seem that what is more needed is the proper implementation of T301 (I think it is T301) See TS 04.08 5.2.2.3.2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701 Gerrit-Change-Number: 28509 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmux: Skip lchans in lookup which still have no remote associated
by pespin 03 Oct '22

03 Oct '22

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/29575 ) Change subject: osmux: Skip lchans in lookup which still have no remote associated ...................................................................... osmux: Skip lchans in lookup which still have no remote associated Lchans which are marked as non-connected have not yet received information about its remote peer, hence they may not have some fields available yet. Let's skip them to avoid accessing such fields (lchan->abis_ip.osmux.in). Related: SYS#5987 Change-Id: Id53822c4a0486b0090df2db3d185e047d14fc90a --- M src/common/osmux.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/75/29575/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id53822c4a0486b0090df2db3d185e047d14fc90a Gerrit-Change-Number: 29575 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-bts[master]: osmux: Close osmux socket when bts is freed
by pespin 03 Oct '22

03 Oct '22

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/29576 ) Change subject: osmux: Close osmux socket when bts is freed ...................................................................... osmux: Close osmux socket when bts is freed Related: SYS#5987 Change-Id: Ibd3faa33b28d45048c340b177f13d5685f41a784 --- M src/common/osmux.c 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/76/29576/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibd3faa33b28d45048c340b177f13d5685f41a784 Gerrit-Change-Number: 29576 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-bts[master]: fixup
by pespin 03 Oct '22

03 Oct '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29575 ) Change subject: fixup ...................................................................... fixup Change-Id: Id53822c4a0486b0090df2db3d185e047d14fc90a --- M src/common/osmux.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/75/29575/1 diff --git a/src/common/osmux.c b/src/common/osmux.c index d10d091..498fe24 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -237,6 +237,8 @@ struct osmux_handle *h; if (!lchan->abis_ip.osmux.use) continue; + if (!lchan_osmux_connected(lchan)) + continue; if (lchan->abis_ip.osmux.local_cid != osmux_cid) continue; h = osmux_xfrm_input_get_deliver_cb_data(lchan->abis_ip.osmux.in); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id53822c4a0486b0090df2db3d185e047d14fc90a Gerrit-Change-Number: 29575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bts[master]: osmux: Close osmux socket when bts is freed
by pespin 03 Oct '22

03 Oct '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29576 ) Change subject: osmux: Close osmux socket when bts is freed ...................................................................... osmux: Close osmux socket when bts is freed Related: SYS#5987 Change-Id: Ibd3faa33b28d45048c340b177f13d5685f41a784 --- M src/common/osmux.c 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/76/29576/1 diff --git a/src/common/osmux.c b/src/common/osmux.c index 498fe24..e8223ff 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -25,6 +25,7 @@ #include <stdint.h> #include <stdbool.h> #include <inttypes.h> +#include <unistd.h> #include <osmocom/core/logging.h> #include <osmocom/core/utils.h> @@ -288,14 +289,18 @@ bts->osmux.batch_size = OSMUX_BATCH_DEFAULT_MAX; bts->osmux.dummy_padding = false; INIT_LLIST_HEAD(&bts->osmux.osmux_handle_list); + bts->osmux.fd.fd = -1; return 0; } void bts_osmux_release(struct gsm_bts *bts) { - /* FIXME: not needed? YES,we probably need to iterare over - bts->osmux.osmux_handle_list and free everything there, see - osmux_handle_put() */ + /* bts->osmux.osmux_handle_list should end up empty when all lchans are + * released/freed upon talloc_free(bts) */ + if (bts->osmux.fd.fd != -1) { + close(bts->osmux.fd.fd); + bts->osmux.fd.fd = -1; + } } /* Called after config file read, start services */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibd3faa33b28d45048c340b177f13d5685f41a784 Gerrit-Change-Number: 29576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bts[master]: osmux: nullify osmux.rtpst after freeing it
by pespin 03 Oct '22

03 Oct '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29574 ) Change subject: osmux: nullify osmux.rtpst after freeing it ...................................................................... osmux: nullify osmux.rtpst after freeing it Change-Id: I806cbe42cfc8fe59134ae842f3d7398acb1a1848 --- M src/common/osmux.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/74/29574/1 diff --git a/src/common/osmux.c b/src/common/osmux.c index 8a5d1ee..d10d091 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -427,8 +427,10 @@ osmux_handle_put(bts, lchan->abis_ip.osmux.in); lchan->abis_ip.osmux.in = NULL; } - if (lchan->abis_ip.osmux.rtpst) + if (lchan->abis_ip.osmux.rtpst) { osmo_rtp_handle_free(lchan->abis_ip.osmux.rtpst); + lchan->abis_ip.osmux.rtpst = NULL; + } lchan->abis_ip.osmux.use = false; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I806cbe42cfc8fe59134ae842f3d7398acb1a1848 Gerrit-Change-Number: 29574 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bts[master]: osmux: Log remote address upon rx of osmux pkt
by pespin 03 Oct '22

03 Oct '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29572 ) Change subject: osmux: Log remote address upon rx of osmux pkt ...................................................................... osmux: Log remote address upon rx of osmux pkt Related: SYS#5987 Change-Id: I391bc02a16eae1602680cb96128252f262852e14 --- M src/common/osmux.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/72/29572/1 diff --git a/src/common/osmux.c b/src/common/osmux.c index 02faab4..e178e0c 100644 --- a/src/common/osmux.c +++ b/src/common/osmux.c @@ -263,9 +263,11 @@ while ((osmuxh = osmux_xfrm_output_pull(msg)) != NULL) { struct gsm_lchan *lchan = osmux_lchan_find(bts, &rem_addr, osmuxh->circuit_id); if (!lchan) { + char addr_str[64]; + osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str), &rem_addr); LOGP(DOSMUX, LOGL_NOTICE, - "Cannot find lchan for circuit_id=%d\n", - osmuxh->circuit_id); + "Cannot find lchan for %s CID=%d\n", + addr_str, osmuxh->circuit_id); continue; } osmux_xfrm_output_sched(lchan->abis_ip.osmux.out, osmuxh); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I391bc02a16eae1602680cb96128252f262852e14 Gerrit-Change-Number: 29572 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log