- gerrit-log - lists.osmocom.org

Change in osmo-remsim[master]: client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level
by laforge 11 Jul '22

11 Jul '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28565 ) Change subject: client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level ...................................................................... client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level Closes: OS#5615 Change-Id: I9b54a53ef2809c9bfd110636a9ccb0c0d8c90cda --- M src/client/main_fsm.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/65/28565/1 diff --git a/src/client/main_fsm.c b/src/client/main_fsm.c index be3238f..fb73929 100644 --- a/src/client/main_fsm.c +++ b/src/client/main_fsm.c @@ -230,6 +230,7 @@ RsproPDU_t *pdu_rx = NULL; RsproPDU_t *resp; BankSlot_t bslot; + SlotPhysStatus_t *phys_status; switch (event) { case MF_E_BANKD_LOST: @@ -264,6 +265,9 @@ pdu_rx = data; OSMO_ASSERT(pdu_rx); OSMO_ASSERT(pdu_rx->msg.present == RsproPDUchoice_PR_tpduCardToModem); + LOGPFSML(fi, LOGL_NOTICE, "Rx tpduCardToModem(%s)\n", + osmo_hexdump_nospc(pdu_rx->msg.choice.tpduCardToModem.data.buf, + pdu_rx->msg.choice.tpduCardToModem.data.size)); /* forward to modem/cardem (via API) */ frontend_handle_card2modem(bc, pdu_rx->msg.choice.tpduCardToModem.data.buf, pdu_rx->msg.choice.tpduCardToModem.data.size); @@ -273,6 +277,9 @@ pdu_rx = data; OSMO_ASSERT(pdu_rx); OSMO_ASSERT(pdu_rx->msg.present == RsproPDUchoice_PR_setAtrReq); + LOGPFSML(fi, LOGL_NOTICE, "Rx setAtrReq(%s)\n", + osmo_hexdump_nospc(pdu_rx->msg.choice.setAtrReq.atr.buf, + pdu_rx->msg.choice.setAtrReq.atr.size)); /* forward to modem/cardem (via API) */ frontend_handle_set_atr(bc, pdu_rx->msg.choice.setAtrReq.atr.buf, pdu_rx->msg.choice.setAtrReq.atr.size); @@ -284,12 +291,19 @@ pdu_rx = data; OSMO_ASSERT(pdu_rx); OSMO_ASSERT(pdu_rx->msg.present == RsproPDUchoice_PR_bankSlotStatusInd); + phys_status = &pdu_rx->msg.choice.bankSlotStatusInd.slotPhysStatus; + LOGPFSML(fi, LOGL_NOTICE, "Rx bankSlotStatusInd(reset_act=%d, vcc_act=%d, clk_act=%d, " + "card_pres=%d)\n", phys_status->resetActive, phys_status->vccPresent, + phys_status->clkActive, phys_status->cardPresent); /* forward to modem/cardem (via API) */ frontend_handle_slot_status(bc, &pdu_rx->msg.choice.bankSlotStatusInd.slotPhysStatus); break; case MF_E_MDM_STATUS_IND: pstatus = data; OSMO_ASSERT(pstatus); + LOGPFSML(fi, LOGL_NOTICE, "Tx clientSlotStatusInd(reset_act=%d, vcc_act=%d, clk_act=%d, " + "card_pres=%d)\n", pstatus->flags.reset_active, pstatus->flags.vcc_present, + pstatus->flags.clk_active, pstatus->flags.card_present); /* forward to bankd */ bank_slot2rspro(&bslot, &bc->bankd_slot); resp = rspro_gen_ClientSlotStatusInd(bc->srv_conn.clslot, &bslot, @@ -305,11 +319,13 @@ case MF_E_MDM_PTS_IND: pts = data; OSMO_ASSERT(pts); + LOGPFSML(fi, LOGL_NOTICE, "PTS Indication (%s)\n", osmo_hexdump_nospc(pts->buf, pts->len)); /* forward to bankd? */ break; case MF_E_MDM_TPDU: tpdu = data; OSMO_ASSERT(tpdu); + LOGPFSML(fi, LOGL_INFO, "Tx tpduModemToCard (%s)\n", osmo_hexdump_nospc(tpdu->buf, tpdu->len)); /* forward to bankd */ bank_slot2rspro(&bslot, &bc->bankd_slot); resp = rspro_gen_TpduModem2Card(bc->srv_conn.clslot, &bslot, tpdu->buf, tpdu->len); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9b54a53ef2809c9bfd110636a9ccb0c0d8c90cda Gerrit-Change-Number: 28565 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: trxcon: use abstract API for RACH primitives
by laforge 11 Jul '22

11 Jul '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28552 ) Change subject: trxcon: use abstract API for RACH primitives ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28552 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I84597d44ea7d74b8840a919ecb09988ba1980a73 Gerrit-Change-Number: 28552 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 21:05:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: return prim pointer from l1sched_prim_alloc()
by laforge 11 Jul '22

11 Jul '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28549 ) Change subject: trxcon: return prim pointer from l1sched_prim_alloc() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0fa41cf55e90d191d032bca1754941cca763b03e Gerrit-Change-Number: 28549 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 21:05:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: rename l1sched_prim_init() to l1sched_prim_alloc()
by laforge 11 Jul '22

11 Jul '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28560 ) Change subject: trxcon: rename l1sched_prim_init() to l1sched_prim_alloc() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie1bebb6829ba9f640455685fcd7309b6aa442ef0 Gerrit-Change-Number: 28560 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 21:04:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: allocate a prim in l1sched_prim_push()
by laforge 11 Jul '22

11 Jul '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28551 ) Change subject: trxcon: allocate a prim in l1sched_prim_push() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia9c0170fb06efcef569e987b57ab9ab7f7c7e847 Gerrit-Change-Number: 28551 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Jul 2022 21:04:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: Install + package remsim-apitool as separate sub-package
by laforge 11 Jul '22

11 Jul '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28563 ) Change subject: Install + package remsim-apitool as separate sub-package ...................................................................... Install + package remsim-apitool as separate sub-package As the script depends on python3, let's put it into a new osmo-remsim-apitool package. Closes: OS#5612 Change-Id: I11d779f66833b5294ffeb422ce6b2a705719a899 --- M contrib/Makefile.am R contrib/osmo-remsim-apitool M contrib/osmo-remsim.spec.in M debian/control A debian/osmo-remsim-apitool.install 5 files changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/63/28563/1 diff --git a/contrib/Makefile.am b/contrib/Makefile.am index 17f56ed..3db49a4 100644 --- a/contrib/Makefile.am +++ b/contrib/Makefile.am @@ -1,3 +1,5 @@ SUBDIRS = etc_default systemd -EXTRA_DIST = remsim-apitool.py owhw-event-script.sh +EXTRA_DIST = owhw-event-script.sh + +bin_SCRIPTS = osmo-remsim-apitool diff --git a/contrib/remsim-apitool.py b/contrib/osmo-remsim-apitool similarity index 100% rename from contrib/remsim-apitool.py rename to contrib/osmo-remsim-apitool diff --git a/contrib/osmo-remsim.spec.in b/contrib/osmo-remsim.spec.in index 3097b8f..150a8ec 100644 --- a/contrib/osmo-remsim.spec.in +++ b/contrib/osmo-remsim.spec.in @@ -95,6 +95,17 @@ it maintains a list of clients + bankds connected to it, as well as the dynamic SIM card mappings between them. +%package -n osmo-remsim-apitool +Summary: Osmocom Remote SIM - API tool for Server +License: GPL-2.0-or-later +Group: Productivity/Telephony/Servers +Requires: python3 + +%description -n osmo-remsim-apitool +This is a small python tool for generating API requests to remsim-server, +which can be used by the system administrator to introspect and/or modify +the state (mostly slotmaps). + %package -n osmo-remsim-bankd Summary: Osmocom Remote SIM - Bank Daemon License: GPL-2.0-or-later @@ -191,6 +202,9 @@ %{_bindir}/osmo-remsim-server %{_unitdir}/osmo-remsim-server.service +%files -n osmo-remsim-server +%{_bindir}/osmo-remsim-apitool + %files -n osmo-remsim-bankd %{_bindir}/osmo-remsim-bankd %{_unitdir}/osmo-remsim-bankd.service diff --git a/debian/control b/debian/control index 7a847b8..4fdba3c 100644 --- a/debian/control +++ b/debian/control @@ -51,6 +51,15 @@ it maintains a list of clients + bankds connected to it, as well as the dynamic SIM card mappings between them. +Package: osmo-remsim-apitool +Architecture: any +Multi-Arch: same +Depends: ${shlibs:Depends}, ${misc:Depends}, python3 +Description: Osmocom Remote SIM - API tool for server + This is a small python tool for generating API requests to remsim-server, + which can be used by the system administrator to introspect and/or modify + the state (mostly slotmaps). + Package: osmo-remsim-bankd Architecture: any Multi-Arch: same diff --git a/debian/osmo-remsim-apitool.install b/debian/osmo-remsim-apitool.install new file mode 100644 index 0000000..fd47f34 --- /dev/null +++ b/debian/osmo-remsim-apitool.install @@ -0,0 +1 @@ +usr/bin/osmo-remsim-apitool -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I11d779f66833b5294ffeb422ce6b2a705719a899 Gerrit-Change-Number: 28563 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-remsim[master]: main_fsm: Log bankd config (ip/port/bank_id/slot_nr) + disconnect
by laforge 11 Jul '22

11 Jul '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28562 ) Change subject: main_fsm: Log bankd config (ip/port/bank_id/slot_nr) + disconnect ...................................................................... main_fsm: Log bankd config (ip/port/bank_id/slot_nr) + disconnect Closes: OS#6513 Change-Id: I30a814ba95eb9c545220a1513805f41ccb5acb42 --- M src/client/main_fsm.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/62/28562/1 diff --git a/src/client/main_fsm.c b/src/client/main_fsm.c index 0aa7429..be3238f 100644 --- a/src/client/main_fsm.c +++ b/src/client/main_fsm.c @@ -233,6 +233,7 @@ switch (event) { case MF_E_BANKD_LOST: + LOGPFSML(fi, LOGL_ERROR, "Connection to bankd lost\n"); osmo_fsm_inst_state_chg(fi, MF_ST_WAIT_BANKD, 0, 0); break; case MF_E_SRVC_CONFIG_BANK: @@ -244,6 +245,8 @@ rspro_IpAddr2str(&pdu_rx->msg.choice.configClientBankReq.bankd.ip)); bc->bankd_conn.server_port = pdu_rx->msg.choice.configClientBankReq.bankd.port; rspro2bank_slot(&bc->bankd_slot, &pdu_rx->msg.choice.configClientBankReq.bankSlot); + LOGPFSML(fi, LOGL_INFO, "Rx configClientBankReq(%s:%u / B%u:%u)\n", bc->bankd_conn.server_host, + bc->bankd_conn.server_port, bc->bankd_slot.bank_id, bc->bankd_slot.slot_nr); /* bankd port 0 is a magic value to indicate "no bankd" */ if (bc->bankd_conn.server_port == 0) osmo_fsm_inst_state_chg(fi, MF_ST_UNCONFIGURED, 0, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I30a814ba95eb9c545220a1513805f41ccb5acb42 Gerrit-Change-Number: 28562 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-remsim[master]: bankd: log BankID:SlotNr in every log line
by fixeria 11 Jul '22

11 Jul '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28561 ) Change subject: bankd: log BankID:SlotNr in every log line ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I84879609781a301338dacde7ff495632e3af08b9 Gerrit-Change-Number: 28561 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Jul 2022 20:27:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: bankd: log BankID:SlotNr in every log line
by laforge 11 Jul '22

11 Jul '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28561 ) Change subject: bankd: log BankID:SlotNr in every log line ...................................................................... bankd: log BankID:SlotNr in every log line It's relatively inconvenient having to mentally map the slot-number to a thread-id on every (re)connect to correlate the logs. The logs should contain the Bank/Slot number they relate to. Closes: OS#5611 Change-Id: I84879609781a301338dacde7ff495632e3af08b9 --- M src/bankd/bankd.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/61/28561/1 diff --git a/src/bankd/bankd.h b/src/bankd/bankd.h index c007802..9bf9bc9 100644 --- a/src/bankd/bankd.h +++ b/src/bankd/bankd.h @@ -20,7 +20,7 @@ extern struct value_string worker_state_names[]; #define LOGW(w, fmt, args...) \ - LOGP(DBANKDW, LOGL_INFO, "[%03u %s] " fmt, (w)->num, get_value_string(worker_state_names, (w)->state), \ + LOGP(DBANKDW, LOGL_INFO, "[%03u B%u:%u %s] " fmt, (w)->num, (w)->slot.bank_id, (w)->slot.slot_nr, get_value_string(worker_state_names, (w)->state), \ ## args) struct bankd; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I84879609781a301338dacde7ff495632e3af08b9 Gerrit-Change-Number: 28561 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmocom-bb[master]: trxcon: return prim pointer from l1sched_prim_alloc()
by fixeria 11 Jul '22

11 Jul '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28549 ) Change subject: trxcon: return prim pointer from l1sched_prim_alloc() ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > well an _init() function is expected to initialize something that was provided by the caller. […] Renamed the function in a separate change: https://gerrit.osmocom.org/c/osmocom-bb/+/28560/1, this way it should be cleaner. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0fa41cf55e90d191d032bca1754941cca763b03e Gerrit-Change-Number: 28549 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Jul 2022 20:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log