- gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: osmux: Allocate struct osmux_out_handle through API
by pespin 03 Oct '22

03 Oct '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29528 ) Change subject: osmux: Allocate struct osmux_out_handle through API ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: ping. This is blocking merge of lots of osmo-mgw and osmo-bts osmux fixes and improvements. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I752ab031f935f04731bb1a354333f1682a1aa5bd Gerrit-Change-Number: 29528 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:35:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr'
by laforge 03 Oct '22

03 Oct '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29554 ) Change subject: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr' ...................................................................... scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr' Coverity job currently fails because it fails to fetch osmo-gmr.git. Change-Id: I4d52dbf0f81332dc1856944a6a3c7376cb1e0638 Fixes: I17590d0b0b46274e2ceb007e20d7d1dc039f4e8d --- M scripts/common.sh 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/scripts/common.sh b/scripts/common.sh index 788fbff..23d58e7 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -123,6 +123,9 @@ rtl-sdr|osmo-fl2k|libosmo-dsp|libusrp) echo "$OSMO_GIT_URL_GITEA"/sdr/"$1" ;; + osmo-gmr) + echo "$OSMO_GIT_URL_GITEA"/satellite/"$1" + ;; *) echo "$OSMO_GIT_URL_GERRIT"/"$1" ;; -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d52dbf0f81332dc1856944a6a3c7376cb1e0638 Gerrit-Change-Number: 29554 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr'
by laforge 03 Oct '22

03 Oct '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29554 ) Change subject: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr' ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d52dbf0f81332dc1856944a6a3c7376cb1e0638 Gerrit-Change-Number: 29554 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:32:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/prepare_source_Osmocom.sh: execute with '-xe'
by laforge 03 Oct '22

03 Oct '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29553 ) Change subject: coverity/prepare_source_Osmocom.sh: execute with '-xe' ...................................................................... coverity/prepare_source_Osmocom.sh: execute with '-xe' Change-Id: Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 --- M coverity/prepare_source_Osmocom.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index ad03835..63fbea0 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/sh -xe . $(realpath common.sh) BASEDIR=source-Osmocom -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 Gerrit-Change-Number: 29553 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: coverity/prepare_source_Osmocom.sh: execute with '-xe'
by laforge 03 Oct '22

03 Oct '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29553 ) Change subject: coverity/prepare_source_Osmocom.sh: execute with '-xe' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 Gerrit-Change-Number: 29553 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:32:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr'
by laforge 03 Oct '22

03 Oct '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29554 ) Change subject: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d52dbf0f81332dc1856944a6a3c7376cb1e0638 Gerrit-Change-Number: 29554 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:32:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: mncc: move MNCC_F_ALL from mncc.c to mncc.h
by fixeria 03 Oct '22

03 Oct '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29562 ) Change subject: mncc: move MNCC_F_ALL from mncc.c to mncc.h ...................................................................... mncc: move MNCC_F_ALL from mncc.c to mncc.h Move it closer to the other MNCC_F_* entries, so that it's more likely that it gets updated when new flags are added. Change-Id: If1a12a696b87184c9eee14f475594c317927427b Related: OS#5282 --- M include/osmocom/msc/mncc.h M src/libmsc/mncc.c 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified keith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Objections: pespin: I would prefer this is not merged as is diff --git a/include/osmocom/msc/mncc.h b/include/osmocom/msc/mncc.h index 06a5dcc..8a1e4ad 100644 --- a/include/osmocom/msc/mncc.h +++ b/include/osmocom/msc/mncc.h @@ -126,6 +126,9 @@ #define MNCC_F_SIGNAL 0x2000 #define MNCC_F_GCR 0x4000 +/* UPDATEME when adding new MNCC_F_* entries above */ +#define MNCC_F_ALL 0x7fff + struct gsm_mncc { /* context based information */ uint32_t msg_type; diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c index f446f98..24e79a7 100644 --- a/src/libmsc/mncc.c +++ b/src/libmsc/mncc.c @@ -110,8 +110,6 @@ * MNCC validation code. Move to libosmocore once headers are merged ************************************************************************/ -#define MNCC_F_ALL 0x7fff - static int check_string_terminated(const char *str, unsigned int size) { int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1a12a696b87184c9eee14f475594c317927427b Gerrit-Change-Number: 29562 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-msc[master]: mncc: cosmetic: fix coding style in mncc_prim_check_sign()
by fixeria 03 Oct '22

03 Oct '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29563 ) Change subject: mncc: cosmetic: fix coding style in mncc_prim_check_sign() ...................................................................... mncc: cosmetic: fix coding style in mncc_prim_check_sign() Change-Id: I94d9cba7aca19f28c906e05dd86bfe3020abd5b1 Related: OS#5282 --- M src/libmsc/mncc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c index 24e79a7..026dae0 100644 --- a/src/libmsc/mncc.c +++ b/src/libmsc/mncc.c @@ -155,7 +155,7 @@ { int rc; - if (mncc_prim->fields & ~ MNCC_F_ALL) { + if (mncc_prim->fields & ~MNCC_F_ALL) { LOGP(DMNCC, LOGL_ERROR, "Unknown MNCC field mask 0x%x\n", mncc_prim->fields); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I94d9cba7aca19f28c906e05dd86bfe3020abd5b1 Gerrit-Change-Number: 29563 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-msc[master]: mncc: cosmetic: fix coding style in mncc_prim_check_sign()
by laforge 03 Oct '22

03 Oct '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29563 ) Change subject: mncc: cosmetic: fix coding style in mncc_prim_check_sign() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I94d9cba7aca19f28c906e05dd86bfe3020abd5b1 Gerrit-Change-Number: 29563 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:31:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: mncc: move MNCC_F_ALL from mncc.c to mncc.h
by laforge 03 Oct '22

03 Oct '22

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29562 ) Change subject: mncc: move MNCC_F_ALL from mncc.c to mncc.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1a12a696b87184c9eee14f475594c317927427b Gerrit-Change-Number: 29562 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 18:31:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log