- gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bts: Log unexpected RSL message
by pespin 04 Oct '22

04 Oct '22

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 ) Change subject: bts: Log unexpected RSL message ...................................................................... bts: Log unexpected RSL message This is useful when doing first look at failed tests in jenkins. Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4 --- M bts/BTS_Tests.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/29582/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index c6ce115..108041f 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -779,6 +779,9 @@ [not ignore_other] as_meas_res(); [not ignore_other] as_l1_dcch_loop(); [not ignore_other] as_l1_tch_loop(); + [not ignore_other] RSL.receive(RSL_Message:?) -> value rx { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected RSL message received: ", rx)); + } [not ignore_other] RSL.receive { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected RSL message received"); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4 Gerrit-Change-Number: 29582 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ttcn3-hacks[master]: WIP: TODO
by pespin 04 Oct '22

04 Oct '22

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28911 ) Change subject: WIP: TODO ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibecc128677d25f7d19a47f8a8a8a80a62b3c707a Gerrit-Change-Number: 28911 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 0

Change in osmo-bts[master]: osmo-bts-trx: rx_rach_fn(): properly detect handover RACH
by pespin 04 Oct '22

04 Oct '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29577 ) Change subject: osmo-bts-trx: rx_rach_fn(): properly detect handover RACH ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ice1674fd4fed8c54d605ff19d568f6e46b4c5783 Gerrit-Change-Number: 29577 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 08:27:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: Make linter happy: fix coding style issues
by fixeria 04 Oct '22

04 Oct '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29581 ) Change subject: Make linter happy: fix coding style issues ...................................................................... Make linter happy: fix coding style issues Change-Id: I6672fcd13d9617f054ab295232cfe486f5f17035 --- M src/gprs_rlcmac_sched.cpp M src/pdch_ul_controller.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp index 8b5227f..f5a01e9 100644 --- a/src/gprs_rlcmac_sched.cpp +++ b/src/gprs_rlcmac_sched.cpp @@ -474,7 +474,7 @@ /* Prio 1: select control message */ if ((msg = sched_select_ctrl_msg(pdch, fn, block_nr, &tbf_cand))) { - gsmtap_cat = PCU_GSMTAP_C_DL_CTRL; + gsmtap_cat = PCU_GSMTAP_C_DL_CTRL; } /* Prio 2: select data message for downlink */ else if((msg = sched_select_dl_data_msg(bts, pdch, fn, block_nr, req_mcs_kind, &tx_is_egprs))) { diff --git a/src/pdch_ul_controller.c b/src/pdch_ul_controller.c index 7fbbc51..1cdbb98 100644 --- a/src/pdch_ul_controller.c +++ b/src/pdch_ul_controller.c @@ -299,7 +299,7 @@ int res; struct rb_node *first; - while((first = rb_first(&ulc->tree_root))) { + while ((first = rb_first(&ulc->tree_root))) { item = container_of(first, struct pdch_ulc_node, node); res = fn_cmp(item->fn, fn); if (res > 0) /* item->fn AFTER fn */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6672fcd13d9617f054ab295232cfe486f5f17035 Gerrit-Change-Number: 29581 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmocore[master]: gsm0502: use parentheses in GSM_TDMA_FN_{SUM,SUB} macros
by fixeria 04 Oct '22

04 Oct '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29579 ) Change subject: gsm0502: use parentheses in GSM_TDMA_FN_{SUM,SUB} macros ...................................................................... gsm0502: use parentheses in GSM_TDMA_FN_{SUM,SUB} macros This makes it possible to pass expressions to the abovementioned macros without any side-effects. Strictly speaking, this is only necessary for argument 'b' of GSM_TDMA_FN_SUB, but let's also add them to GSM_TDMA_FN_SUM for consistency. Change-Id: I7f26156813139bbb7774e1eb342c91bc84fdad38 --- M include/osmocom/gsm/gsm0502.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/gsm/gsm0502.h b/include/osmocom/gsm/gsm0502.h index 1be2cc3..b6a1807 100644 --- a/include/osmocom/gsm/gsm0502.h +++ b/include/osmocom/gsm/gsm0502.h @@ -16,10 +16,10 @@ /*! Return the sum of two specified TDMA frame numbers (summation) */ #define GSM_TDMA_FN_SUM(a, b) \ - ((a + b) % GSM_TDMA_HYPERFRAME) + (((a) + (b)) % GSM_TDMA_HYPERFRAME) /*! Return the difference of two specified TDMA frame numbers (subtraction) */ #define GSM_TDMA_FN_SUB(a, b) \ - ((a + GSM_TDMA_HYPERFRAME - b) % GSM_TDMA_HYPERFRAME) + (((a) + GSM_TDMA_HYPERFRAME - (b)) % GSM_TDMA_HYPERFRAME) /*! Return the *minimum* difference of two specified TDMA frame numbers (distance) */ #define GSM_TDMA_FN_DIFF(a, b) \ OSMO_MIN(GSM_TDMA_FN_SUB(a, b), GSM_TDMA_FN_SUB(b, a)) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7f26156813139bbb7774e1eb342c91bc84fdad38 Gerrit-Change-Number: 29579 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-bts[master]: osmo-bts-trx: rx_rach_fn(): properly detect handover RACH
by laforge 04 Oct '22

04 Oct '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29577 ) Change subject: osmo-bts-trx: rx_rach_fn(): properly detect handover RACH ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ice1674fd4fed8c54d605ff19d568f6e46b4c5783 Gerrit-Change-Number: 29577 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 08:23:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmo-bts-trx: handle MTS 0b0110 indicating an Access Burst
by laforge 04 Oct '22

04 Oct '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29578 ) Change subject: osmo-bts-trx: handle MTS 0b0110 indicating an Access Burst ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0fbb63006797e6be386d1f76ed97fff098c036fc Gerrit-Change-Number: 29578 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 08:23:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: gsm0502: use parentheses in GSM_TDMA_FN_{SUM,SUB} macros
by laforge 04 Oct '22

04 Oct '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29579 ) Change subject: gsm0502: use parentheses in GSM_TDMA_FN_{SUM,SUB} macros ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7f26156813139bbb7774e1eb342c91bc84fdad38 Gerrit-Change-Number: 29579 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 08:22:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: bts_set_current_frame_number(): log TDMA FN of the next block
by laforge 04 Oct '22

04 Oct '22

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29580 ) Change subject: bts_set_current_frame_number(): log TDMA FN of the next block ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id28776fb5f0f85cd35d3918c79f8c8e338156aae Gerrit-Change-Number: 29580 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 08:22:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-pcu[master]: bts_set_current_frame_number(): log TDMA FN of the next block
by pespin 04 Oct '22

04 Oct '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29580 ) Change subject: bts_set_current_frame_number(): log TDMA FN of the next block ...................................................................... Patch Set 2: (1 comment) File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/29580/comment/6412b289_a95d0ae8 PS2, Line 346: "Detected FN jump! %u -> %u (next %u)\n", > maybe "(exp %u)" is much more clear here. next seems to imply it's the next in series of %u -> %u -> "next". -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id28776fb5f0f85cd35d3918c79f8c8e338156aae Gerrit-Change-Number: 29580 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 08:19:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log