- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: coverity: don't build tests for all
by osmith 12 Jul '22

12 Jul '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28576 ) Change subject: coverity: don't build tests for all ...................................................................... coverity: don't build tests for all The coverity jenkins job has been failing since we tried to build tests for all projects (and in an earlier attempt, build and run tests for all projects). Make the coverity job work again by skipping build of tests for asn1c. I looked into it earlier and the cause wasn't obvious to me, and it's currently not worth spending time on. Fix for: libtool: error: cannot find the library '../../skeletons/libasn1cskeletons.la' or unhandled argument '../../skeletons/libasn1cskeletons.la' Change-Id: Iba0bfe0e753812058436eaf515391eb1f4b09951 --- M coverity/prepare_source_Osmocom.sh 1 file changed, 41 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/28576/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 11b7e5c..01e3d73 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -1,42 +1,46 @@ #!/bin/sh BASEDIR=source-Osmocom +PROJECTS=" + libasn1c + libosmo-abis + libosmocore + libosmo-dsp + libosmo-netif + libosmo-sccp + libsmpp34 + libusrp + osmo-bsc + osmo-msc + osmo-mgw + osmo-ggsn + osmo-gbproxy + osmo-sgsn + osmo-bts + osmo-gmr + osmo-iuh + osmo-pcu + osmo-sysmon + osmo-sip-connector + osmo-trx + osmo-hlr + osmocom-bb + osmo-smlc + osmo-cbc + simtrace2 + osmo-hnodeb + osmo-hnbgw + osmo-bsc-nat +" + +PROJECTS_DONT_BUILD_TEST=" + asn1c +" + [ -d $BASEDIR ] || mkdir -p $BASEDIR cd $BASEDIR -for proj in \ - asn1c \ - libasn1c \ - libosmo-abis \ - libosmocore \ - libosmo-dsp \ - libosmo-netif \ - libosmo-sccp \ - libsmpp34 \ - libusrp \ - osmo-bsc \ - osmo-msc \ - osmo-mgw \ - osmo-ggsn \ - osmo-gbproxy \ - osmo-sgsn \ - osmo-bts \ - osmo-gmr \ - osmo-iuh \ - osmo-pcu \ - osmo-sysmon \ - osmo-sip-connector \ - osmo-trx \ - osmo-hlr \ - osmocom-bb \ - osmo-smlc \ - osmo-cbc \ - simtrace2 \ - osmo-hnodeb \ - osmo-hnbgw \ - osmo-bsc-nat \ - ; do - +for proj in $PROJECTS $PROJECTS_DONT_BUILD_TEST; do if [ -d $proj ]; then if [ -z "$SRC_SKIP_FETCH" ]; then (cd $proj && git fetch && git checkout -f -B master origin/master) @@ -47,9 +51,11 @@ else git clone git://git.osmocom.org/$proj fi +done - # We want to compile tests, but not execute them. Using 'noinst_PROGRAMS' - # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. +# We want to compile tests, but not execute them. Using 'noinst_PROGRAMS' +# instead of 'check_PROGRAMS' allows building test binaries during 'make all'. +for proj in $PROJECTS; do files="$(git -C $proj grep -l check_PROGRAMS)" if [ -n "$files" ]; then (cd $proj && sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iba0bfe0e753812058436eaf515391eb1f4b09951 Gerrit-Change-Number: 28576 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-e1d[master]: octoi_srv_fsm: fix implicit fall-through
by osmith 12 Jul '22

12 Jul '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/28575 ) Change subject: octoi_srv_fsm: fix implicit fall-through ...................................................................... octoi_srv_fsm: fix implicit fall-through Found by gcc (Debian 10.2.1-6) 10.2.1 20210110, which fails the build with --enable-werror because of this. Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b --- M src/octoi/octoi_srv_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/octoi/octoi_srv_fsm.c b/src/octoi/octoi_srv_fsm.c index 469436e..cda0e52 100644 --- a/src/octoi/octoi_srv_fsm.c +++ b/src/octoi/octoi_srv_fsm.c @@ -131,6 +131,7 @@ case ACCOUNT_MODE_NONE: LOGPFSML(fi, LOGL_NOTICE, "User account %s has mode 'none', rejecting\n", acc->user_id); + /* fall through */ default: st->rej_str = "Unsupported mode for user"; goto reject; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/28575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b Gerrit-Change-Number: 28575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-e1d[master]: octoi_srv_fsm: fix implicit fall-through
by osmith 12 Jul '22

12 Jul '22

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/28575 ) Change subject: octoi_srv_fsm: fix implicit fall-through ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/28575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b Gerrit-Change-Number: 28575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 13:25:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC
by pespin 12 Jul '22

12 Jul '22

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28554 ) Change subject: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Gerrit-Change-Number: 28554 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 12:40:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmocom-bb[master]: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC
by fixeria 12 Jul '22

12 Jul '22

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 to look at the new patch set (#7). Change subject: trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC ...................................................................... trxcon: abstract out the scheduler API from L1CTL/TRXD/TRXC Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Related: OS#5599, OS#3761 --- M src/host/trxcon/include/osmocom/bb/trxcon/l1ctl.h M src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h M src/host/trxcon/include/osmocom/bb/trxcon/l1sched.h M src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_lchan_common.c M src/host/trxcon/src/sched_lchan_desc.c M src/host/trxcon/src/sched_lchan_pdtch.c M src/host/trxcon/src/sched_lchan_rach.c M src/host/trxcon/src/sched_lchan_sch.c M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c M src/host/trxcon/src/sched_lchan_xcch.c M src/host/trxcon/src/sched_prim.c M src/host/trxcon/src/sched_trx.c M src/host/trxcon/src/trx_if.c M src/host/trxcon/src/trxcon.c 18 files changed, 460 insertions(+), 408 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/54/28554/7 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31f77976a7a225ef292fe6dcd583513aec97ed44 Gerrit-Change-Number: 28554 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-e1d[master]: octoi_srv_fsm: fix implicit fall-through
by fixeria 12 Jul '22

12 Jul '22

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/28575 ) Change subject: octoi_srv_fsm: fix implicit fall-through ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/28575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b Gerrit-Change-Number: 28575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 12:17:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: octoi_srv_fsm: fix implicit fall-through
by pespin 12 Jul '22

12 Jul '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/28575 ) Change subject: octoi_srv_fsm: fix implicit fall-through ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/28575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b Gerrit-Change-Number: 28575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 11:29:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-e1d[master]: octoi_srv_fsm: fix implicit fall-through
by osmith 12 Jul '22

12 Jul '22

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/28575 ) Change subject: octoi_srv_fsm: fix implicit fall-through ...................................................................... octoi_srv_fsm: fix implicit fall-through Found by gcc (Debian 10.2.1-6) 10.2.1 20210110, which fails the build with --enable-werror because of this. Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b --- M src/octoi/octoi_srv_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/75/28575/1 diff --git a/src/octoi/octoi_srv_fsm.c b/src/octoi/octoi_srv_fsm.c index 469436e..cda0e52 100644 --- a/src/octoi/octoi_srv_fsm.c +++ b/src/octoi/octoi_srv_fsm.c @@ -131,6 +131,7 @@ case ACCOUNT_MODE_NONE: LOGPFSML(fi, LOGL_NOTICE, "User account %s has mode 'none', rejecting\n", acc->user_id); + /* fall through */ default: st->rej_str = "Unsupported mode for user"; goto reject; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/28575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b Gerrit-Change-Number: 28575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in docker-playground[master]: ttcn3-cbc: Enable gsmtap log
by fixeria 12 Jul '22

12 Jul '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28569 ) Change subject: ttcn3-cbc: Enable gsmtap log ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I15ecf18e062218efb4a4319e29f182ba4331a37b Gerrit-Change-Number: 28569 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Jul 2022 10:47:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in docker-playground[master]: debian-bullseye-jenkins: new container
by osmith 12 Jul '22

12 Jul '22

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/28570 to look at the new patch set (#2). Change subject: debian-bullseye-jenkins: new container ...................................................................... debian-bullseye-jenkins: new container Related: OS#6041 Change-Id: I849568826b1993fd9fb652779e631188af4a319e --- A debian-bullseye-jenkins/Dockerfile A debian-bullseye-jenkins/Makefile 2 files changed, 180 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/70/28570/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I849568826b1993fd9fb652779e631188af4a319e Gerrit-Change-Number: 28570 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

gerrit-log