- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: Update multiaddr helper
by msuraev 01 Oct '22

01 Oct '22

Attention is currently required from: neels, fixeria, pespin, msuraev. Hello Jenkins Builder, neels, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28993 to look at the new patch set (#11). Change subject: Update multiaddr helper ...................................................................... Update multiaddr helper * use osmo_strbuf instead of plain buffer * properly handle OOM * remove default "0.0.0.0" on empty input * fix missing trailing ')' Related: OS#5581 Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 --- M src/socket.c 1 file changed, 49 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/93/28993/11 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 Gerrit-Change-Number: 28993 Gerrit-PatchSet: 11 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: Update multiaddr helper
by Jenkins Builder 01 Oct '22

01 Oct '22

Attention is currently required from: neels, fixeria, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 ) Change subject: Update multiaddr helper ...................................................................... Patch Set 10: (1 comment) File src/socket.c: Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-523): https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/f9c46540_f420bcbc PS10, Line 257: static int multiaddr_snprintf(char* buf, size_t buf_len, const char **hosts, size_t host_cnt) "foo* bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 Gerrit-Change-Number: 28993 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 01 Oct 2022 16:14:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: Update multiaddr helper
by msuraev 01 Oct '22

01 Oct '22

Attention is currently required from: neels, fixeria, pespin. Hello Jenkins Builder, neels, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/28993 to look at the new patch set (#10). Change subject: Update multiaddr helper ...................................................................... Update multiaddr helper * use osmo_strbuf instead of plain buffer * properly handle OOM * remove default "0.0.0.0" on empty input * fix missing trailing ')' Related: OS#5581 Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 --- M src/socket.c 1 file changed, 49 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/93/28993/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 Gerrit-Change-Number: 28993 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmocore[master]: Update multiaddr helper
by msuraev 01 Oct '22

01 Oct '22

Attention is currently required from: neels, fixeria, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 ) Change subject: Update multiaddr helper ...................................................................... Patch Set 9: (6 comments) File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/4f88114f_3d679a33 PS9, Line 206: buf_len > There is no 'buf_len' anymore. […] Done https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/1bbaa60a_5f2764e9 PS9, Line 211: const char **hosts, size_t host_count, > cosmetic: alignment needs to be fixed here Done https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/cabdfc50_85dde7a2 PS9, Line 220: > I think it makes sense to assert() here that either **hosts or **addrs is passed, not both at the sa […] Seems rather pointless to me: that's a static function with only few invocations, not part of public API so we don't have to insure against user who failed to read the docs. https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/ee49f2e0_1692bab0 PS9, Line 236: if (hosts[i]) > Before your patch this function would print "0.0.0.0" if hosts[i] is NULL. […] That seems like odd side-effect to me for which I couldn't find any tests. Having NULL input we can't guess whether IPv4 or IPv6 address to show. Moreover, print helper seems like a wrong place for such guesswork in a first place - the caller have more context information and can pass proper default explicitly. I'll update commit message to make it more visible. https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/610e45fc_467ccb3f PS9, Line 241: LOGL_DEBUG > LOGL_ERROR? Not sure if we need to log anything here though. Done https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/4c36e3d1_1f51e592 PS9, Line 749: 512 > Better do sizeof(strbuf). Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 Gerrit-Change-Number: 28993 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 01 Oct 2022 16:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: coverity/prepare_source_Osmocom.sh: execute with '-xe'
by fixeria 01 Oct '22

01 Oct '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29553 ) Change subject: coverity/prepare_source_Osmocom.sh: execute with '-xe' ...................................................................... coverity/prepare_source_Osmocom.sh: execute with '-xe' Change-Id: Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 --- M coverity/prepare_source_Osmocom.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/53/29553/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index ad03835..63fbea0 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/sh -xe . $(realpath common.sh) BASEDIR=source-Osmocom -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 Gerrit-Change-Number: 29553 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr'
by fixeria 01 Oct '22

01 Oct '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29554 ) Change subject: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr' ...................................................................... scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr' Coverity job currently fails because it fails to fetch osmo-gmr.git. Change-Id: I4d52dbf0f81332dc1856944a6a3c7376cb1e0638 Fixes: I17590d0b0b46274e2ceb007e20d7d1dc039f4e8d --- M scripts/common.sh 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/54/29554/1 diff --git a/scripts/common.sh b/scripts/common.sh index 788fbff..23d58e7 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -123,6 +123,9 @@ rtl-sdr|osmo-fl2k|libosmo-dsp|libusrp) echo "$OSMO_GIT_URL_GITEA"/sdr/"$1" ;; + osmo-gmr) + echo "$OSMO_GIT_URL_GITEA"/satellite/"$1" + ;; *) echo "$OSMO_GIT_URL_GERRIT"/"$1" ;; -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d52dbf0f81332dc1856944a6a3c7376cb1e0638 Gerrit-Change-Number: 29554 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: vty: 'hopping arfcn add': succeed if adding arfcn already in set
by fixeria 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29551 ) Change subject: vty: 'hopping arfcn add': succeed if adding arfcn already in set ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I intentionally added this check in Ie27c859e3f16ada08a5cdc8ab4ac6e20a885a378 to facilitate finding duplicates in the hopping configuration. The point is to prevent osmo-bsc from starting in that case. The 'apply-config-file' use case is very specific, I bet there can be similar errors, e.g. when adding neighbor [E]ARFCNs? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4e70d20d48a28c46a21dd10358577e5c798744c Gerrit-Change-Number: 29551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 20:58:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-...
by fixeria 30 Sep '22

30 Sep '22

Attention is currently required from: osmith, neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29549 ) Change subject: hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-after-free ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I628c59a88d94d299f432f405b37fbe602381d47e Gerrit-Change-Number: 29549 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 20:49:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: hnb_read_cb: use local var to reduce get_ofd() calls
by fixeria 30 Sep '22

30 Sep '22

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29548 ) Change subject: hnb_read_cb: use local var to reduce get_ofd() calls ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic7058b5a05b0d34b80617006d4e929a523212221 Gerrit-Change-Number: 29548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 20:48:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: Close conn when receiving SCTP_ASSOC_CHANGE notification
by fixeria 30 Sep '22

30 Sep '22

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547 ) Change subject: Close conn when receiving SCTP_ASSOC_CHANGE notification ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If35efd404405f926a4a6cc45862eeadd1b04e08c Gerrit-Change-Number: 29547 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 20:47:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log