- gerrit-log - lists.osmocom.org

[L] Change in ...osmo-epdg[master]: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)
by pespin 23 Oct '23

23 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email ) Change subject: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777) ...................................................................... diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777) S6b interface HSS<->PGW is defined in TS 28.273 section 9. TS 28.273 depends on some types defined in RFC 5777, which was missing so far. Some enumareated types in RFC 5777 whose enums fields are declared in yet other dependent RFCs are left with a dummy value, as TODO for the future if they are ever needed. Related: OS#6229 Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc --- A dia/diameter_3gpp_ts29_273_s6b.dia A dia/diameter_rfc5777.dia 2 files changed, 553 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/57/34857/1 diff --git a/dia/diameter_3gpp_ts29_273_s6b.dia b/dia/diameter_3gpp_ts29_273_s6b.dia new file mode 100644 index 0000000..790a43d --- /dev/null +++ b/dia/diameter_3gpp_ts29_273_s6b.dia @@ -0,0 +1,166 @@ +;; +;; %CopyrightBegin% +;; +;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> +;; Author: Pau Espin Pedrol <pespin(a)sysmocom.de> +;; +;; This resembles 3GPP TS 29.273 version 17.6.0 Release 17 +;; +;; Licensed under the Apache License, Version 2.0 (the "License"); +;; you may not use this file except in compliance with the License. +;; You may obtain a copy of the License at +;; +;; http://www.apache.org/licenses/LICENSE-2.0 +;; +;; Unless required by applicable law or agreed to in writing, software +;; distributed under the License is distributed on an "AS IS" BASIS, +;; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +;; See the License for the specific language governing permissions and +;; limitations under the License. +;; +;; %CopyrightEnd% +;; + +;; +;; Edits: +;; +;; + + +@id 16777272 +@name diameter_3gpp_ts29_273_s6b +;;@prefix diameter_3gpp +@vendor 10415 3GPP + +@inherits diameter_gen_base_rfc6733 +@inherits diameter_3gpp_base +@inherits diameter_3gpp_break_circles +@inherits diameter_3gpp_ts29_212 +@inherits diameter_3gpp_ts29_214 +@inherits diameter_3gpp_ts29_229 +@inherits diameter_3gpp_ts29_272 +@inherits diameter_3gpp_ts29_273 +@inherits diameter_3gpp_ts32_299 +@inherits diameter_etsi_es283_034 +@inherits diameter_rfc4006_cc +@inherits diameter_rfc5447 +@inherits diameter_rfc5580 +@inherits diameter_rfc5777 +@inherits diameter_rfc5778 +@inherits diameter_rfc7683 +@inherits diameter_rfc7944 +@inherits diameter_rfc8583 + +@messages + +;; 9. S6b +;; 9.2.2.2.1 AA-Request (AAR) + + AAR ::= < Diameter Header: 265, REQ, PXY > + < Session-Id > + { Auth-Application-Id } + { Origin-Host } + { Origin-Realm } + { Destination-Realm } + { Auth-Request-Type } + [ User-Name ] + [ MIP6-Agent-Info ] + [ MIP6-Feature-Vector ] + [ Visited-Network-Identifier ] + [ QoS-Capability ] + [ Service-Selection ] + [ OC-Supported-Features ] + [ Origination-Time-Stamp ] + [ Maximum-Wait-Time ] + *[ Supported-Features ] + [ Emergency-Services ] + *[ AVP ] + +;; 9.2.2.2.2 AA-Answer (AAA) + AAA ::= < Diameter Header: 265, PXY > + < Session-Id > + { Auth-Application-Id } + { Auth-Request-Type } + { Result-Code } + { Origin-Host } + { Origin-Realm } + [ MIP6-Feature-Vector ] + [ Session-Timeout ] + [ APN-Configuration ] + [ QoS-Resources ] + [ AN-Trusted ] + *[ Redirect-Host ] + [ Trace-Info ] + [ OC-Supported-Features ] + [ OC-OLR ] + *[ Load ] + +;; 9.2.2.3.1 Session-Termination-Request (STR) +;; 9.2.2.4.3 Session-Termination-Request (STR) + STR ::= < Diameter Header: 275, REQ, PXY > + < Session-Id > + { Auth-Application-Id } + { Origin-Host } + { Origin-Realm } + { Destination-Realm } + { Termination-Cause } + [ User-Name ] + [ OC-Supported-Features ] + *[ AVP ] + +;; 9.2.2.3.2 Session-Termination-Answer (STA) +;; 9.2.2.4.4 Session-Termination-Answer (STA) + STA ::= < Diameter Header: 275, PXY > + < Session-Id > + { Result-Code } + { Origin-Host } + { Origin-Realm } + [ OC-Supported-Features ] + [ OC-OLR ] + *[ Load ] + *[ AVP ] + +;; 9.2.2.4.1 Abort-Session-Request (ASR) + ASR ::= < Diameter Header: 274, REQ, PXY > + < Session-Id > + { Origin-Host } + { Origin-Realm } + { Destination-Realm } + { Destination-Host } + { Auth-Application-Id } + [ User-Name ] + [ Auth-Session-State ] + *[ AVP ] + +;; 9.2.2.4.2 Abort-Session-Answer (ASA) + ASA ::= < Diameter Header: 274, PXY > + < Session-Id > + { Result-Code } + { Origin-Host } + { Origin-Realm } + *[ AVP ] + +;; TODO: 9.2.2.5 Commands for S6b MIPv4 FACoA Authorization Procedures + +;; 9.2.2.6.1 Re-Auth-Request (RAR) + RAR ::= < Diameter Header: 258, REQ, PXY > + < Session-Id > + { Origin-Host } + { Origin-Realm } + { Destination-Realm } + { Destination-Host } + { Auth-Application-Id } + { Re-Auth-Request-Type } + [ User-Name ] + [RAR-Flags ] + *[ AVP ] + +;; 9.2.2.6.2 Re-Auth-Answer (RAA) + + RAA ::= < Diameter Header: 258, PXY > + < Session-Id > + { Result-Code } + { Origin-Host } + { Origin-Realm } + [ User-Name ] + *[ AVP ] diff --git a/dia/diameter_rfc5777.dia b/dia/diameter_rfc5777.dia new file mode 100644 index 0000000..916e08d --- /dev/null +++ b/dia/diameter_rfc5777.dia @@ -0,0 +1,368 @@ +;; +;; %CopyrightBegin% +;; +;; Transcribed from RFC 5777 by Pau Espin Pedrol <pespin(a)sysmocom.de> +;; +;; Licensed under the Apache License, Version 2.0 (the "License"); +;; you may not use this file except in compliance with the License. +;; You may obtain a copy of the License at +;; +;; http://www.apache.org/licenses/LICENSE-2.0 +;; +;; Unless required by applicable law or agreed to in writing, software +;; distributed under the License is distributed on an "AS IS" BASIS, +;; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +;; See the License for the specific language governing permissions and +;; limitations under the License. +;; +;; %CopyrightEnd% +;; + +;; +;; RFC 5777, Traffic Classification and Quality of Service (QoS) Attributes for Diameter +;; + +@id 1 + +@inherits diameter_gen_base_rfc6733 +;;@inherits diameter_rfc4004 + +;; =========================================================================== + +@avp_types + +QoS-Resources 508 Grouped - ;; 3.1 +Filter-Rule 509 Grouped - ;; 3.2 +Filter-Rule-Precedence 510 Unsigned32 - ;; 3.3 +Classifier 511 Grouped - ;; 4.1.1 +Classifier-ID 512 OctetString - ;; 4.1.2 +Protocol 513 Enumerated - ;; 4.1.3 +Direction 514 Enumerated - ;; 4.1.4 +From-Spec 515 Grouped - ;; 4.1.5 +To-Spec 516 Grouped - ;; 4.1.6 +Negated 517 Enumerated - ;; 4.1.7.1 +IP-Address 518 Address - ;; 4.1.7.2 +IP-Address-Range 519 Grouped - ;; 4.1.7.3 +IP-Address-Start 520 Address - ;; 4.1.7.4 +IP-Address-End 521 Address - ;; 4.1.7.5 +IP-Address-Mask 522 Grouped - ;; 4.1.7.6 +IP-Mask-Bit-Mask-Width 523 Unsigned32 - ;; 4.1.7.7 +MAC-Address 524 OctetString - ;; 4.1.7.8 +MAC-Address-Mask 525 Grouped - ;; 4.1.7.9 +MAC-Address-Mask-Pattern 526 OctetString - ;; 4.1.7.10 +EUI64-Address 527 OctetString - ;; 4.1.7.11 +EUI64-Address-Mask 528 Grouped - ;; 4.1.7.12 +EUI64-Address-Mask-Pattern 529 OctetString - ;; 4.1.7.13 +Port 530 Integer32 - ;; 4.1.7.14 +Port-Range 531 Grouped - ;; 4.1.7.15 +Port-Start 532 Integer32 - ;; 4.1.7.16 +Port-End 533 Integer32 - ;; 4.1.7.17 +Use-Assigned-Address 534 Enumerated - ;; 4.1.7.18 +Diffserv-Code-Point 535 Enumerated - ;; 4.1.8.1 +Fragmentation-Flag 536 Enumerated - ;; 4.1.8.2 +IP-Option 537 Grouped - ;; 4.1.8.3 +IP-Option-Type 538 Enumerated - ;; 4.1.8.4 +IP-Option-Value 539 OctetString - ;; 4.1.8.5 +TCP-Option 540 Grouped - ;; 4.1.8.6 +TCP-Option-Type 541 Enumerated - ;; 4.1.8.7 +TCP-Option-Value 542 OctetString - ;; 4.1.8.8 +TCP-Flags 543 Grouped - ;; 4.1.8.9 + +TCP-Flag-Type 544 Unsigned32 - ;; 4.1.8.10 +ICMP-Type 545 Grouped - ;; 4.1.8.11 +ICMP-Type-Number 546 Enumerated - ;; 4.1.8.12 +ICMP-Code 547 Enumerated - ;; 4.1.8.13 +ETH-Option 548 Grouped - ;; 4.1.8.14 +ETH-Proto-Type 549 Grouped - ;; 4.1.8.15 +ETH-Ether-Type 550 OctetString - ;; 4.1.8.16 +ETH-SAP 551 OctetString - ;; 4.1.8.17 +VLAN-ID-Range 552 Grouped - ;; 4.1.8.18 +S-VID-Start 553 Unsigned32 - ;; 4.1.8.19 +S-VID-End 554 Unsigned32 - ;; 4.1.8.20 +C-VID-Start 555 Unsigned32 - ;; 4.1.8.21 +C-VID-End 556 Unsigned32 - ;; 4.1.8.22 +User-Priority-Range 557 Grouped - ;; 4.1.8.23 +Low-User-Priority 558 Unsigned32 - ;; 4.1.8.24 +High-User-Priority 559 Unsigned32 - ;; 4.1.8.25 +Time-Of-Day-Condition 560 Grouped - ;; 4.2.1 +Time-Of-Day-Start 561 Unsigned32 - ;; 4.2.2 +Time-Of-Day-End 562 Unsigned32 - ;; 4.2.3 +Day-Of-Week-Mask 563 Unsigned32 - ;; 4.2.4 +Day-Of-Month-Mask 564 Unsigned32 - ;; 4.2.5 +Month-Of-Year-Mask 565 Unsigned32 - ;; 4.2.6 +Absolute-Start-Time 566 Time - ;; 4.2.7 +Absolute-Start-Fractional-Seconds 567 Unsigned32 - ;; 4.2.8 +Absolute-End-Time 568 Time - ;; 4.2.9 +Absolute-End-Fractional-Seconds 569 Unsigned32 - ;; 4.2.10 +Timezone-Flag 570 Enumerated - ;; 4.2.11 +Timezone-Offset 571 Integer32 - ;; 4.2.12 +Treatment-Action 572 Enumerated - ;; 5.1, wrongly defined as Grouped in RFC table +QoS-Profile-Id 573 Unsigned32 - ;; 5.2 +QoS-Profile-Template 574 Grouped - ;; 5.3 +QoS-Semantics 575 Enumerated - ;; 5.4 +QoS-Parameters 576 Grouped - ;; 5.5 +Excess-Treatment 577 Grouped - ;; 5.6 +QoS-Capability 578 Grouped - ;; 6 + +;; =========================================================================== + +@grouped + +;; 3.1 +QoS-Resources ::= < AVP Header: 508 > + 1*{ Filter-Rule } + *[ AVP ] + +;; 3.2 +Filter-Rule ::= < AVP Header: 509 > + [ Filter-Rule-Precedence ] +;; Condition part of a Rule +;; ------------------------ + [ Classifier ] + *[ Time-Of-Day-Condition ] +;; Action and Meta-Data +;; -------------------- + [ Treatment-Action ] + +;; Info about QoS related Actions +;; ------------------------------ + [ QoS-Semantics ] + [ QoS-Profile-Template ] + [ QoS-Parameters ] + [ Excess-Treatment ] +;; Extension Point +;; --------------- + *[ AVP ] + +;; 4.1.1. +Classifier ::= < AVP Header: 511 > + { Classifier-ID } + [ Protocol ] + [ Direction ] + *[ From-Spec ] + *[ To-Spec ] + *[ Diffserv-Code-Point ] + [ Fragmentation-Flag ] + *[ IP-Option ] + *[ TCP-Option ] + [ TCP-Flags ] + *[ ICMP-Type ] + *[ ETH-Option ] + *[ AVP ] + +;; 4.1.5. +From-Spec ::= < AVP Header: 515 > + *[ IP-Address ] + *[ IP-Address-Range ] + *[ IP-Address-Mask ] + *[ MAC-Address ] + *[ MAC-Address-Mask] + *[ EUI64-Address ] + *[ EUI64-Address-Mask] + *[ Port ] + *[ Port-Range ] + [ Negated ] + [ Use-Assigned-Address ] + *[ AVP ] + +;; 4.1.6 +To-Spec ::= < AVP Header: 516 > + *[ IP-Address ] + *[ IP-Address-Range ] + *[ IP-Address-Mask ] + *[ MAC-Address ] + *[ MAC-Address-Mask] + *[ EUI64-Address ] + *[ EUI64-Address-Mask] + *[ Port ] + *[ Port-Range ] + [ Negated ] + [ Use-Assigned-Address ] + *[ AVP ] + +;; 4.1.7.3. +IP-Address-Range ::= < AVP Header: 519 > + [ IP-Address-Start ] + [ IP-Address-End ] + *[ AVP ] + +;; 4.1.7.6 +IP-Address-Mask ::= < AVP Header: 522 > + { IP-Address } + { IP-Mask-Bit-Mask-Width } + *[ AVP ] + +;; 4.1.7.9. +MAC-Address-Mask ::= < AVP Header: 525 > + { MAC-Address } + { MAC-Address-Mask-Pattern } + *[ AVP ] + +;; 4.1.7.12. +EUI64-Address-Mask ::= < AVP Header: 528 > + { EUI64-Address } + { EUI64-Address-Mask-Pattern } + *[ AVP ] + +;; 4.1.7.15. +Port-Range ::= < AVP Header: 531 > + [ Port-Start ] + [ Port-End ] + *[ AVP ] + +;; 4.1.8.3. +IP-Option ::= < AVP Header: 537 > + { IP-Option-Type } + *[ IP-Option-Value ] + [ Negated ] + *[ AVP ] + +;; 4.1.8.6. +TCP-Option ::= < AVP Header: 540 > + { TCP-Option-Type } + *[ TCP-Option-Value ] + [ Negated ] + *[ AVP ] + +;; 4.1.8.9. +TCP-Flags ::= < AVP Header: 543 > + { TCP-Flag-Type } + [ Negated ] + *[ AVP ] + +;; 4.1.8.11 +ICMP-Type ::= < AVP Header: 545 > + { ICMP-Type-Number } + *[ ICMP-Code ] + [ Negated ] + *[ AVP ] + +;; 4.1.8.14 +ETH-Option ::= < AVP Header: 548 > + { ETH-Proto-Type } + *[ VLAN-ID-Range ] + *[ User-Priority-Range ] + *[ AVP ] + +;; 4.1.8.15 +ETH-Proto-Type ::= < AVP Header: 549 > + *[ ETH-Ether-Type ] + *[ ETH-SAP ] + *[ AVP ] + +;; 4.1.8.18 +VLAN-ID-Range ::= < AVP Header: 552 > + [ S-VID-Start ] + [ S-VID-End ] + [ C-VID-Start ] + [ C-VID-End ] + *[ AVP ] + +;; 4.1.8.23 +User-Priority-Range ::= < AVP Header: 557 > + *[ Low-User-Priority ] + *[ High-User-Priority ] + *[ AVP ] + +;; 4.2.1 +Time-Of-Day-Condition ::= < AVP Header: 560 > + [ Time-Of-Day-Start ] + [ Time-Of-Day-End ] + [ Day-Of-Week-Mask ] + [ Day-Of-Month-Mask ] + [ Month-Of-Year-Mask ] + [ Absolute-Start-Time ] + [ Absolute-End-Time ] + [ Timezone-Flag ] + *[ AVP ] + +;; 5.3 +QoS-Profile-Template ::= < AVP Header: 574 > + { Vendor-Id } + { QoS-Profile-Id } + *[ AVP ] + +;; 5.5 +QoS-Parameters ::= < AVP Header: 576 > + *[ AVP ] + +;; 5.6 +Excess-Treatment ::= < AVP Header: 577 > + { Treatment-Action } + [ QoS-Profile-Template ] + [ QoS-Parameters ] + *[ AVP ] + +;; 6. +QoS-Capability ::= < AVP Header: 578 > + 1*{ QoS-Profile-Template } + *[ AVP ] + +;; =========================================================================== + +;; 4.1.3. +@enum Protocol + PROTOCOL_TODO_CHECK_RFC2780 0 + +;; 4.1.4. +@enum Direction + DIRECTION_IN 0 + DIRECTION_OUT 1 + DIRECTION_BOTH 2 + +;; 4.1.7.1. +@enum Negated + NEGATED_FALSE 0 + NEGATED_TRUE 1 + +;; 4.1.7.18 +@enum Use-Assigned-Address + USE_ASSIGNED_ADDRESS_FALSE 0 + USE_ASSIGNED_ADDRESS_TRUE 1 + +;; 4.1.8.1. +@enum Diffserv-Code-Point + DIFFSERV_CODE_POINT_TODO_CHECK_RFC2474 0 + +;; 4.1.8.2. +@enum Fragmentation-Flag + FRAGMENTATION_FLAG_DF 0 + FRAGMENTATION_FLAG_MF 1 + +;; 4.1.8.4 +@enum IP-Option-Type + IP_OPTION_TYPE_TODO_CHECK_RFC2780 0 + +;; 4.1.8.7. +@enum TCP-Option-Type + TCP_OPTION_TYPE_TODO_CHECK_RFC2780 0 + +;; 4.1.8.12. +@enum ICMP-Type-Number + ICMP_TYPE_NUMBER_TODO_CHECK_RFC2780 0 + +;; 4.1.8.13. +@enum ICMP-Code + ICMP_CODE_TODO_CHECK_RFC2780 0 + + +;; 4.2.11. +@enum Timezone-Flag + TIMEZOME_FLAG_UTC 0 + TIMEZOME_FLAG_LOCAL 1 + TIMEZOME_FLAG_OFFSET 2 + +;; 5.1. +@enum Treatment-Action + TREATMENT_ACTION_DROP 0 + TREATMENT_ACTION_SHAPE 1 + TREATMENT_ACTION_MARK 2 + TREATMENT_ACTION_PERMIT 3 + +;; 5.4. +@enum QoS-Semantics + QOS_SEMANTICS_DESIRED 0 + QOS_SEMANTICS_AVAILABLE 1 + QOS_SEMANTICS_DELIVERED 2 + QOS_SEMANTICS_MINIMUM 3 + QOS_SEMANTICS_AUTHORIZE 4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc Gerrit-Change-Number: 34857 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: prevent SimCardCommands.select_adf_by_aid bypassing lchan
by laforge 23 Oct '23

23 Oct '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34849?usp=email ) Change subject: prevent SimCardCommands.select_adf_by_aid bypassing lchan ...................................................................... Patch Set 2: (1 comment) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/34849/comment/86a1eaea_77077d00 PS1, Line 149: SimCardCommands > `Optional[SimCardCommands]` as it can be `None` Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idf05c297e6a2e24ca539408b8912e348c0782bb4 Gerrit-Change-Number: 34849 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 11:47:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in pysim[master]: Initial support for eUICC
by laforge 23 Oct '23

23 Oct '23

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34852?usp=email ) Change subject: Initial support for eUICC ...................................................................... Patch Set 4: (1 comment) This change is ready for review. File pySim/euicc.py: https://gerrit.osmocom.org/c/pysim/+/34852/comment/553936ae_7350e8e9 PS4, Line 181: cmd_do_len > unused? thanks. that was a result of copy+paste -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a Gerrit-Change-Number: 34852 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 11:47:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell: Include current logical channel in prompt
by laforge 23 Oct '23

23 Oct '23

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34850?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: pySim-shell: Include current logical channel in prompt ...................................................................... pySim-shell: Include current logical channel in prompt Now that pySim-shell can switch between logical channels, let's state the currently used logical channel in the prompt. Change-Id: I45781a6fba205eeb4ac7f58d5cb642b7131bdd88 Related: OS#6230 --- M pySim-shell.py 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/50/34850/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I45781a6fba205eeb4ac7f58d5cb642b7131bdd88 Gerrit-Change-Number: 34850 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: prevent SimCardCommands.select_adf_by_aid bypassing lchan
by laforge 23 Oct '23

23 Oct '23

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34849?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: prevent SimCardCommands.select_adf_by_aid bypassing lchan ...................................................................... prevent SimCardCommands.select_adf_by_aid bypassing lchan Now that pySim-shell is aware of logical channels and issues almost all of its APDUs on the currently selected channel, we must also make sure that ADF selection by AID (implemented by the CardBase class) issues the SELECT on the respective logical channel. Before this patch, SELECT ADF by AID would always be issued on the primary logical channel (0), irrespective of the currently active RuntimeLchan. Change-Id: Idf05c297e6a2e24ca539408b8912e348c0782bb4 Related: OS#6230 --- M pySim/cards.py M pySim/runtime.py 2 files changed, 26 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/49/34849/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idf05c297e6a2e24ca539408b8912e348c0782bb4 Gerrit-Change-Number: 34849 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: transport: print reader device/number on init
by laforge 23 Oct '23

23 Oct '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34686?usp=email ) Change subject: transport: print reader device/number on init ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > I wonder if we could have a command line option like --verbose. […] I don't like the --verbose idea - at leat not for this particular topic. The information like which card reader is used, the ATR of the card, ... should be printed by default to the user. We just want a way to disable non-deterministic bits during tests. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5c08995fcd55bd9bb173adc2acd9722e438a164b Gerrit-Change-Number: 34686 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 11:43:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat, part 2
by osmith 23 Oct '23

23 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email ) Change subject: scripts/repo-install-test: fix sftp compat, part 2 ...................................................................... scripts/repo-install-test: fix sftp compat, part 2 Copy files inside repo-install-test, instead of copying the directory again. Otherwise it creates a /repo-install-test/repo-install-test/ path inside qemu and then fails to run the script inside the directory: Fix for: sh: 0: cannot open /repo-install-test/run-inside-env.sh: No such file Fixes: a7791217 ("scripts/repo-install-test: fix sftp compat") Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11 --- M scripts/repo-install-test.sh 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh index 98f0176..7bef5bf 100755 --- a/scripts/repo-install-test.sh +++ b/scripts/repo-install-test.sh @@ -154,7 +154,7 @@ qemu_ssh rm -rf /repo-install-test/ qemu_ssh mkdir /repo-install-test - qemu_scp -r "$TEST_DIR" "root@127.0.0.1:/repo-install-test" + qemu_scp -r "$TEST_DIR"/* "root@127.0.0.1:/repo-install-test" TIMEOUT="1h" qemu_ssh sh -ex /repo-install-test/run-inside-env.sh } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11 Gerrit-Change-Number: 34856 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat, part 2
by pespin 23 Oct '23

23 Oct '23

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email ) Change subject: scripts/repo-install-test: fix sftp compat, part 2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11 Gerrit-Change-Number: 34856 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 11:23:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean
by osmith 23 Oct '23

23 Oct '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email ) Change subject: Makefile: run 'rebar3 clean' upon make clean ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File Makefile: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841/comment/90a22bd4_b2f1… PS2, Line 17: # > Insert a space after # in each line to make it more readable? Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553 Gerrit-Change-Number: 34841 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 11:12:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean
by pespin 23 Oct '23

23 Oct '23

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Makefile: run 'rebar3 clean' upon make clean ...................................................................... Makefile: run 'rebar3 clean' upon make clean Otherwise the diameter files generated during compile in include/ and src/ are not removed. Change-Id: I771860f965499bb754c13385819845ef23f33553 --- M Makefile 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/41/34841/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553 Gerrit-Change-Number: 34841 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log