Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34865?usp=email )
Change subject: ASCI: Use correct mobile identiy in TALKER INDICATION message
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34865?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I299604a0e12d91e9133b70757826ac9637da0e3e
Gerrit-Change-Number: 34865
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:42:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria, laforge, pespin.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )
Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/742d93f6_0d73…
PS4, Line 60: %% TODO: make APN configurable? get it from HSS?
> But I think it is not yet defined how we pass that to osmo-epdg through the CEAI GSUP interface. […]
It should be passed on at least on the Location Update Request. Even the strongswan already know this at the time of Auth-Req. I would include it into the Location Update Request.
Lets fix this later not in this review.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email )
Change subject: Initial S6b support
......................................................................
Patch Set 2:
(2 comments)
File src/aaa_diameter_s6b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/c8c2408b_dc21…
PS2, Line 138: % APN is optional and should be []
> old code?
Could be, I'm just submitting initial code base to have something answering, we can clean up later once everything is in place, with smaller incremental patches improving the code base.
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/80e3de58_54b8…
PS2, Line 148: SessionId = diameter:session_id(application:get_env(?ENV_APP_NAME, origin_host, ?ENV_DEFAULT_ORIG_HOST)).
> It looks you're missing something here.
Yes, because AAA initiated procedures are not yet implemented here, only AAR+AAA initiated by PGW. We can add missing procedures as follow up, I'm for now fosucing on adding initial socket handling for each interface and implementing the minimum subset I need to go forward in a single ttcn3 test.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
Gerrit-Change-Number: 34858
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment