- gerrit-log - lists.osmocom.org

[L] Change in libosmocore[master]: tests: Test gsmtap logging if write queue fills up
by daniel 03 Nov '23

03 Nov '23

Attention is currently required from: daniel. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: tests: Test gsmtap logging if write queue fills up ...................................................................... tests: Test gsmtap logging if write queue fills up Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468 --- M tests/Makefile.am A tests/logging/logging_test_gsmtap.c A tests/logging/logging_test_gsmtap.err M tests/testsuite.at 4 files changed, 417 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/34967/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468 Gerrit-Change-Number: 34967 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in libosmocore[master]: tests: Test gsmtap logging if write queue fills up
by Jenkins Builder 03 Nov '23

03 Nov '23

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email ) Change subject: tests: Test gsmtap logging if write queue fills up ...................................................................... Patch Set 1: (3 comments) File tests/logging/logging_test_gsmtap.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12292): https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/e654eaaf_92b1cc35 PS1, Line 57: for (int i = 0; i < 200; i++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12292): https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/7f9350c7_afc521ec PS1, Line 58: DEBUGP(DLGLOBAL, "Repeating message (i = %i)\n", i); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12292): https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/f3c2cda0_9a241246 PS1, Line 61: for (int i = 0; i < 200; i++) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468 Gerrit-Change-Number: 34967 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 03 Nov 2023 20:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: logging_gsmtap: Temporarily disable logging when sending the logs
by daniel 03 Nov '23

03 Nov '23

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email ) Change subject: logging_gsmtap: Temporarily disable logging when sending the logs ...................................................................... logging_gsmtap: Temporarily disable logging when sending the logs This avoids an infinite recursion when sending a gsmtap log message causes a log message. Temporarily set target->loglevel higher than LOGL_FATAL, which effectively disables logging for that target. Other targets like stderr will still log this message so there is still an indication that something went wrong. Change-Id: I19203cadbad6019a3834793b8ac816d903fe088e Related: OS#6213 --- M src/core/logging_gsmtap.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/34966/1 diff --git a/src/core/logging_gsmtap.c b/src/core/logging_gsmtap.c index dfd059b..1b979ec 100644 --- a/src/core/logging_gsmtap.c +++ b/src/core/logging_gsmtap.c @@ -114,7 +114,11 @@ } msgb_put(msg, rc); + /* Ensure that any error when sending the log message don't cause infinite recursion */ + level = target->loglevel; + target->loglevel = LOGL_FATAL + 1; rc = gsmtap_sendmsg(target->tgt_gsmtap.gsmtap_inst, msg); + target->loglevel = level; if (rc) msgb_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I19203cadbad6019a3834793b8ac816d903fe088e Gerrit-Change-Number: 34966 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in libosmocore[master]: tests: Test gsmtap logging if write queue fills up
by daniel 03 Nov '23

03 Nov '23

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email ) Change subject: tests: Test gsmtap logging if write queue fills up ...................................................................... tests: Test gsmtap logging if write queue fills up Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468 --- M tests/Makefile.am A tests/logging/logging_test_gsmtap.c A tests/logging/logging_test_gsmtap.err M tests/testsuite.at 4 files changed, 419 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/34967/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 5f4914e..8c8e370 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -15,6 +15,7 @@ gsm0808/gsm0808_test gsm0408/gsm0408_test \ gprs/gprs_test kasumi/kasumi_test gea/gea_test \ logging/logging_test codec/codec_test \ + logging/logging_test_gsmtap \ loggingrb/loggingrb_test strrb/strrb_test \ comp128/comp128_test \ bitvec/bitvec_test msgb/msgb_test bits/bitcomp_test \ diff --git a/tests/logging/logging_test_gsmtap.c b/tests/logging/logging_test_gsmtap.c new file mode 100644 index 0000000..f84cdce --- /dev/null +++ b/tests/logging/logging_test_gsmtap.c @@ -0,0 +1,66 @@ +/* simple test for the debug interface */ +/* + * (C) 2008, 2009 by Holger Hans Peter Freyther <zecke(a)selfish.org> + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */ + +#include <osmocom/core/select.h> +#include <osmocom/core/logging.h> +#include <osmocom/core/utils.h> + +#include <stdlib.h> + +static const struct log_info_cat default_categories[] = {}; + +const struct log_info log_info = { + .cat = default_categories, + .num_cat = ARRAY_SIZE(default_categories), +}; + +extern struct log_info *osmo_log_info; + +int main(int argc, char **argv) +{ + struct log_target *stderr_target; + struct log_target *gsmtap_target; + + log_init(&log_info, NULL); + stderr_target = log_target_create_stderr(); + log_add_target(stderr_target); + log_set_all_filter(stderr_target, 1); + log_set_print_filename2(stderr_target, LOG_FILENAME_NONE); + log_set_print_category_hex(stderr_target, 0); + log_set_print_category(stderr_target, 1); + log_set_use_color(stderr_target, 0); + log_parse_category_mask(stderr_target, "DLGLOBAL,1"); + + gsmtap_target = log_target_create_gsmtap("127.0.0.2", 4729, "gsmtap", 1, 1); + log_add_target(gsmtap_target); + log_set_all_filter(gsmtap_target, 1); + log_parse_category_mask(gsmtap_target, "DLGLOBAL,1"); + + log_target_file_switch_to_stream(stderr_target); + + log_set_category_filter(stderr_target, DLGLOBAL, 1, LOGL_DEBUG); + + for (int i = 0; i < 200; i++) { + DEBUGP(DLGLOBAL, "Repeating message (i = %i)\n", i); + } + + for (int i = 0; i < 200; i++) { + osmo_select_main(1); + } + + return 0; +} diff --git a/tests/logging/logging_test_gsmtap.err b/tests/logging/logging_test_gsmtap.err new file mode 100644 index 0000000..dcba5cf --- /dev/null +++ b/tests/logging/logging_test_gsmtap.err @@ -0,0 +1,336 @@ +DLGLOBAL Repeating message (i = 0) +DLGLOBAL Repeating message (i = 1) +DLGLOBAL Repeating message (i = 2) +DLGLOBAL Repeating message (i = 3) +DLGLOBAL Repeating message (i = 4) +DLGLOBAL Repeating message (i = 5) +DLGLOBAL Repeating message (i = 6) +DLGLOBAL Repeating message (i = 7) +DLGLOBAL Repeating message (i = 8) +DLGLOBAL Repeating message (i = 9) +DLGLOBAL Repeating message (i = 10) +DLGLOBAL Repeating message (i = 11) +DLGLOBAL Repeating message (i = 12) +DLGLOBAL Repeating message (i = 13) +DLGLOBAL Repeating message (i = 14) +DLGLOBAL Repeating message (i = 15) +DLGLOBAL Repeating message (i = 16) +DLGLOBAL Repeating message (i = 17) +DLGLOBAL Repeating message (i = 18) +DLGLOBAL Repeating message (i = 19) +DLGLOBAL Repeating message (i = 20) +DLGLOBAL Repeating message (i = 21) +DLGLOBAL Repeating message (i = 22) +DLGLOBAL Repeating message (i = 23) +DLGLOBAL Repeating message (i = 24) +DLGLOBAL Repeating message (i = 25) +DLGLOBAL Repeating message (i = 26) +DLGLOBAL Repeating message (i = 27) +DLGLOBAL Repeating message (i = 28) +DLGLOBAL Repeating message (i = 29) +DLGLOBAL Repeating message (i = 30) +DLGLOBAL Repeating message (i = 31) +DLGLOBAL Repeating message (i = 32) +DLGLOBAL Repeating message (i = 33) +DLGLOBAL Repeating message (i = 34) +DLGLOBAL Repeating message (i = 35) +DLGLOBAL Repeating message (i = 36) +DLGLOBAL Repeating message (i = 37) +DLGLOBAL Repeating message (i = 38) +DLGLOBAL Repeating message (i = 39) +DLGLOBAL Repeating message (i = 40) +DLGLOBAL Repeating message (i = 41) +DLGLOBAL Repeating message (i = 42) +DLGLOBAL Repeating message (i = 43) +DLGLOBAL Repeating message (i = 44) +DLGLOBAL Repeating message (i = 45) +DLGLOBAL Repeating message (i = 46) +DLGLOBAL Repeating message (i = 47) +DLGLOBAL Repeating message (i = 48) +DLGLOBAL Repeating message (i = 49) +DLGLOBAL Repeating message (i = 50) +DLGLOBAL Repeating message (i = 51) +DLGLOBAL Repeating message (i = 52) +DLGLOBAL Repeating message (i = 53) +DLGLOBAL Repeating message (i = 54) +DLGLOBAL Repeating message (i = 55) +DLGLOBAL Repeating message (i = 56) +DLGLOBAL Repeating message (i = 57) +DLGLOBAL Repeating message (i = 58) +DLGLOBAL Repeating message (i = 59) +DLGLOBAL Repeating message (i = 60) +DLGLOBAL Repeating message (i = 61) +DLGLOBAL Repeating message (i = 62) +DLGLOBAL Repeating message (i = 63) +DLGLOBAL Repeating message (i = 64) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 65) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 66) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 67) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 68) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 69) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 70) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 71) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 72) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 73) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 74) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 75) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 76) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 77) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 78) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 79) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 80) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 81) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 82) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 83) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 84) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 85) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 86) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 87) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 88) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 89) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 90) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 91) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 92) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 93) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 94) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 95) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 96) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 97) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 98) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 99) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 100) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 101) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 102) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 103) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 104) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 105) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 106) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 107) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 108) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 109) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 110) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 111) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 112) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 113) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 114) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 115) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 116) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 117) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 118) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 119) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 120) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 121) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 122) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 123) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 124) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 125) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 126) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 127) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 128) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 129) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 130) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 131) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 132) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 133) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 134) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 135) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 136) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 137) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 138) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 139) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 140) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 141) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 142) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 143) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 144) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 145) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 146) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 147) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 148) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 149) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 150) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 151) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 152) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 153) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 154) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 155) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 156) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 157) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 158) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 159) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 160) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 161) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 162) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 163) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 164) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 165) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 166) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 167) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 168) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 169) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 170) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 171) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 172) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 173) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 174) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 175) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 176) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 177) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 178) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 179) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 180) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 181) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 182) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 183) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 184) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 185) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 186) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 187) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 188) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 189) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 190) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 191) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 192) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 193) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 194) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 195) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 196) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 197) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 198) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb +DLGLOBAL Repeating message (i = 199) +DLGLOBAL wqueue(0x611000000328) is full. Rejecting msgb diff --git a/tests/testsuite.at b/tests/testsuite.at index 3366995..20e9d03 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -201,6 +201,13 @@ AT_CHECK([$abs_top_builddir/tests/logging/logging_test wqueue], [0], [expout], [experr]) AT_CLEANUP +AT_SETUP([logging_gsmtap]) +AT_KEYWORDS([logging_gsmtap]) +cat $abs_srcdir/logging/logging_test_gsmtap.ok > expout +cat $abs_srcdir/logging/logging_test_gsmtap.err > experr +AT_CHECK([$abs_top_builddir/tests/logging/logging_test_gsmtap], [0], [expout], [experr]) +AT_CLEANUP + AT_SETUP([codec]) AT_KEYWORDS([codec]) cat $abs_srcdir/codec/codec_test.ok > expout -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468 Gerrit-Change-Number: 34967 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-trx[master]: ms: init blade with fpga control
by Hoernchen 03 Nov '23

03 Nov '23

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/34965?usp=email ) Change subject: ms: init blade with fpga control ...................................................................... ms: init blade with fpga control Blade 1 defaults to fpga tuning, but the blade 2 code defaults to host, which does 8000 register reads and writes. The only way to speed this up is to set the env var, which reduces opening the blade device from 10 to 1 seconds. Change-Id: I32fe31f1e11f4ceb3c864ec8739d177e780d0a7e --- M Transceiver52M/ms/bladerf_specific.h 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/65/34965/1 diff --git a/Transceiver52M/ms/bladerf_specific.h b/Transceiver52M/ms/bladerf_specific.h index e32d77c..e9245d4 100644 --- a/Transceiver52M/ms/bladerf_specific.h +++ b/Transceiver52M/ms/bladerf_specific.h @@ -254,6 +254,8 @@ bladerf_log_set_verbosity(BLADERF_LOG_LEVEL_DEBUG); bladerf_set_usb_reset_on_open(true); + + setenv("BLADERF_DEFAULT_TUNING_MODE","fpga",1); // ensure blade 2 does not spend 10 seconds initializing host control blade_check(bladerf_open, &dev, ""); if (!dev) { std::cerr << "open failed, device missing?" << std::endl; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I32fe31f1e11f4ceb3c864ec8739d177e780d0a7e Gerrit-Change-Number: 34965 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: upgrade to PCUIF v12
by laforge 03 Nov '23

03 Nov '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34934?usp=email ) Change subject: PCUIF: upgrade to PCUIF v12 ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: how will we still tst the older version for running the ttcn3 test suite against osmo-pcu latest? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib1516e66c70f021adee49f41bd707803fc06f9cf Gerrit-Change-Number: 34934 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Nov 2023 19:44:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce mp_hnbgw_timer_x31
by laforge 03 Nov '23

03 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email ) Change subject: hnbgw: Introduce mp_hnbgw_timer_x31 ...................................................................... hnbgw: Introduce mp_hnbgw_timer_x31 The default value of the timer changed recently, and made some tests which were using some timer hardcoded values fail. Add this configurable option to adapt the test behavior to the osmo-hnbgw configuration. This way we can also set it to lower values in order to avoid waiting too much time. Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/osmo-hnbgw.cfg 2 files changed, 21 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 4afb8dd..505beab 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -194,6 +194,10 @@ charstring mp_pfcp_ip_remote := "127.0.0.2"; boolean mp_validate_talloc_asn1 := true; + + /* The X31 timer configured at osmo-hnbgw (seconds). This provided an idea on + * minimum time the test must wait to consider this timer triggered */ + integer mp_hnbgw_timer_x31 := 5; } function MSC_UnitdataCallback(RANAP_PDU ranap) runs on RAN_Emulation_CT return template RANAP_PDU { @@ -763,7 +767,7 @@ template RANAP_PDU exp_rx := omit) runs on ConnHdlr return RANAP_PDU { var RANAP_PDU rx - timer T := 10.0; + timer T := int2float(mp_hnbgw_timer_x31) + 1.0; if (istemplatekind(exp_rx, "omit")) { exp_rx := tx; diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg index 3ccc28d..edd8c21 100644 --- a/hnbgw/osmo-hnbgw.cfg +++ b/hnbgw/osmo-hnbgw.cfg @@ -49,6 +49,7 @@ local-ip 127.0.0.1 local-port 29169 hnbap-allow-tmsi 1 + timer hnbgw x31 5 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce Gerrit-Change-Number: 34951 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce mp_hnbgw_timer_x31
by laforge 03 Nov '23

03 Nov '23

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email ) Change subject: hnbgw: Introduce mp_hnbgw_timer_x31 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce Gerrit-Change-Number: 34951 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Nov 2023 19:43:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: X31: fix vty doc
by laforge 03 Nov '23

03 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email ) Change subject: X31: fix vty doc ...................................................................... X31: fix vty doc The actual scope is larger than just a stale release. Every RUA and SCCP context map FSM state that has a timeout uses X31. (Seems I intended to add more timers but forgot to follow up when I wrote it.) Related: SYS#6602 Change-Id: I75a25f9065bc651e7ba8feda6db03c49a3b75c5e --- M src/osmo-hnbgw/tdefs.c 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/tdefs.c b/src/osmo-hnbgw/tdefs.c index cae9405..b2ee65f 100644 --- a/src/osmo-hnbgw/tdefs.c +++ b/src/osmo-hnbgw/tdefs.c @@ -34,7 +34,7 @@ struct osmo_tdef hnbgw_T_defs[] = { {.T = 3113, .default_val = 15, .desc = "Time to keep Paging record, for CN pools with more than one link" }, {.T = 4, .default_val = 5, .desc = "Timeout to receive RANAP RESET ACKNOWLEDGE from an MSC/SGSN" }, - {.T = -31, .default_val = 15, .desc = "Timeout for discarding a partially released context map (RUA <-> SCCP)" }, + {.T = -31, .default_val = 15, .desc = "Timeout for establishing and releasing context maps (RUA <-> SCCP)" }, {.T = -1002, .default_val = 10, .desc = "Timeout for the HNB to respond to PS RAB Assignment Request" }, { } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I75a25f9065bc651e7ba8feda6db03c49a3b75c5e Gerrit-Change-Number: 34933 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: X31: fix vty doc
by laforge 03 Nov '23

03 Nov '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email ) Change subject: X31: fix vty doc ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I75a25f9065bc651e7ba8feda6db03c49a3b75c5e Gerrit-Change-Number: 34933 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Nov 2023 19:42:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log