- gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-dia2gsup-test/osmo_dia2gsup: set connect timer to 200 ms
by lynxis lazus 11 Nov '23

11 Nov '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35000?usp=email ) Change subject: ttcn3-dia2gsup-test/osmo_dia2gsup: set connect timer to 200 ms ...................................................................... ttcn3-dia2gsup-test/osmo_dia2gsup: set connect timer to 200 ms Related: OS#5657 Change-Id: I22839cdf76120bb6152b32059822001cbd7979d8 --- M ttcn3-dia2gsup-test/osmo_dia2gsup.config 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/00/35000/1 diff --git a/ttcn3-dia2gsup-test/osmo_dia2gsup.config b/ttcn3-dia2gsup-test/osmo_dia2gsup.config index dc0b876..4403935 100644 --- a/ttcn3-dia2gsup-test/osmo_dia2gsup.config +++ b/ttcn3-dia2gsup-test/osmo_dia2gsup.config @@ -5,6 +5,7 @@ {diameter_ip, "172.18.10.20"}, {diameter_port, 3868}, {diameter_proto, sctp}, + {diameter_connect_timer, 200}, {origin_host, "hss.localdomain"}, {origin_realm, "localdomain"}, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I22839cdf76120bb6152b32059822001cbd7979d8 Gerrit-Change-Number: 35000 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: dia2gsup: sleep(1) to forget diameter state
by lynxis lazus 11 Nov '23

11 Nov '23

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34999?usp=email ) Change subject: dia2gsup: sleep(1) to forget diameter state ...................................................................... dia2gsup: sleep(1) to forget diameter state Sleep to allow the remote to forget the connection (see diameter connect timer). Related: OS#5657 Change-Id: Ib909eff5c381c6271b9d16e383bed3e78ca454da --- M dia2gsup/DIA2GSUP_Tests.ttcn 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/34999/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib909eff5c381c6271b9d16e383bed3e78ca454da Gerrit-Change-Number: 34999 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: dia2gsup: sleep(1) to forget diameter state
by lynxis lazus 11 Nov '23

11 Nov '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34999?usp=email ) Change subject: dia2gsup: sleep(1) to forget diameter state ...................................................................... dia2gsup: sleep(1) to forget diameter state Sleep to allow the remote to forget the connection (see diameter connect timer). Change-Id: Ib909eff5c381c6271b9d16e383bed3e78ca454da --- M dia2gsup/DIA2GSUP_Tests.ttcn 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/34999/1 diff --git a/dia2gsup/DIA2GSUP_Tests.ttcn b/dia2gsup/DIA2GSUP_Tests.ttcn index 673038c..e12f17b 100644 --- a/dia2gsup/DIA2GSUP_Tests.ttcn +++ b/dia2gsup/DIA2GSUP_Tests.ttcn @@ -159,6 +159,8 @@ g_Tguard.start(t_guard); activate(as_Tguard()); + /* Sleep to allow the remote to forget the connection (see diameter connect timer). */ + f_sleep(1.0); f_init_gsup(testcasename()); f_init_diameter(testcasename()); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib909eff5c381c6271b9d16e383bed3e78ca454da Gerrit-Change-Number: 34999 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[M] Change in ...osmo_dia2gsup[master]: gsup: implement a (re-)connect the GSUP link if it fails
by laforge 11 Nov '23

11 Nov '23

Attention is currently required from: daniel, fixeria, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email ) Change subject: gsup: implement a (re-)connect the GSUP link if it fails ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d Gerrit-Change-Number: 34285 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 11 Nov 2023 13:03:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: client: replace two assertions with graceful error handling
by fixeria 10 Nov '23

10 Nov '23

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email ) Change subject: client: replace two assertions with graceful error handling ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia5d8a9aff565399a85a5b116d7029fedcab234e0 Gerrit-Change-Number: 34997 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Nov 2023 13:48:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: client: replace two assertions with graceful error handling
by laforge 10 Nov '23

10 Nov '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email ) Change subject: client: replace two assertions with graceful error handling ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia5d8a9aff565399a85a5b116d7029fedcab234e0 Gerrit-Change-Number: 34997 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Nov 2023 13:45:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: ASCI: Notify talker in the VTY that he cannot leave the call while ta...
by jolly 10 Nov '23

10 Nov '23

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email ) Change subject: ASCI: Notify talker in the VTY that he cannot leave the call while talking ...................................................................... ASCI: Notify talker in the VTY that he cannot leave the call while talking Related: OS#5364 Change-Id: I497efc5bddc122cd5744de531917aad415ac1654 --- M src/host/layer23/src/mobile/gsm44068_gcc_bcc.c 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c index 65e016d..3a4db3a 100644 --- a/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c +++ b/src/host/layer23/src/mobile/gsm44068_gcc_bcc.c @@ -1855,6 +1855,8 @@ trans->gcc.fi->state == VGCS_GCC_ST_U2sl_GROUP_CALL_ACTIVE || trans->gcc.fi->state == VGCS_GCC_ST_U5_TERMINATION_REQUESTED) { LOG_GCC(trans, LOGL_NOTICE, "Cannot leave (abort), in this state.\n"); + if (trans->gcc.fi->state == VGCS_GCC_ST_U2sl_GROUP_CALL_ACTIVE) + vgcs_vty_notify(trans, "Cannot leave while talking\n"); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654 Gerrit-Change-Number: 34906 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo_dia2gsup[master]: rebar3: define a release
by lynxis lazus 10 Nov '23

10 Nov '23

Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284?usp=email ) Change subject: rebar3: define a release ...................................................................... Patch Set 2: (1 comment) File README.md: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284/comment/3c02869b_… PS1, Line 37: 1> osmo_dia2gsup:start(). > So far I tested it's enough to run rebar3 shell Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I76cb16e28b5bc6fb231566be1bd7905235fdf56b Gerrit-Change-Number: 34284 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Nov 2023 11:24:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: add imsi unknown cause test case
by lynxis lazus 10 Nov '23

10 Nov '23

Attention is currently required from: fixeria, laforge. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email ) Change subject: hlr: add imsi unknown cause test case ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: > a quick reminder, as a month has passed Done PS1: > ping? Done File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/551fa069_fdcf… PS1, Line 155: imsi unknown cause imsi-unknown > This syntax is not valid anymore, this is what we have in the VTY: […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/d19ad442_2af2… PS1, Line 983: f_TC_ul_unknown_imsi_roaming_not_allowed > I am confused reading this again: […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/c2fbbe5e_0347… PS1, Line 987: TC_gsup_ul_unknown_imsi_roaming_not_allowed > Please add it to the 'control' section below and update the expected-results.xml. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Nov 2023 11:22:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: add imsi unknown cause test case
by lynxis lazus 10 Nov '23

10 Nov '23

Attention is currently required from: fixeria, lynxis lazus. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by fixeria, Verified+1 by Jenkins Builder Change subject: hlr: add imsi unknown cause test case ...................................................................... hlr: add imsi unknown cause test case Check if the reject-cause is correct implement when the subscriber couldn't found. Depends-on: Icea39020c23fbbea9e92847df76af8986fdbf48a (osmo-hlr) Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a --- M hlr/HLR_Tests.ttcn 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/27569/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log