- gerrit-log - lists.osmocom.org

[L] Change in osmo-bsc[master]: tests/handover: move some functions to test/common
by neels 22 Nov '23

22 Nov '23

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30271?usp=email ) Change subject: tests/handover: move some functions to test/common ...................................................................... Abandoned the C tests that this patch is preparing for are not necessary, since we are adding tests in BSC_Tests.ttcn3 I9b4ddfc4a337808d9d5ec538c25fd390b1b2530f -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30271?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3df5b26ea3a6da1c1e125e07119a91c7458c6758 Gerrit-Change-Number: 30271 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 0

[S] Change in osmo-bsc[master]: use X6 timer for REL ACK, not T3111
by neels 22 Nov '23

22 Nov '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35088?usp=email ) Change subject: use X6 timer for REL ACK, not T3111 ...................................................................... use X6 timer for REL ACK, not T3111 The lchan FSM timers were originally implemented to model earlier code as closely as possible. Now it has come up that T3111 is used in the wrong place: 3GPP TS 44.018 says: T3111: This timer is used to delay the channel deactivation after disconnection of the main signalling link. Its purpose is to let some time for possible repetition of the disconnection. Its value is equal to the value of T3110. Before this patch, we use it also to time the RF REL ACK message. That is pretty bad, because T3111 is only 2 seconds by default, making RF CHAN REL vulnerable for timeout. When a user increased T3111 to alleviate the problem, the result is that each lchan also delays its normal channel release procedure by the configured amount of time. Very inelegant. Instead, use the X6 timer for REL ACK, because X6 already times the CHAN ACTIV ACK, which is semantically identical. Compatibility / user impact: No negative impact expected. We can assume that every user out there has X6 configured to work for CHAN ACTIV ACK. From that logic, switching channel release ACK to the same timer is guaranteed to be what the user intends. We could instruct users in the release notes that they may now choose T3111 freely (as short as 2 seconds) without jeopardising channel release anymore. Related: SYS#6655 Change-Id: Ibd118fa23e5deb4381bc31b11a7b495f57901d6c --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 40 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/35088/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 1b012bd..d6dfe3a 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -330,7 +330,7 @@ [LCHAN_ST_WAIT_RLL_RTP_ESTABLISH] = { .T = 3101 }, [LCHAN_ST_WAIT_RLL_RTP_RELEASED] = { .T = 3109 }, [LCHAN_ST_WAIT_BEFORE_RF_RELEASE] = { .T = 3111 }, - [LCHAN_ST_WAIT_RF_RELEASE_ACK] = { .T = 3111 }, + [LCHAN_ST_WAIT_RF_RELEASE_ACK] = { .T = -6 }, [LCHAN_ST_WAIT_AFTER_ERROR] = { .T = -3111 }, [LCHAN_ST_WAIT_RR_CHAN_MODE_MODIFY_ACK] = { .T = -13 }, [LCHAN_ST_WAIT_RSL_CHAN_MODE_MODIFY_ACK] = { .T = -14 }, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd118fa23e5deb4381bc31b11a7b495f57901d6c Gerrit-Change-Number: 35088 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: osmo_io: Assert that iofd mode is correct when calling *_write_msgb
by laforge 21 Nov '23

21 Nov '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35077?usp=email ) Change subject: osmo_io: Assert that iofd mode is correct when calling *_write_msgb ...................................................................... osmo_io: Assert that iofd mode is correct when calling *_write_msgb Change-Id: Ief82ba7f9b280f85d66d68c358c36ba9866fe47a Fixes: OS#6264 --- M src/core/osmo_io.c 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 2b2b7dd..f23986f 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -356,6 +356,7 @@ { int rc; + OSMO_ASSERT(iofd->mode == OSMO_IO_FD_MODE_READ_WRITE); if (OSMO_UNLIKELY(!iofd->io_ops.write_cb)) { LOGPIO(iofd, LOGL_ERROR, "write_cb not set, Rejecting msgb\n"); return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ief82ba7f9b280f85d66d68c358c36ba9866fe47a Gerrit-Change-Number: 35077 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: osmo_io: Assert that iofd mode is correct when calling *_write_msgb
by laforge 21 Nov '23

21 Nov '23

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35077?usp=email ) Change subject: osmo_io: Assert that iofd mode is correct when calling *_write_msgb ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ief82ba7f9b280f85d66d68c358c36ba9866fe47a Gerrit-Change-Number: 35077 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Nov 2023 21:02:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-sccp[master]: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd()
by laforge 21 Nov '23

21 Nov '23

Attention is currently required from: arehbein, daniel. Hello Jenkins Builder, arehbein, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35073?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review-1 by arehbein, Verified-1 by Jenkins Builder Change subject: port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd() ...................................................................... port from osmo_stream_*_get_ofd() to osmo_stream_srv_get_fd() The existing/old osmo_stream_{srv,cli}_get_ofd() API functions are only compatible with OSMO_FD mode of libosmo-netif/stream. In the OSMO_IO mode, there is no osmo_fd involved, and hence those functions are illegal to call. Let's instead migrate over to the new osmo_stream_{srv,cli}_get_fd() which directly return the file descriptor integer value. Change-Id: I12c66badfb4bdfdfe71f1716de960d353d3548b1 Related: OS#5752 --- M TODO-RELEASE M src/osmo_ss7_asp.c M src/osmo_ss7_vty.c M src/xua_asp_fsm.c 4 files changed, 68 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/73/35073/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I12c66badfb4bdfdfe71f1716de960d353d3548b1 Gerrit-Change-Number: 35073 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: add new osmo_sockaddr_from_str_and_uint() function
by fixeria 21 Nov '23

21 Nov '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35085?usp=email ) Change subject: add new osmo_sockaddr_from_str_and_uint() function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6b5c0bf8ca97e6358d992fb2ff45ffd53ba15197 Gerrit-Change-Number: 35085 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 21 Nov 2023 20:13:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: extend TC_early_immediate_assignment: run on trx_nr=1
by fixeria 21 Nov '23

21 Nov '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35087?usp=email ) Change subject: BTS_Tests: extend TC_early_immediate_assignment: run on trx_nr=1 ...................................................................... BTS_Tests: extend TC_early_immediate_assignment: run on trx_nr=1 This patch demonstrates the problem with handling of the Early IA: * the first part remains unchanged: assign a channel on C0 (arfcn=871); * the second (new) part tests channel assignment on C1 (arfcn=873). As of now, osmo-bts does not meet our expectations for the second part. Change-Id: I7517574a8095ddfa05c34c4c3d4accf2bd07894b Related: SYS#6655 --- M bts/BTS_Tests.ttcn 1 file changed, 31 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/87/35087/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index d667344..82a83cf 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8815,10 +8815,11 @@ if (g_pars.fhp.enabled) { ch_desc := valueof(ts_ChanDescH1(g_pars.chan_nr, g_pars.fhp.maio_hsn, g_pars.tsc)); } else { - ch_desc := valueof(ts_ChanDescH0(g_pars.chan_nr, mp_trx_pars[0].arfcn, g_pars.tsc)); + var GsmArfcn arfcn := mp_trx_pars[g_pars.trx_nr].arfcn; + ch_desc := valueof(ts_ChanDescH0(g_pars.chan_nr, arfcn, g_pars.tsc)); } var GsmRrMessage rr_msg := valueof(ts_IMM_ASS(ra, fn, 0, ch_desc, g_pars.fhp.ma_map)); - RSL.send(ts_RSL_IMM_ASSIGN(enc_GsmRrMessage(rr_msg))); + RSL.send(ts_ASP_RSL_UD(ts_RSL_IMM_ASSIGN(enc_GsmRrMessage(rr_msg)))); /* force sending to TRX0 */ /* Do not expect the Immediate Assignment to show up on MS side yet. Even give it one second before the BSC * requests Chan Activ, to make sure the RR IMM ASS is held back. */ @@ -8859,10 +8860,20 @@ testcase TC_early_immediate_assignment() runs on test_CT { var ConnHdlr vc_conn; - var ConnHdlrPars pars := valueof(t_Pars(t_RslChanNr_Bm(1), ts_RSL_ChanMode_SIGN)); + var ConnHdlrPars pars; + f_init(); + + /* verify early Immediate Assignment on C0 (the BCCH carrier): TCH/F on TS1 */ + pars := valueof(t_Pars(t_RslChanNr_Bm(1), ts_RSL_ChanMode_SIGN, trx_nr := 0)); vc_conn := f_start_handler(refers(f_TC_early_immediate_assignment), pars); vc_conn.done; + + /* verify early Immediate Assignment on C1: TCH/F on TS0 */ + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, trx_nr := 1)); + vc_conn := f_start_handler(refers(f_TC_early_immediate_assignment), pars); + vc_conn.done; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7517574a8095ddfa05c34c4c3d4accf2bd07894b Gerrit-Change-Number: 35087 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: RSL_Emulation: allow RSL_DchanHdlr sandbox escape for both roles
by fixeria 21 Nov '23

21 Nov '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35086?usp=email ) Change subject: RSL_Emulation: allow RSL_DchanHdlr sandbox escape for both roles ...................................................................... RSL_Emulation: allow RSL_DchanHdlr sandbox escape for both roles This feature was initially added in 1470fc668 for the RSL_Emulation_CT operating in the BTS role. In a subsequent patch I also need to escape the sandbox, but in my case the RSL_Emulation_CT is playing the BSC role. Change-Id: I42557f85d3e5e7ef7147a87293f5dd1716884534 Related: 1470fc668 "allow ASP_RSL_UD on MSC_ConnHdlr RSL" Related: SYS#6655 --- M library/RSL_Emulation.ttcn 1 file changed, 25 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/35086/1 diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn index effe83b..891e565 100644 --- a/library/RSL_Emulation.ttcn +++ b/library/RSL_Emulation.ttcn @@ -651,15 +651,22 @@ cid := f_cid_by_comp_ref(vc_conn); IPA_PT.send(ts_ASP_RSL_UD(rx_rsl_msg, ConnectionTable[cid].stream_id)); } - [bts_role] CLIENT_PT.receive(tr_ASP_RSL_UD(?, sid := ?)) -> value rx_rsl { - IPA_PT.send(ts_ASP_RSL_UD(rx_rsl.rsl, rx_rsl.streamId)); - } [not bts_role] CLIENT_PT.receive(tr_RSL_MsgType(?)) -> value rx_rsl_msg sender vc_conn { cid := f_cid_by_comp_ref(vc_conn); conn_id := f_trx_conn_map_resolve(ConnectionTable[cid].stream_id); IPA_PT.send(ts_ASP_RSL_UD(rx_rsl_msg, ConnectionTable[cid].stream_id, conn_id)); } + /* allow the RSL_DchanHdlr components to "escape the sandbox" by sending RSL messages + * to other transceivers than they're bound to (determined by rx_rsl.streamId) */ + [bts_role] CLIENT_PT.receive(tr_ASP_RSL_UD(?, sid := ?)) -> value rx_rsl { + IPA_PT.send(ts_ASP_RSL_UD(rx_rsl.rsl, rx_rsl.streamId)); + } + [not bts_role] CLIENT_PT.receive(tr_ASP_RSL_UD(?, sid := ?)) -> value rx_rsl { + conn_id := f_trx_conn_map_resolve(rx_rsl.streamId); + IPA_PT.send(ts_ASP_RSL_UD(rx_rsl.rsl, rx_rsl.streamId, conn_id)); + } + /* RSL message from MTC */ [bts_role] CCHAN_PT.receive(tr_ASP_RSL_UD(?, sid := ?)) -> value rx_rsl { IPA_PT.send(ts_ASP_RSL_UD(rx_rsl.rsl, rx_rsl.streamId)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35086?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42557f85d3e5e7ef7147a87293f5dd1716884534 Gerrit-Change-Number: 35086 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-netif[master]: Introduce generic osmo_stream_{cli,srv}_get_fd() API
by fixeria 21 Nov '23

21 Nov '23

Attention is currently required from: daniel, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email ) Change subject: Introduce generic osmo_stream_{cli,srv}_get_fd() API ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib0737f21150f6ac8d524b92c7ddb098f2afdeaab Gerrit-Change-Number: 35072 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Nov 2023 19:26:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-netif[master]: Introduce generic osmo_stream_{cli,srv}_get_fd() API
by laforge 21 Nov '23

21 Nov '23

Attention is currently required from: daniel, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email ) Change subject: Introduce generic osmo_stream_{cli,srv}_get_fd() API ...................................................................... Patch Set 2: (2 comments) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/35072/comment/1b1d7c50_9bab7d38 PS1, Line 214: to modify > I guess I meant to say that this comment is not actually related to this function, because the `*cli […] Done https://gerrit.osmocom.org/c/libosmo-netif/+/35072/comment/d6d3a9e0_70e3d1f8 PS1, Line 215: File descriptor > `... […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib0737f21150f6ac8d524b92c7ddb098f2afdeaab Gerrit-Change-Number: 35072 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Nov 2023 19:25:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log