- gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload
by jolly 29 Nov '23

29 Nov '23

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload ...................................................................... LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload A special flag is used to keep track on the establishment of the data link. If it is being established (not re-established) without L3 payload, it is rejected by a release request inside BTS. Related: OS#5971 Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c --- M include/osmo-bts/lchan.h M src/common/lchan.c M src/common/rsl.c 3 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/82/35082/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c Gerrit-Change-Number: 35082 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in docker-playground[master]: Revert "ttcn3-pcu-test/sns: fix PCUIF version number"
by dexter 29 Nov '23

29 Nov '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35158?usp=email ) Change subject: Revert "ttcn3-pcu-test/sns: fix PCUIF version number" ...................................................................... Revert "ttcn3-pcu-test/sns: fix PCUIF version number" Unfortunately this patch only fixes ttcn3-pcu-test-sns but it breaks ttcn3-pcu-test-sns-latest, this means a different solution is needed. This reverts commit c9820d7b36eb3f75c32d193394da46aad9406cb2. Change-Id: I101d27ae8ed7449b199e49795a3561436c2532dd Related: OS#6275 --- M ttcn3-pcu-test/jenkins-sns.sh M ttcn3-pcu-test/sns/PCU_Tests.cfg 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/ttcn3-pcu-test/jenkins-sns.sh b/ttcn3-pcu-test/jenkins-sns.sh index d63229b..50027d3 100755 --- a/ttcn3-pcu-test/jenkins-sns.sh +++ b/ttcn3-pcu-test/jenkins-sns.sh @@ -11,7 +11,7 @@ set_pcuif_version() { if image_suffix_is_2023q1; then - sed -i 's/PCUIF_Types.mp_pcuif_version := 12/PCUIF_Types.mp_pcuif_version := 10/g' $1 + sed -i 's/PCUIF_Types.mp_pcuif_version := 11/PCUIF_Types.mp_pcuif_version := 10/g' $1 fi } diff --git a/ttcn3-pcu-test/sns/PCU_Tests.cfg b/ttcn3-pcu-test/sns/PCU_Tests.cfg index 2b11462..d62f52d 100644 --- a/ttcn3-pcu-test/sns/PCU_Tests.cfg +++ b/ttcn3-pcu-test/sns/PCU_Tests.cfg @@ -59,7 +59,7 @@ } } } -PCUIF_Types.mp_pcuif_version := 12 +PCUIF_Types.mp_pcuif_version := 11 [MAIN_CONTROLLER] -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I101d27ae8ed7449b199e49795a3561436c2532dd Gerrit-Change-Number: 35158 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: Revert "ttcn3-pcu-test/sns: fix PCUIF version number"
by dexter 29 Nov '23

29 Nov '23

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35158?usp=email ) Change subject: Revert "ttcn3-pcu-test/sns: fix PCUIF version number" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I101d27ae8ed7449b199e49795a3561436c2532dd Gerrit-Change-Number: 35158 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Nov 2023 10:03:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)
by dexter 29 Nov '23

29 Nov '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch) ...................................................................... ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch) Unfortunately we had to revert [1] because it worked for current master but not for latest. The mistake here was to change the PCUIF version number in PCU_Tests.cfg to PCUIF v12. This is indeed the correct version for current master, but latest still uses v11. Also the change we made in jenkins-sns only affected 2023q1 builds, it does not affect latest. This is the reason why the previous patch broke latest. This follow up patch now copies the approach we already successfully use with the normal ttcn3-pcu-test / ttcn3-pcu-test-latest. (see also jenkins.sh) [1] I0b37f01f4c7bb829053231339e39ab734f4c8cbc Change-Id: I1f94a0459e35d7b5632c81d7f7e2e60eb0d0229f Related: OS#6275 --- M ttcn3-pcu-test/jenkins-sns.sh 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/59/35159/1 diff --git a/ttcn3-pcu-test/jenkins-sns.sh b/ttcn3-pcu-test/jenkins-sns.sh index 50027d3..06f833e 100755 --- a/ttcn3-pcu-test/jenkins-sns.sh +++ b/ttcn3-pcu-test/jenkins-sns.sh @@ -13,6 +13,15 @@ if image_suffix_is_2023q1; then sed -i 's/PCUIF_Types.mp_pcuif_version := 11/PCUIF_Types.mp_pcuif_version := 10/g' $1 fi + + # This changes the PCUIF module parameter of the TTCN3 testsuite when the testsuite is + # executed for current master. For latest the PCUIF module parameter must stay at v.11 + # since in osmo-pcu-latest PCUIF v.12 is not yet supported. After the next release, PCUIF + # v.12 will be supported in osmo-pcu-latest as well and this function, including the + # PCUIF_Types.mp_pcuif_version setting in the configuration files can be removed. + if image_suffix_is_master; then + sed -i 's/PCUIF_Types.mp_pcuif_version := 11/PCUIF_Types.mp_pcuif_version := 12/g' $1 + fi } mkdir $VOL_BASE_DIR/pcu-tester -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1f94a0459e35d7b5632c81d7f7e2e60eb0d0229f Gerrit-Change-Number: 35159 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: Revert "ttcn3-pcu-test/sns: fix PCUIF version number"
by dexter 29 Nov '23

29 Nov '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35158?usp=email ) Change subject: Revert "ttcn3-pcu-test/sns: fix PCUIF version number" ...................................................................... Revert "ttcn3-pcu-test/sns: fix PCUIF version number" Unfortunately this patch only fixes ttcn3-pcu-test-sns but it breaks ttcn3-pcu-test-sns-latest, this means a different solution is needed. This reverts commit c9820d7b36eb3f75c32d193394da46aad9406cb2. Change-Id: I101d27ae8ed7449b199e49795a3561436c2532dd Related: OS#6275 --- M ttcn3-pcu-test/jenkins-sns.sh M ttcn3-pcu-test/sns/PCU_Tests.cfg 2 files changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/58/35158/1 diff --git a/ttcn3-pcu-test/jenkins-sns.sh b/ttcn3-pcu-test/jenkins-sns.sh index d63229b..50027d3 100755 --- a/ttcn3-pcu-test/jenkins-sns.sh +++ b/ttcn3-pcu-test/jenkins-sns.sh @@ -11,7 +11,7 @@ set_pcuif_version() { if image_suffix_is_2023q1; then - sed -i 's/PCUIF_Types.mp_pcuif_version := 12/PCUIF_Types.mp_pcuif_version := 10/g' $1 + sed -i 's/PCUIF_Types.mp_pcuif_version := 11/PCUIF_Types.mp_pcuif_version := 10/g' $1 fi } diff --git a/ttcn3-pcu-test/sns/PCU_Tests.cfg b/ttcn3-pcu-test/sns/PCU_Tests.cfg index 2b11462..d62f52d 100644 --- a/ttcn3-pcu-test/sns/PCU_Tests.cfg +++ b/ttcn3-pcu-test/sns/PCU_Tests.cfg @@ -59,7 +59,7 @@ } } } -PCUIF_Types.mp_pcuif_version := 12 +PCUIF_Types.mp_pcuif_version := 11 [MAIN_CONTROLLER] -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I101d27ae8ed7449b199e49795a3561436c2532dd Gerrit-Change-Number: 35158 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-tester[master]: Update git URLs
by osmith 29 Nov '23

29 Nov '23

osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I03a06d23e87a75257eb731a97facd7a67c40a2c6 Gerrit-Change-Number: 35157 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 0

[S] Change in osmo-gsm-tester[master]: Update git URLs
by osmith 29 Nov '23

29 Nov '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: I've verified that this fixes the url related failures in various osmo-gsm-tester jenkins jobs. gerrit verification is known to be broken: https://osmocom.org/issues/6149 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I03a06d23e87a75257eb731a97facd7a67c40a2c6 Gerrit-Change-Number: 35157 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Nov 2023 09:55:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Fix union abis_rsl_chan_nr and abis_rsl_link_id
by fixeria 29 Nov '23

29 Nov '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35156?usp=email ) Change subject: Fix union abis_rsl_chan_nr and abis_rsl_link_id ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ef5aa62be8310da4ebe9ea73ebbedcbcc2ba49c Gerrit-Change-Number: 35156 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 29 Nov 2023 09:50:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-tester[master]: Update git URLs
by osmith 29 Nov '23

29 Nov '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs ...................................................................... Update git URLs git.osmocom.org has been deprecated, use gerrit or gitea urls instead. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Git_infrastructure Related: OS#6251 Change-Id: I03a06d23e87a75257eb731a97facd7a67c40a2c6 --- M README.md M contrib/jenkins-build-common.sh M contrib/jenkins-build-manuals.sh M contrib/jenkins-build-osmo-bts.sh M doc/manuals/chapters/ansible.adoc M doc/manuals/chapters/docker.adoc M doc/manuals/osmo-gsm-tester-manual-docinfo.xml M src/osmo_gsm_tester/obj/osmo_vty.py M sysmocom/ttcn3/README.txt 9 files changed, 32 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/57/35157/1 diff --git a/README.md b/README.md index 3394969..9bc1dcf 100644 --- a/README.md +++ b/README.md @@ -16,11 +16,12 @@ Ansible scripts to set up hosts to be used as Osmo-GSM-Tester Main Units or/and Slave Units on the above mentioned setup can be found at -https://git.osmocom.org/osmo-ci/tree/ansible, which actually install sample -system configuration files from _utils/_ directory in this same repository. +https://gitea.osmocom.org/osmocom/osmo-ci/src/branch/master/ansible, which +actually install sample system configuration files from _utils/_ directory in +this same repository. A sample Docker setup is also maintained publicly at -https://git.osmocom.org/docker-playground/tree/osmo-gsm-tester. +https://gitea.osmocom.org/osmocom/docker-playground/src/branch/master/osmo-gsm-tester. For the complete documentation, please refer to Osmo-GSM-Tester User manual, available in sources under _doc/manuals/_ under this same repository, and diff --git a/contrib/jenkins-build-common.sh b/contrib/jenkins-build-common.sh index b41fc05..59d0d11 100644 --- a/contrib/jenkins-build-common.sh +++ b/contrib/jenkins-build-common.sh @@ -42,7 +42,7 @@ exit 1 fi -git_url="${git_url:-https://git.osmocom.org}" +git_url="${git_url:-https://gerrit.osmocom.org}" prefix="${prefix:-$base/inst-$name}" # prefix_real is usually identical with prefix, except when installing to a # different $DESTDIR than /, which is the case for example when building diff --git a/contrib/jenkins-build-manuals.sh b/contrib/jenkins-build-manuals.sh index 48f7780..cf2a4d8 100755 --- a/contrib/jenkins-build-manuals.sh +++ b/contrib/jenkins-build-manuals.sh @@ -15,7 +15,7 @@ if [ -d "$OSMO_GSM_MANUALS_DIR" ]; then git -C "$OSMO_GSM_MANUALS_DIR" pull else - git clone "https://git.osmocom.org/osmo-gsm-manuals" "$OSMO_GSM_MANUALS_DIR" + git clone "https://gerrit.osmocom.org/osmo-gsm-manuals" "$OSMO_GSM_MANUALS_DIR" fi git -C "$OSMO_GSM_MANUALS_DIR" checkout -f HEAD diff --git a/contrib/jenkins-build-osmo-bts.sh b/contrib/jenkins-build-osmo-bts.sh index 6e9416a..d0b9e02 100755 --- a/contrib/jenkins-build-osmo-bts.sh +++ b/contrib/jenkins-build-osmo-bts.sh @@ -4,7 +4,8 @@ name="osmo-bts" . "$(dirname "$0")/jenkins-build-common.sh" -have_repo octphy-2g-headers +(git_url=https://gitea.osmocom.org/cellular-infrastructure + have_repo octphy-2g-headers) build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi diff --git a/doc/manuals/chapters/ansible.adoc b/doc/manuals/chapters/ansible.adoc index 4c80723..d8970aa 100644 --- a/doc/manuals/chapters/ansible.adoc +++ b/doc/manuals/chapters/ansible.adoc @@ -5,8 +5,8 @@ and tedious, nowadays the Osmocom RnD and Production {app-name} setups are installed and maintained using Ansible scripts. The set of ansible scripts is available in Osmocom's git repository -link:https://git.osmocom.org/osmo-ci/[osmo-ci.git] under 'ansible' subdirectory, -with the rest of ansible scripts to set jenkins slaves, etc. +link:https://gitea.osmocom.org/osmocom/osmo-ci/[osmo-ci.git] under 'ansible' +subdirectory, with the rest of ansible scripts to set jenkins slaves, etc. Since these set of scripts is mainly aimed at Osmocom's own setup, and debian is used there, so far only debian hosts are supported officially, though patches to diff --git a/doc/manuals/chapters/docker.adoc b/doc/manuals/chapters/docker.adoc index bc8ad00..985edc3 100644 --- a/doc/manuals/chapters/docker.adoc +++ b/doc/manuals/chapters/docker.adoc @@ -3,8 +3,8 @@ A sample {app-name} setup based on docker containers and maintained by the Osmocom community is available in Osmocom's git repository -link:https://git.osmocom.org/docker-playground/[docker-playground.git], under -'osmo-gsm-tester' subdirectory. In there, one can find: +link:https://gitea.osmocom.org/osmocom/docker-playground/[docker-playground.git], +under 'osmo-gsm-tester' subdirectory. In there, one can find: - A 'Dockerfile' file can be found which builds a docker image which can be used both to run as an osmo-gsm-tester <<install_main_unit,Main Unit>> or as diff --git a/doc/manuals/osmo-gsm-tester-manual-docinfo.xml b/doc/manuals/osmo-gsm-tester-manual-docinfo.xml index d7b112f..d59fc73 100644 --- a/doc/manuals/osmo-gsm-tester-manual-docinfo.xml +++ b/doc/manuals/osmo-gsm-tester-manual-docinfo.xml @@ -51,8 +51,8 @@ </para> <para> The Asciidoc source code of this manual can be found at - <ulink url="http://git.osmocom.org/osmo-gsm-manuals/"> - http://git.osmocom.org/osmo-gsm-manuals/ + <ulink url="https://gitea.osmocom.org/cellular-infrastructure/osmo-gsm-manuals"> + https://gitea.osmocom.org/cellular-infrastructure/osmo-gsm-manuals </ulink> </para> </legalnotice> diff --git a/src/osmo_gsm_tester/obj/osmo_vty.py b/src/osmo_gsm_tester/obj/osmo_vty.py index 1b414c9..f917070 100644 --- a/src/osmo_gsm_tester/obj/osmo_vty.py +++ b/src/osmo_gsm_tester/obj/osmo_vty.py @@ -80,7 +80,7 @@ def _command(self, command_str, timeout=10, strict=True): '''Send a command and return the response.''' - # (copied from https://git.osmocom.org/python/osmo-python-tests/tree/osmopy/osmo_interact/…) + # (copied from osmo-python-tests/osmopy/osmo_interact/vty.py) self.dbg('Sending', command_str=command_str) self.sck.send(command_str.encode()) @@ -159,7 +159,7 @@ self.sck.setblocking(1) # read first prompt - # (copied from https://git.osmocom.org/python/osmo-python-tests/tree/osmopy/osmo_interact/…) + # (copied from osmo-python-tests/osmopy/osmo_interact/vty.py) self.this_node = None self.this_prompt_char = '>' # slight cheat for initial prompt char self.last_node = None @@ -209,7 +209,7 @@ with self: return self.cmd(command_str, timeout, strict) - # (copied from https://git.osmocom.org/python/osmo-python-tests/tree/osmopy/osmo_interact/…) + # (copied from osmo-python-tests/osmopy/osmo_interact/vty.py) command_str = command_str or '\r' if command_str[-1] not in '?\r\t': command_str = command_str + '\r' diff --git a/sysmocom/ttcn3/README.txt b/sysmocom/ttcn3/README.txt index 3886c80..2e10105 100644 --- a/sysmocom/ttcn3/README.txt +++ b/sysmocom/ttcn3/README.txt @@ -1,5 +1,6 @@ This directory contains a set of scripts and osmo-gsm-tester testsuites to run -osmo-ttcn3-hacks.git BTS_tests.ttcn (https://git.osmocom.org/osmo-ttcn3-hacks/tree/bts). +osmo-ttcn3-hacks.git BTS_tests.ttcn +(https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/branch/master/bts). The idea is to set up automatically the following components: TTCN3 <-> osmocon (osmocom-bb) <-> motorola C123 <-> RF network <-> BTS_TO_TEST <-> TTCN3 + osmo-bsc -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I03a06d23e87a75257eb731a97facd7a67c40a2c6 Gerrit-Change-Number: 35157 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: Fix union abis_rsl_chan_nr and abis_rsl_link_id
by laforge 29 Nov '23

29 Nov '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35156?usp=email ) Change subject: Fix union abis_rsl_chan_nr and abis_rsl_link_id ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: this is *very* interesting. I would have assumed that an union of two uint8_t is again just maps the uint8_t together - and not the individual bits in the bit-fields. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ef5aa62be8310da4ebe9ea73ebbedcbcc2ba49c Gerrit-Change-Number: 35156 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 29 Nov 2023 09:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log