- gerrit-log - lists.osmocom.org

[S] Change in osmo-e1d[master]: Use uniform log format for default config files
by jolly 01 Dec '23

01 Dec '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I4a8cb558816534ac942bc38ff0b178849d610457 --- M doc/examples/osmo-e1d-octoi-client.cfg M doc/examples/osmo-e1d-octoi-server.cfg M doc/examples/osmo-e1d-vpair.cfg 3 files changed, 24 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/86/35186/1 diff --git a/doc/examples/osmo-e1d-octoi-client.cfg b/doc/examples/osmo-e1d-octoi-client.cfg index ddb981c..88a0e48 100644 --- a/doc/examples/osmo-e1d-octoi-client.cfg +++ b/doc/examples/osmo-e1d-octoi-client.cfg @@ -7,9 +7,9 @@ logging color 1 logging print category-hex 0 logging print category 1 - logging print thread-id 0 - logging timestamp 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level e1d info logging level linp info ! diff --git a/doc/examples/osmo-e1d-octoi-server.cfg b/doc/examples/osmo-e1d-octoi-server.cfg index ac5e2b7..32eb227 100644 --- a/doc/examples/osmo-e1d-octoi-server.cfg +++ b/doc/examples/osmo-e1d-octoi-server.cfg @@ -8,8 +8,9 @@ logging print category-hex 0 logging print category 1 logging print thread-id 0 - logging timestamp 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level e1d info logging level linp info ! diff --git a/doc/examples/osmo-e1d-vpair.cfg b/doc/examples/osmo-e1d-vpair.cfg index 04bdb72..265a5d0 100644 --- a/doc/examples/osmo-e1d-vpair.cfg +++ b/doc/examples/osmo-e1d-vpair.cfg @@ -1,2 +1,10 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1d virtual-e1-pair 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4a8cb558816534ac942bc38ff0b178849d610457 Gerrit-Change-Number: 35186 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-cbc[master]: Use uniform log format for default config files
by jolly 01 Dec '23

01 Dec '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I9897bf964880f2e35a59812d319851eb6e06de68 --- M doc/examples/osmo-cbc/osmo-cbc.cfg 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/85/35185/1 diff --git a/doc/examples/osmo-cbc/osmo-cbc.cfg b/doc/examples/osmo-cbc/osmo-cbc.cfg index 9874a39..5310268 100644 --- a/doc/examples/osmo-cbc/osmo-cbc.cfg +++ b/doc/examples/osmo-cbc/osmo-cbc.cfg @@ -1,4 +1,10 @@ log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level main notice logging level smscb notice logging level cbsp notice -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/35185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9897bf964880f2e35a59812d319851eb6e06de68 Gerrit-Change-Number: 35185 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: Use uniform log format for default config files
by jolly 01 Dec '23

01 Dec '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/35184?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I08b297ea78e7cd60f28f0df79f2096f70c0692c6 --- M doc/examples/litecell15/lc15bts-mgr.cfg M doc/examples/litecell15/osmo-bts-lc15.cfg M doc/examples/oc2g/oc2gbts-mgr.cfg M doc/examples/oc2g/osmo-bts-oc2g.cfg M doc/examples/octphy/osmo-bts-octphy.cfg M doc/examples/octphy/osmo-bts-trx2dsp1.cfg M doc/examples/sysmo/osmo-bts-sysmo.cfg M doc/examples/sysmo/sysmobts-mgr.cfg M doc/examples/trx/osmo-bts-trx-calypso.cfg M doc/examples/trx/osmo-bts-trx.cfg M doc/examples/virtual/osmo-bts-virtual.cfg 11 files changed, 54 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/35184/1 diff --git a/doc/examples/litecell15/lc15bts-mgr.cfg b/doc/examples/litecell15/lc15bts-mgr.cfg index a92a3fd..850fb15 100644 --- a/doc/examples/litecell15/lc15bts-mgr.cfg +++ b/doc/examples/litecell15/lc15bts-mgr.cfg @@ -3,10 +3,12 @@ !! ! log stderr - logging filter all 1 logging color 1 - logging print category 0 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level temp info logging level fw info logging level find info diff --git a/doc/examples/litecell15/osmo-bts-lc15.cfg b/doc/examples/litecell15/osmo-bts-lc15.cfg index 907d83a..16651eb 100644 --- a/doc/examples/litecell15/osmo-bts-lc15.cfg +++ b/doc/examples/litecell15/osmo-bts-lc15.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/oc2g/oc2gbts-mgr.cfg b/doc/examples/oc2g/oc2gbts-mgr.cfg index 8248f60..ce72e5d 100644 --- a/doc/examples/oc2g/oc2gbts-mgr.cfg +++ b/doc/examples/oc2g/oc2gbts-mgr.cfg @@ -3,10 +3,12 @@ !! ! log stderr - logging filter all 1 logging color 1 - logging print category 0 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level temp info logging level fw info logging level find info diff --git a/doc/examples/oc2g/osmo-bts-oc2g.cfg b/doc/examples/oc2g/osmo-bts-oc2g.cfg index f985f3b..ddf69f4 100644 --- a/doc/examples/oc2g/osmo-bts-oc2g.cfg +++ b/doc/examples/oc2g/osmo-bts-oc2g.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/octphy/osmo-bts-octphy.cfg b/doc/examples/octphy/osmo-bts-octphy.cfg index d6d03b5..a3a0093 100644 --- a/doc/examples/octphy/osmo-bts-octphy.cfg +++ b/doc/examples/octphy/osmo-bts-octphy.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/octphy/osmo-bts-trx2dsp1.cfg b/doc/examples/octphy/osmo-bts-trx2dsp1.cfg index bf590f7..477bff8 100644 --- a/doc/examples/octphy/osmo-bts-trx2dsp1.cfg +++ b/doc/examples/octphy/osmo-bts-trx2dsp1.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/sysmo/osmo-bts-sysmo.cfg b/doc/examples/sysmo/osmo-bts-sysmo.cfg index 6ff043d..f44c718 100644 --- a/doc/examples/sysmo/osmo-bts-sysmo.cfg +++ b/doc/examples/sysmo/osmo-bts-sysmo.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice diff --git a/doc/examples/sysmo/sysmobts-mgr.cfg b/doc/examples/sysmo/sysmobts-mgr.cfg index f891ada..00be2fd 100644 --- a/doc/examples/sysmo/sysmobts-mgr.cfg +++ b/doc/examples/sysmo/sysmobts-mgr.cfg @@ -3,9 +3,12 @@ !! ! log stderr - logging filter all 1 logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level temp info logging level fw info logging level find info diff --git a/doc/examples/trx/osmo-bts-trx-calypso.cfg b/doc/examples/trx/osmo-bts-trx-calypso.cfg index d6cc43a..018744f 100644 --- a/doc/examples/trx/osmo-bts-trx-calypso.cfg +++ b/doc/examples/trx/osmo-bts-trx-calypso.cfg @@ -5,7 +5,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl notice logging level oml notice logging level rll notice diff --git a/doc/examples/trx/osmo-bts-trx.cfg b/doc/examples/trx/osmo-bts-trx.cfg index 81313e5..6b23952 100644 --- a/doc/examples/trx/osmo-bts-trx.cfg +++ b/doc/examples/trx/osmo-bts-trx.cfg @@ -4,7 +4,11 @@ ! log stderr logging color 1 + logging print category-hex 0 + logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl notice logging level oml notice logging level rll notice diff --git a/doc/examples/virtual/osmo-bts-virtual.cfg b/doc/examples/virtual/osmo-bts-virtual.cfg index 13bc0e5..4663f17 100644 --- a/doc/examples/virtual/osmo-bts-virtual.cfg +++ b/doc/examples/virtual/osmo-bts-virtual.cfg @@ -3,10 +3,12 @@ !! ! log stderr - logging filter all 1 - logging color 0 + logging color 1 + logging print category-hex 0 logging print category 1 logging timestamp 0 + logging print file basename last + logging print level 1 logging level rsl info logging level oml info logging level rll notice -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I08b297ea78e7cd60f28f0df79f2096f70c0692c6 Gerrit-Change-Number: 35184 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc-nat[master]: Use uniform log format for default config files
by jolly 01 Dec '23

01 Dec '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I811f7ede8d8b5ae4036bfd9cb530b1100ba0fb07 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/83/35183/1 diff --git a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg index ef6b1ae..49daec9 100644 --- a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg +++ b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + cs7 instance 0 point-code 0.23.3 asp asp-clnt-OsmoBSCNAT-CN 2905 0 m3ua -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/35183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I811f7ede8d8b5ae4036bfd9cb530b1100ba0fb07 Gerrit-Change-Number: 35183 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: Use uniform log format for default config files
by jolly 01 Dec '23

01 Dec '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35182?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I992ff466db768f625dd722d40829aa0301cc1705 --- M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg M doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg M doc/examples/osmo-bsc/osmo-bsc-4trx.cfg M doc/examples/osmo-bsc/osmo-bsc-minimal.cfg M doc/examples/osmo-bsc/osmo-bsc.cfg M doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg M doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg 12 files changed, 84 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/35182/1 diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg index 7d676d6..22c70b9 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus01-4trx.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg index 38e7afb..79ebca9 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg @@ -10,6 +10,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg index 1f33577..4487ff0 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg index 464b37f..7e87bab 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-4trx.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg index 844bf05..dd015c0 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-8trx.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg index 82283c8..e61acc0 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.rbs2308.cfg @@ -7,6 +7,12 @@ no login ! log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level lmi info logging level linp info logging level nm debug diff --git a/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg b/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg index 0b0afa8..34ffa99 100644 --- a/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg +++ b/doc/examples/osmo-bsc/nokia/osmo-bsc.insite.cfg @@ -11,7 +11,9 @@ logging color 1 logging print category-hex 0 logging print category 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level llapd notice logging level nm debug e1_input diff --git a/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg b/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg index 786813a..03c3477 100644 --- a/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc-4trx.cfg @@ -1,4 +1,12 @@ ! osmo-bsc configuration example with 4 TRX +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1_input e1_line 0 driver ipa network diff --git a/doc/examples/osmo-bsc/osmo-bsc-minimal.cfg b/doc/examples/osmo-bsc/osmo-bsc-minimal.cfg index b4e6e4a..011b9d7 100644 --- a/doc/examples/osmo-bsc/osmo-bsc-minimal.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc-minimal.cfg @@ -1,3 +1,11 @@ +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + network network country code 901 mobile network code 70 diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg b/doc/examples/osmo-bsc/osmo-bsc.cfg index 5c2cf34..32a8349 100644 --- a/doc/examples/osmo-bsc/osmo-bsc.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc.cfg @@ -1,6 +1,14 @@ ! osmo-bsc default configuration ! (assumes STP to run on 127.0.0.1 and uses default point codes) ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1_input e1_line 0 driver ipa network diff --git a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg index 8d334b2..f10221e 100644 --- a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg @@ -1,5 +1,13 @@ ! osmo-bsc configuration example for custom SCCP addresses ! +log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 + e1_input e1_line 0 driver ipa network diff --git a/doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg b/doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg index 8d75296..877ac6a 100644 --- a/doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg +++ b/doc/examples/osmo-bsc/siemens/osmo-bsc.bs11.cfg @@ -11,8 +11,9 @@ logging color 1 logging print category-hex 0 logging print category 1 - logging timestamp 1 - logging print file 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level llapd notice logging level linp notice logging level lmi notice -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I992ff466db768f625dd722d40829aa0301cc1705 Gerrit-Change-Number: 35182 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[M] Change in osmocom-bb[master]: mobile: Fix PCS ARFCN handling: PCS can only be ARFCN 512..810
by jolly 01 Dec '23

01 Dec '23

Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33532?usp=email ) Change subject: mobile: Fix PCS ARFCN handling: PCS can only be ARFCN 512..810 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007 Gerrit-Change-Number: 33532 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 01 Dec 2023 10:09:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops
by daniel 01 Dec '23

01 Dec '23

Attention is currently required from: arehbein, laforge, neels, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops ...................................................................... Patch Set 4: (2 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/1bcca390_cafaad48 PS3, Line 546: if (iofd->io_ops.read_cb) > ah ok, read_cb happens to be in the same place as recvfrom_cb, so only checking the one location wor […] This fix is only necessary after removing the union. I don't see how you could realize checking the exact member with the union in place. I can basically stick an ```c OSMO_ASSERT(&iofd->io_ops.read_cb == &iofd->io_ops.recvfrom_cb) ``` in here. Unless I'm missing something this is exactly the feature of the union, afterwards you can't know whether this memory location was set as read_cb or recvfrom_cb. File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/813d11cc_3e337a84 PS4, Line 391: || (iofd->mode == OSMO_IO_FD_MODE_RECVFROM_SENDTO && iofd->io_ops.recvfrom_cb)); > this code should also work with the union present? It "works" in the sense that it even returns true if mode == *_READ_WRITE and .recvfrom_cb (or the other way around) is set since both function pointers are sharing the same memory location. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec Gerrit-Change-Number: 35079 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 10:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: Transmit invalid AMR speech blocks instead of dummy FACCH
by jolly 01 Dec '23

01 Dec '23

Attention is currently required from: falconia, fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email ) Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ...................................................................... Patch Set 6: (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/35132/comment/2caa0774_46c1a43c PS6, Line 456: with > Grammar still not fixed here - you fixed the one in TCH/F, but not here. Grr.... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 Gerrit-Change-Number: 35132 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 10:02:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: Transmit invalid AMR speech blocks instead of dummy FACCH
by jolly 01 Dec '23

01 Dec '23

Attention is currently required from: fixeria, jolly, pespin. Hello Jenkins Builder, falconia, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Transmit invalid AMR speech blocks instead of dummy FACCH ...................................................................... Transmit invalid AMR speech blocks instead of dummy FACCH Every BTS needs to have some graceful handling for the scenario where it is time to send out a speech frame on TCH DL, but there is no frame to be sent. One possible solution is to transmit dummy FACCH, but this option is unattractive for TCH/AHS where FACCH displaces two speech frames rather than one. A more elegant solution is to emit a speech frame that is bad, causing the MS receiver to declare a BFI condition to trigger substitution and muting procedure. A bad frame is generated by gsm0503_tch_{afs,ahs}_encode() by setting the payload length to 0. Depends: libosmocore.git I82ce2adf995a4b42d1f378c5819f88d773b9104a Related: OS#6049 Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 57 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/35132/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I056f379715c91ad968f198e112d363a9009dc1c3 Gerrit-Change-Number: 35132 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops
by neels 01 Dec '23

01 Dec '23

Attention is currently required from: arehbein, daniel, laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops ...................................................................... Patch Set 4: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/4be00890_58bf8718 PS3, Line 546: if (iofd->io_ops.read_cb) > i fail to see the problem though, can you explain? ah ok, read_cb happens to be in the same place as recvfrom_cb, so only checking the one location worked out, but semantics dictate that we should check exactly the member that is matching the current iofd->mode. Yet this fix seems orthogonal to removing the union? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec Gerrit-Change-Number: 35079 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 02:08:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log