- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: LTE_CryptoFunctions.ttcn: Immediate termination upon failure
by fixeria 15 Dec '23

15 Dec '23

Attention is currently required from: daniel, dexter, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35364?usp=email ) Change subject: LTE_CryptoFunctions.ttcn: Immediate termination upon failure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I09170c17c5cbb552a8aeef31b4b8fa5c89a00887 Gerrit-Change-Number: 35364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 10:30:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/RLCMAC_EncDec: fix segfault in encode_trailing_padding_spb()
by osmith 15 Dec '23

15 Dec '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35373?usp=email ) Change subject: library/RLCMAC_EncDec: fix segfault in encode_trailing_padding_spb() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib0992a50026f0e0deebb959788ed6e79c5286fec Gerrit-Change-Number: 35373 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 10:28:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: clean up, drop remains of PCUIFv10
by osmith 15 Dec '23

15 Dec '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372?usp=email ) Change subject: library/PCUIF_Types: clean up, drop remains of PCUIFv10 ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: yes, we can do that now: master and latest use PCUIFv12, and 2023q1 uses the "2023q1" branch of osmo-ttcn3-hacks.git where PCUIFv10 is still available. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfe8558cb9f335d8c29348063b0ff02b138dd4c7 Gerrit-Change-Number: 35372 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 10:27:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: fix padding attribute for PCUIF_Message
by osmith 15 Dec '23

15 Dec '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35371?usp=email ) Change subject: library/PCUIF_Types: fix padding attribute for PCUIF_Message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35371?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If34da75c21b023222c44504d561cd6f658a401cf Gerrit-Change-Number: 35371 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 10:25:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/L1CTL_Types: add missing L1CTL_GPRS_RTS_IND message
by osmith 15 Dec '23

15 Dec '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35370?usp=email ) Change subject: library/L1CTL_Types: add missing L1CTL_GPRS_RTS_IND message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35370?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0772f5273ecc2fb0c3def1fd645828b216e3032f Gerrit-Change-Number: 35370 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 10:25:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: clean up, drop remains of PCUIFv10
by fixeria 15 Dec '23

15 Dec '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372?usp=email to look at the new patch set (#3). Change subject: library/PCUIF_Types: clean up, drop remains of PCUIFv10 ...................................................................... library/PCUIF_Types: clean up, drop remains of PCUIFv10 Change-Id: Ibfe8558cb9f335d8c29348063b0ff02b138dd4c7 Related: osmo-pcu.git I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8 Related: docker-playground.git If0b2209af645f391817f65b4227736b52ca59e2e Related: docker-playground.git I70f0c30d6c514614095dcbbcac5d025001861fbc Related: OS#6191 --- M bts/BTS_Tests.ttcn M library/PCUIF_CodecPort.ttcn M library/PCUIF_Types.ttcn M pcu/PCUIF_Components.ttcn 4 files changed, 64 insertions(+), 160 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/35372/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfe8558cb9f335d8c29348063b0ff02b138dd4c7 Gerrit-Change-Number: 35372 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/RLCMAC_EncDec: fix segfault in encode_trailing_padding_spb()
by fixeria 15 Dec '23

15 Dec '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35373?usp=email ) Change subject: library/RLCMAC_EncDec: fix segfault in encode_trailing_padding_spb() ...................................................................... library/RLCMAC_EncDec: fix segfault in encode_trailing_padding_spb() Change-Id: Ib0992a50026f0e0deebb959788ed6e79c5286fec Related: OS#6310 --- M library/RLCMAC_EncDec.cc 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/35373/1 diff --git a/library/RLCMAC_EncDec.cc b/library/RLCMAC_EncDec.cc index 1b56984..dd32d8f 100644 --- a/library/RLCMAC_EncDec.cc +++ b/library/RLCMAC_EncDec.cc @@ -455,6 +455,7 @@ if (data_len > blk_len_no_spb) { fprintf(stderr, "Buffer too large for requested CS! %s (%s:%u)\n", __func__, __FILE__, __LINE__); // TODO: throw exception? + return; } for (int i = 0; i < blk_len_no_spb - data_len; i++) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib0992a50026f0e0deebb959788ed6e79c5286fec Gerrit-Change-Number: 35373 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: clean up, drop remains of PCUIFv10
by fixeria 15 Dec '23

15 Dec '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: library/PCUIF_Types: clean up, drop remains of PCUIFv10 ...................................................................... library/PCUIF_Types: clean up, drop remains of PCUIFv10 Change-Id: Ibfe8558cb9f335d8c29348063b0ff02b138dd4c7 Related: osmo-pcu.git I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8 Related: OS#6191 --- M bts/BTS_Tests.ttcn M library/PCUIF_CodecPort.ttcn M library/PCUIF_Types.ttcn M pcu/PCUIF_Components.ttcn 4 files changed, 62 insertions(+), 160 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/35372/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfe8558cb9f335d8c29348063b0ff02b138dd4c7 Gerrit-Change-Number: 35372 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: fix padding attribute for PCUIF_Message
by fixeria 15 Dec '23

15 Dec '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35371?usp=email ) Change subject: library/PCUIF_Types: fix padding attribute for PCUIF_Message ...................................................................... library/PCUIF_Types: fix padding attribute for PCUIF_Message This fixes tons of warnings like this one: dec_PCUIF_Message(): Data remained at the end of the stream after successful decoding: '00'O Change-Id: If34da75c21b023222c44504d561cd6f658a401cf Fixes: e0666ea5 "PCUIF: upgrade to PCUIF v12" Related: OS#6191 --- M library/PCUIF_Types.ttcn 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/35371/1 diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn index 33b454f..5ed87b6 100644 --- a/library/PCUIF_Types.ttcn +++ b/library/PCUIF_Types.ttcn @@ -400,8 +400,8 @@ pag_req, msg_type = PCU_IF_MSG_PAG_REQ; app_info_req, msg_type = PCU_IF_MSG_APP_INFO_REQ; container, msg_type = PCU_IF_MSG_CONTAINER)" - /* PCUIFv10: 1006 * 8 = 8048 bits */ - variant "PADDING(8048)" + /* PCUIFv12: 1007 * 8 = 8056 bits */ + variant "PADDING(8056)" }; external function enc_PCUIF_Message(in PCUIF_Message pdu) return octetstring -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35371?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If34da75c21b023222c44504d561cd6f658a401cf Gerrit-Change-Number: 35371 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/L1CTL_Types: add missing L1CTL_GPRS_RTS_IND message
by fixeria 15 Dec '23

15 Dec '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35370?usp=email ) Change subject: library/L1CTL_Types: add missing L1CTL_GPRS_RTS_IND message ...................................................................... library/L1CTL_Types: add missing L1CTL_GPRS_RTS_IND message This commit fixes the following warnings: While RAW-decoding type '@L1CTL_Types.L1ctlMessageLV': Invalid enum value '37' for '@L1CTL_Types.L1ctlMsgType': Change-Id: I0772f5273ecc2fb0c3def1fd645828b216e3032f Related: osmocom-bb.git I1494e0aac7555f6e01b4b435b77140afc42c098e --- M library/L1CTL_Types.ttcn 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/35370/1 diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn index 73e09fc..2e1f34b 100644 --- a/library/L1CTL_Types.ttcn +++ b/library/L1CTL_Types.ttcn @@ -53,7 +53,8 @@ L1CTL_GPRS_DL_TBF_CFG_REQ, L1CTL_GPRS_UL_BLOCK_REQ, L1CTL_GPRS_DL_BLOCK_IND, - L1CTL_EXT_RACH_REQ + L1CTL_EXT_RACH_REQ, + L1CTL_GPRS_RTS_IND } with { variant "FIELDLENGTH(8)" }; type enumerated L1ctlCcchMode { @@ -353,6 +354,13 @@ octetstring data } with { variant (data) "BYTEORDER(first)" }; + /* payload of L1CTL_GPRS_RTS_IND */ + type record L1ctlGprsRtsInd { + uint32_t fn, + uint8_t tn, + uint8_t usf + } with { variant "" }; + type union L1ctlMsgPayload { L1ctlFbsbReq fbsb_req, @@ -384,6 +392,7 @@ L1ctlGprsUlBlockReq ul_block_req, L1ctlGprsDlBlockInd dl_block_ind, L1ctlExtRachReq ext_rach_req, + L1ctlGprsRtsInd rts_ind, octetstring other } with { variant (other) "BYTEORDER(first)" @@ -438,6 +447,7 @@ ul_block_req, header.msg_type = L1CTL_GPRS_UL_BLOCK_REQ; dl_block_ind, header.msg_type = L1CTL_GPRS_DL_BLOCK_IND; ext_rach_req, header.msg_type = L1CTL_EXT_RACH_REQ; + rts_ind, header.msg_type = L1CTL_GPRS_RTS_IND; other, OTHERWISE; )" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35370?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0772f5273ecc2fb0c3def1fd645828b216e3032f Gerrit-Change-Number: 35370 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

2026

2025

2024

2023

2022

gerrit-log