- gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: Add LLC and HLC information to MNCC interface definiton
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email ) Change subject: Add LLC and HLC information to MNCC interface definiton ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: We cannot add new fields to the MNCC protocol without bumping the protocol version. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15f5afcf069ee6c1c4641108ceacc837bee311b5 Gerrit-Change-Number: 35392 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Dec 2023 16:54:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: Add LLC and HLC transcoding to MNCC transcoding functions
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email ) Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ...................................................................... Patch Set 2: (1 comment) File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/1284efa6_c3f4a299 PS2, Line 413: gsm48_encode_highl_compat The `encode`/`decode` in symbol names creates a false impression that these functions actually `encode`/`decode` from/to an abstract representation. We may need the actual encoding/decoding on the MS side (osmocom-bb). Maybe call it pack/unpack or wrap/unwrap to avoid confusion? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de Gerrit-Change-Number: 35391 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Dec 2023 16:53:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: extend documentation about transports
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35388?usp=email ) Change subject: extend documentation about transports ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I84d926b45c97477e77a7852bc8254ce9a7614a33 Gerrit-Change-Number: 35388 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:53:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: docs/shell: extend the introduction part; link to video presentation
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35387?usp=email ) Change subject: docs/shell: extend the introduction part; link to video presentation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77c30921f2b8c002c9dda244656c348c96b41f06 Gerrit-Change-Number: 35387 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:52:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: OML: Add Get Attributes for supported MOs for Channel Object Class
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email ) Change subject: OML: Add Get Attributes for supported MOs for Channel Object Class ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35379?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I56e067be9e5c17625c7da4e982b90927802f57b4 Gerrit-Change-Number: 35379 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:50:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: OML: Add Get Attributes for supported MOs for Radio Carrier Object Class
by fixeria 19 Dec '23

19 Dec '23

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email ) Change subject: OML: Add Get Attributes for supported MOs for Radio Carrier Object Class ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I49ab516c38a986520f1d3f6e26ddd20ee16688ac Gerrit-Change-Number: 35378 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:48:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: Add LLC and HLC information to MNCC interface definiton
by jolly 19 Dec '23

19 Dec '23

Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email ) Change subject: Add LLC and HLC information to MNCC interface definiton ...................................................................... Patch Set 1: (1 comment) File include/osmocom/msc/mncc.h: https://gerrit.osmocom.org/c/osmo-msc/+/35392/comment/470efbe3_b87612d6 PS1, Line 113: #define MNCC_F_BEARER_CAP 0x00000001 : #define MNCC_F_CALLED 0x00000002 : #define MNCC_F_CALLING 0x00000004 : #define MNCC_F_REDIRECTING 0x00000008 : #define MNCC_F_CONNECTED 0x00000010 : #define MNCC_F_CAUSE 0x00000020 : #define MNCC_F_USERUSER 0x00000040 : #define MNCC_F_PROGRESS 0x00000080 : #define MNCC_F_EMERGENCY 0x00000100 : #define MNCC_F_FACILITY 0x00000200 : #define MNCC_F_SSVERSION 0x00000400 : #define MNCC_F_CCCAP 0x00000800 : #define MNCC_F_KEYPAD 0x00001000 : #define MNCC_F_SIGNAL 0x00002000 : #define MNCC_F_GCR 0x00004000 > unrelated cosmetic change. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15f5afcf069ee6c1c4641108ceacc837bee311b5 Gerrit-Change-Number: 35392 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:36:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: Add LLC and HLC information to MNCC interface definiton
by jolly 19 Dec '23

19 Dec '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add LLC and HLC information to MNCC interface definiton ...................................................................... Add LLC and HLC information to MNCC interface definiton low/high layer compatibility are used for capability checking between caller and called entitiy. The information is added to the end of struct gsm_mncc increases, so that the version number needs not to be incremented. Related: OS#6152 Change-Id: I15f5afcf069ee6c1c4641108ceacc837bee311b5 --- M include/osmocom/msc/mncc.h 1 file changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/35392/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15f5afcf069ee6c1c4641108ceacc837bee311b5 Gerrit-Change-Number: 35392 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: Add LLC and HLC transcoding to MNCC transcoding functions
by jolly 19 Dec '23

19 Dec '23

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email ) Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ...................................................................... Patch Set 1: (3 comments) File include/osmocom/gsm/gsm48_ie.h: https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/b6766107_5b40f5c3 PS1, Line 39: /* decode 'high layer complatibility' */ > "compatibility" in all lines. Done File include/osmocom/gsm/mncc.h: https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/827ec537_14b5c33b PS1, Line 35: struct gsm_mncc_lowl_compat { > some spec reference on what is this about would be nice. Done File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/a2d46645_a6a3c850 PS1, Line 412: /*! Encode TS 04.08 High Layer compatibility IE (10.5.4.16) */ > AFAIU this is all really a len and a buffer, so I don't really see the need for a specific structure […] You are right, I simplified the functions by removing the 'local buffer'. I want to have a structure that provides information of content, length and maximum size. Using just a pointer would require an extra length field in the MNCC message for both LLC and HLC. Parsed values can be added to the structure in the future. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de Gerrit-Change-Number: 35391 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Dec 2023 15:32:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: Add LLC and HLC transcoding to MNCC transcoding functions
by jolly 19 Dec '23

19 Dec '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ...................................................................... Add LLC and HLC transcoding to MNCC transcoding functions low/high layer compatibility are used for capability checking between caller and called entitiy. They are transparently forwarded, so there is no parsing or assembling of the elements. Related: OS#6152 Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de --- M include/osmocom/gsm/gsm48_ie.h M include/osmocom/gsm/mncc.h M src/gsm/gsm48_ie.c M src/gsm/libosmogsm.map 4 files changed, 90 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/35391/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de Gerrit-Change-Number: 35391 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log