- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: mme: Use LAC from SGSN with most significat bit set to 0
by pespin 22 Dec '23

22 Dec '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35430?usp=email ) Change subject: mme: Use LAC from SGSN with most significat bit set to 0 ...................................................................... mme: Use LAC from SGSN with most significat bit set to 0 According to 3GPP TS 23.003 sec 2.8.2.2.2, LACs from GERAN are configured with MSB 0 in order to differentiate it from EUTRAN ones. This is used by MMEs to figure out if the peer is an SGSN, based on the the LAC mapped into MME group ID in GUTI . Change-Id: Iaf89228f6f026e04d5f583211959025e6d8d4a1d --- M mme/MME_Tests.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/35430/1 diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 6a375e0..7d0573e 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -196,7 +196,7 @@ integer mp_gn_remote_port := 2123; hexstring mp_gn_local_mcc := '262'H; hexstring mp_gn_local_mnc := 'f42'H; - uint16_t mp_gn_local_lac := 43690; + uint16_t mp_gn_local_lac := 39594; uint8_t mp_gn_local_rac := 187; uint16_t mp_gn_local_ci := 1223; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf89228f6f026e04d5f583211959025e6d8d4a1d Gerrit-Change-Number: 35430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: tests: use case-insensitive compare of hex strings
by laforge 22 Dec '23

22 Dec '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35423?usp=email ) Change subject: tests: use case-insensitive compare of hex strings ...................................................................... tests: use case-insensitive compare of hex strings Change-Id: I080f6e173fec40c27dd3ebbf252eaddf5a0e15ba --- M tests/test_files.py 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/tests/test_files.py b/tests/test_files.py index fe520fb..733f04c 100755 --- a/tests/test_files.py +++ b/tests/test_files.py @@ -86,7 +86,7 @@ decoded = t[2] logging.debug("Testing encode of %s", name) re_enc = inst.encode_record_hex(decoded, rec_num) - self.assertEqual(encoded, re_enc) + self.assertEqual(encoded.upper(), re_enc.upper()) def test_de_encode_record(self): """Test the decoder and encoder for a linear-fixed EF. Performs first a decoder @@ -119,7 +119,7 @@ # re-encode the decoded data logging.debug("Testing re-encode of %s", name) re_enc = inst.encode_record_hex(re_dec, rec_num) - self.assertEqual(encoded, re_enc) + self.assertEqual(encoded.upper(), re_enc.upper()) class TransRecEF_Test(unittest.TestCase): @@ -182,7 +182,7 @@ # re-encode the decoded data logging.debug("Testing re-encode of %s", name) re_enc = inst.encode_record_hex(re_dec) - self.assertEqual(encoded, re_enc) + self.assertEqual(encoded.upper(), re_enc.upper()) class TransparentEF_Test(unittest.TestCase): @@ -254,7 +254,7 @@ logging.debug("Testing re-encode of %s", name) re_dec = inst.decode_hex(encoded) re_enc = inst.encode_hex(re_dec) - self.assertEqual(encoded, re_enc) + self.assertEqual(encoded.upper(), re_enc.upper()) if __name__ == '__main__': -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I080f6e173fec40c27dd3ebbf252eaddf5a0e15ba Gerrit-Change-Number: 35423 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: test/test_files: set maxDiff attribute
by laforge 22 Dec '23

22 Dec '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35417?usp=email ) Change subject: test/test_files: set maxDiff attribute ...................................................................... test/test_files: set maxDiff attribute Without this the diff between expected and actual output is truncated and one instead reads the following output: Diff is 844 characters long. Set self.maxDiff to None to see it. We actually want to see the full diff to see what's not matching. Change-Id: I6e89705061454191b6db1255de7fe549ad720800 --- M tests/test_files.py 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/tests/test_files.py b/tests/test_files.py index 733f04c..24a80a1 100755 --- a/tests/test_files.py +++ b/tests/test_files.py @@ -37,6 +37,7 @@ class LinFixed_Test(unittest.TestCase): classes = all_subclasses(LinFixedEF) + maxDiff = None def test_decode_record(self): """Test the decoder for a linear-fixed EF. Requires the given LinFixedEF subclass @@ -124,6 +125,7 @@ class TransRecEF_Test(unittest.TestCase): classes = all_subclasses(TransRecEF) + maxDiff = None def test_decode_record(self): """Test the decoder for a transparent record-oriented EF. Requires the given TransRecEF subclass @@ -186,6 +188,8 @@ class TransparentEF_Test(unittest.TestCase): + maxDiff = None + @classmethod def get_classes(cls): """get list of TransparentEF sub-classes which are not a TransRecEF subclass.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6e89705061454191b6db1255de7fe549ad720800 Gerrit-Change-Number: 35417 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[M] Change in pysim[master]: fix encode/decode of xPLMNwAcT
by laforge 22 Dec '23

22 Dec '23

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35415?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: fix encode/decode of xPLMNwAcT ...................................................................... fix encode/decode of xPLMNwAcT There are some pretty intricate rules about how GSM and E-UTRAN are encoded, let's make sure we fully support both as per 3GPP TS 31.102 Release 17. As part of this, swithc from a list of access technologies to a set, as there is no order. This makes comparing in unit tests much easier. However, it also means that we need to sort the set when printing the list of AcT in pySim-read to generate deterministic output. Change-Id: I398ac2a2527bd11e9c652e49fa46d6ca8d334b88 --- M pySim/legacy/utils.py M pySim/ts_51_011.py M pySim/utils.py M pysim-testdata/Fairwaves-SIM.ok M pysim-testdata/Wavemobile-SIM.ok M pysim-testdata/sysmoISIM-SJA2.ok M pysim-testdata/sysmoUSIM-SJS1.ok M tests/test_utils.py 8 files changed, 66 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/15/35415/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I398ac2a2527bd11e9c652e49fa46d6ca8d334b88 Gerrit-Change-Number: 35415 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-mgw[master]: mgcp_client_test: add test_parse_response()
by pespin 22 Dec '23

22 Dec '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35422?usp=email ) Change subject: mgcp_client_test: add test_parse_response() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I842ce65a9a70f313570857b7df53727cc572b9e6 Gerrit-Change-Number: 35422 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Dec 2023 10:01:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: client SDP: more verbose error logging
by pespin 22 Dec '23

22 Dec '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35421?usp=email ) Change subject: client SDP: more verbose error logging ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35421/comment/0ec36c09_ca30d24f PS1, Line 376: LOGP(DLMGCP, LOGL_ERROR, So now this log line can be dropped? it makes no sense to print twice imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibc6343db82281789004c140ba98d99e5f6f73d83 Gerrit-Change-Number: 35421 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Dec 2023 10:00:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: client: allow MGCP_MAX_CODECS entries
by pespin 22 Dec '23

22 Dec '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35420?usp=email ) Change subject: client: allow MGCP_MAX_CODECS entries ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35420?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9a28da85e437f118026ea71a5a708e5758fff623 Gerrit-Change-Number: 35420 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Dec 2023 09:59:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-mgw[master]: client: collapse codecs[] and ptmap[]; allow codec variants
by pespin 22 Dec '23

22 Dec '23

Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34899?usp=email ) Change subject: client: collapse codecs[] and ptmap[]; allow codec variants ...................................................................... Patch Set 11: Code-Review+1 (1 comment) Patchset: PS11: You may want to add info about deprecated fields/symbols in TODO-RELEASE. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I798e02c6663376d3d52f4a74fc4b32411ce95bed Gerrit-Change-Number: 34899 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Dec 2023 09:57:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: client: deprecate legacy API
by pespin 22 Dec '23

22 Dec '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35419?usp=email ) Change subject: client: deprecate legacy API ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7409907dafbb2fe905fee9bc22d6870056bf3022 Gerrit-Change-Number: 35419 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Dec 2023 09:54:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: test/test_files: set maxDiff attribute
by fixeria 22 Dec '23

22 Dec '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35417?usp=email ) Change subject: test/test_files: set maxDiff attribute ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6e89705061454191b6db1255de7fe549ad720800 Gerrit-Change-Number: 35417 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 22 Dec 2023 09:40:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log