- gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsm: fix osmo_mobile_identity_decode(): init *mi on error
by fixeria 08 Jan '24

08 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35504?usp=email ) Change subject: gsm: fix osmo_mobile_identity_decode(): init *mi on error ...................................................................... gsm: fix osmo_mobile_identity_decode(): init *mi on error Change-Id: I1c1503120c6c0e5479d8350fe762470bdb6266b8 --- M src/gsm/gsm48.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/35504/1 diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 4f79026..64b1765 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -641,8 +641,10 @@ char *str = NULL; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */ size_t str_size = 0; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */ - if (!mi_data || mi_len < 1) - return -EBADMSG; + if (!mi_data || mi_len < 1) { + rc = -EBADMSG; + goto return_error; + } nibbles_len = (mi_len - 1) * 2 + ((mi_data[0] & GSM_MI_ODD) ? 1 : 0); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c1503120c6c0e5479d8350fe762470bdb6266b8 Gerrit-Change-Number: 35504 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: trau/osmo_ortp: support building without OrtpMemoryFunctions API
by fixeria 08 Jan '24

08 Jan '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email ) Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Same as libosmocore and talloc. It's not the same situation, because again: libosmocore explicitly depends on libtalloc. Whatever ortp is using is the internal details of ortp: they may switch to some other library any day. And btw, bctoolbox is a relatively recent dependency, which was introduced since linphone.org started maintaining ortp. It was not the case for old ortp versions. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 Gerrit-Change-Number: 35502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 14:42:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libsmpp34[master]: fix warnings about implicit declaration of strtol()
by pespin 08 Jan '24

08 Jan '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/35503?usp=email ) Change subject: fix warnings about implicit declaration of strtol() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/35503?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I16d9e0171d4c26f721c300e22c78b77f6db4895c Gerrit-Change-Number: 35503 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 14:36:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: trau/osmo_ortp: support building without OrtpMemoryFunctions API
by pespin 08 Jan '24

08 Jan '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email ) Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This is indeed an option, but we don't depend on bctoolbox directly (it's a dependency of ortp itsel […] include/ortp/port.h does publicly use lots of bctoolbox stuff and does "#include "bctoolbox/port.h"", so my understanding is that bctoolbox is a public dependency of ortp and hecne can also be used. Same as libosmocore and talloc. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 Gerrit-Change-Number: 35502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 14:36:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23: migrate away from deprecated gsm48_mi_to_string
by fixeria 08 Jan '24

08 Jan '24

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: layer23: migrate away from deprecated gsm48_mi_to_string ...................................................................... Patch Set 4: -Code-Review (1 comment) Patchset: PS4: > did you test this manually using osmocombb against a network? I gave this patch a try, and there is a little problem: ``` DRR NOTICE app_ccch_scan.c:285 Paging1: Normal paging chan any to tmsi M(TMSI-0xE8D0A894) ``` so now ccch_scan is printing the MI type twice. I will fix this. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ida67adaa61689c55505a89e1a1bebde041c91139 Gerrit-Change-Number: 33317 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 08 Jan 2024 14:31:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libsmpp34[master]: fix warnings about implicit declaration of strtol()
by fixeria 08 Jan '24

08 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libsmpp34/+/35503?usp=email ) Change subject: fix warnings about implicit declaration of strtol() ...................................................................... fix warnings about implicit declaration of strtol() This commit fixes several warnings like this one: In file included from ../../../src/libsmpp34/test_apps/smpp.c:40: test_apps/smpp.c: In function ‘do_smpp_send_message2’: test_apps/esme.h:32:16: warning: implicit declaration of function ‘strtol’; did you mean ‘strtok’? [-Wimplicit-function-declaration] 32 | dst = strtol((char*)clave, NULL, 10);\ | ^~~~~~ test_apps/smpp.c:223:5: note: in expansion of macro ‘GET_PROP_INT’ 223 | GET_PROP_INT( req.source_addr_ton, p, "source_addr_ton" ); | ^~~~~~~~~~~~ Change-Id: I16d9e0171d4c26f721c300e22c78b77f6db4895c --- M test_apps/esme.c M test_apps/sendwp.c M test_apps/smpp.c M test_apps/tcp.c 4 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/03/35503/1 diff --git a/test_apps/esme.c b/test_apps/esme.c index 77fb198..5d9dafd 100644 --- a/test_apps/esme.c +++ b/test_apps/esme.c @@ -23,6 +23,7 @@ */ #include <stdio.h> +#include <stdlib.h> #include <unistd.h> #include <string.h> #include <libxml/xmlmemory.h> diff --git a/test_apps/sendwp.c b/test_apps/sendwp.c index b719c45..f75af76 100644 --- a/test_apps/sendwp.c +++ b/test_apps/sendwp.c @@ -23,6 +23,7 @@ */ #include <stdio.h> +#include <stdlib.h> #include <unistd.h> #include <string.h> #include <libxml/xmlmemory.h> diff --git a/test_apps/smpp.c b/test_apps/smpp.c index c764907..2cdb138 100644 --- a/test_apps/smpp.c +++ b/test_apps/smpp.c @@ -23,6 +23,7 @@ */ #include <stdio.h> +#include <stdlib.h> #include <unistd.h> #include <string.h> #include <sys/types.h> diff --git a/test_apps/tcp.c b/test_apps/tcp.c index 4cf681d..3051df2 100644 --- a/test_apps/tcp.c +++ b/test_apps/tcp.c @@ -28,6 +28,7 @@ #include <arpa/inet.h> #include <netdb.h> #include <stdio.h> +#include <stdlib.h> #include <unistd.h> #include <string.h> #include <libxml/xmlmemory.h> -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/35503?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I16d9e0171d4c26f721c300e22c78b77f6db4895c Gerrit-Change-Number: 35503 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: trau/osmo_ortp: support building without OrtpMemoryFunctions API
by fixeria 08 Jan '24

08 Jan '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email ) Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Maybe use the new bctoolbox APIs if available instead of falling back to whatever is default? This is indeed an option, but we don't depend on bctoolbox directly (it's a dependency of ortp itself), so I don't think we can use its API. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 Gerrit-Change-Number: 35502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 13:37:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: trau/osmo_ortp: support building without OrtpMemoryFunctions API
by pespin 08 Jan '24

08 Jan '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email ) Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Maybe use the new bctoolbox APIs if available instead of falling back to whatever is default? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 Gerrit-Change-Number: 35502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 13:29:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: trau/osmo_ortp: support building without OrtpMemoryFunctions API
by fixeria 08 Jan '24

08 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email ) Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API ...................................................................... trau/osmo_ortp: support building without OrtpMemoryFunctions API Recent ortp versions (v5.3.0+, maintained by linphone.org) no longer have the memory allocator configuration API. See the related commit: https://gitlab.linphone.org/BC/public/ortp/-/commit/9ba9db486a61bebeb11287e… A similar API is provided by bctoolbox, a dependency of ortp: void bctbx_set_memory_functions(BctoolboxMemoryFunctions *functions); Let's support building against v5.3.0+ by checking (in ./configure) if the old API is available. Use talloc if possible; otherwise fall-back to whatever ortp uses by default (glibc's malloc). Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 --- M configure.ac M src/trau/osmo_ortp.c 2 files changed, 43 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/02/35502/1 diff --git a/configure.ac b/configure.ac index 37ac91a..5097c93 100644 --- a/configure.ac +++ b/configure.ac @@ -161,6 +161,19 @@ [rtp_session_signal_connect requires ulong parameter])]) CFLAGS=$_cflags_save +_cflags_save=$CFLAGS +CFLAGS="$CFLAGS $ORTP_CFLAGS" +AC_COMPILE_IFELSE( + [AC_LANG_PROGRAM( + [[#include <ortp/ortp.h>]], + [[OrtpMemoryFunctions memfn = { };]] + )], + [AC_DEFINE([HAVE_ORTP_MEM_FUNC], [1], + [OrtpMemoryFunctions is available, will use talloc])], + [AC_DEFINE([HAVE_ORTP_MEM_FUNC], [0], + [OrtpMemoryFunctions is not available])]) +CFLAGS=$_cflags_save + AC_MSG_RESULT([CFLAGS="$CFLAGS"]) AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c index 015ac34..701b81d 100644 --- a/src/trau/osmo_ortp.c +++ b/src/trau/osmo_ortp.c @@ -47,7 +47,7 @@ static void *tall_rtp_ctx; /* malloc integration */ - +#if HAVE_ORTP_MEM_FUNC static void *osmo_ortp_malloc(size_t sz) { return talloc_size(tall_rtp_ctx, sz); @@ -68,6 +68,7 @@ .realloc_fun = osmo_ortp_realloc, .free_fun = osmo_ortp_free }; +#endif /* HAVE_ORTP_MEM_FUNC */ /* logging */ @@ -121,13 +122,14 @@ needs_endl = fmt[fmt_len - 1] != '\n' ? 1 : 0; - str = osmo_ortp_malloc(domain_len + 2 /*": "*/ + fmt_len + needs_endl + 1); - sprintf(str, "%s%s%s%s", domain_str, domain_len ? ": " : "", fmt, needs_endl ? "\n" : ""); + str = talloc_asprintf(tall_rtp_ctx, "%s%s%s%s", + domain_str, domain_len ? ": " : "", + fmt, needs_endl ? "\n" : ""); osmo_vlogp(DLMIB, ortp_to_osmo_lvl(lev), __FILE__, 0, 0, str, args); - osmo_ortp_free(str); + talloc_free(str); } @@ -315,7 +317,9 @@ void osmo_rtp_init(void *ctx) { tall_rtp_ctx = ctx; +#if HAVE_ORTP_MEM_FUNC ortp_set_memory_functions(&osmo_ortp_memfn); +#endif ortp_init(); ortp_set_log_level_mask( #if HAVE_ORTP_LOG_DOMAIN -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 Gerrit-Change-Number: 35502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in pysim[master]: pySim-shell: Update manual with examples for using with eUICC ISD-R
by laforge 08 Jan '24

08 Jan '24

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35499?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: pySim-shell: Update manual with examples for using with eUICC ISD-R ...................................................................... pySim-shell: Update manual with examples for using with eUICC ISD-R Change-Id: I4a0acdad5c7478ee76f92c7610c0e2a5331dea46 --- M docs/shell.rst 1 file changed, 215 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/35499/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4a0acdad5c7478ee76f92c7610c0e2a5331dea46 Gerrit-Change-Number: 35499 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

2026

2025

2024

2023

2022

gerrit-log